Commit Graph

6 Commits

Author SHA1 Message Date
Kyle D. McCormick
2cd3dc844d fix: NameErrors in compile_sass.py
Fixes three NameErrors which were introduced by the previous commit,
leading to it being reverted.

These NameErrors slipped through because the script was not tested on
any themes that had zero SCSS overrides.
2024-04-12 11:33:31 -04:00
Kyle D. McCormick
f57d412c71 revert: revert: build: remove dependency on Python sass module
This reverts commit a27cda2fd9.
2024-04-12 11:33:31 -04:00
Kyle McCormick
a27cda2fd9 revert: "build: remove dependency on Python sass module (#34439)" (#34476)
This reverts commit a08a10c396.

compile_sass.py had a bug which was caught by 2U's pipeline, but not
by local testing.
2024-04-05 11:59:58 -04:00
Kyle McCormick
a08a10c396 build: remove dependency on Python sass module (#34439)
Instead of using libsass-python's `sass` module, which is incompatible
with Python 3.11, we now directly use libsass-python's `_sass` module,
which directly binds to the underlying C++ libsass library.

This ensures that the Sass build will not a blocker for the edx-platform
Python 3.11 upgrade, which needs to land in Redwood.

For more details, see the docstring at scripts/compile_sass.py#L167
2024-04-05 10:50:05 -04:00
Kyle D. McCormick
bd82b1d75a docs: npm scripts for static assets are no longer experimental :) 2024-04-04 10:31:02 -04:00
Kyle McCormick
3e67719a24 build: npm run build (experimental) (#32823)
This PR implements much of the static assets rework ADR [1], including:

* `npm run build[-dev]`, and its subcommands,
* `npm run webpack[-dev]` and
* `npm run compile-sass[-dev]`.

This is backwards-compatible. `paver update_assets` should not be affected.
The new command warns that it is "experimental" for a few reasons:

* `npm run build` will fail in the webpack phase unless you first
run  `xmodule_assets`. This will be changed soon [2].

* We have tested the new build, but not quite so thoroughly that we'd
recommend it as the production default yet. Once the xmodule_assets
work lands, we'll share this on the forums so early adopters can try it
out.

* The commands lack some top-level documentation. Once they stabilize more,
we'll add a section to the README that explains how and when to use `npm run
build` and its subcommands and its env vars.

* `npm run watch` is not yet implemented.

References:
1. https://github.com/openedx/edx-platform/blob/master/docs/decisions/0017-reimplement-asset-processing.rst
2. https://github.com/openedx/edx-platform/pull/32685

Part of: https://github.com/openedx/edx-platform/issues/31604
2023-07-26 08:04:45 -04:00