Commit Graph

348 Commits

Author SHA1 Message Date
mubbsharanwar
7b299977b7 fix:Login failed email_or_username
Fix email_or_username null in login failed case.

Fixes: VAN-532
2021-06-14 10:38:40 +05:00
Adeel Ehsan
335a0f28de Merge pull request #27661 from edx/aehsan/VAN-434/account_activation_dialogue_box_added
Account activation popup added
2021-06-10 15:20:15 +05:00
adeelehsan
78f1f1916c Account activation popup added
VAN-434
2021-06-10 14:46:49 +05:00
Simon Chen
a284b9704c [Fix]: CR-3731 correct the spelling of the error message on password reset (#27883) 2021-06-08 11:33:37 -04:00
uzairr
dd5c3790c3 refactor login api 2021-05-21 19:59:41 +05:00
Waheed Ahmed
ea29318f22 fix: username suggestion generation (#27641)
If all generated usernames using an integer range are already consumed by existing
users, the loop stuck in an infinite loop. Fixed by using a for loop instead of
while with an upper limit.
2021-05-19 14:53:06 +05:00
Usama Sadiq
4f4be6538a BOM-2477: pylint warnings lint-amnesty (#27585) 2021-05-11 17:22:40 +05:00
uzairr
e291e383f6 refactor failed login response 2021-05-11 16:20:34 +05:00
Alex Dusenbery
4b247013ff feat: account activation now supports a next query param. ENT-4433
This change causes the activation link that’s emailed to a newly-registered user
to utilize a next query parameter. The impetus for this change is an edX Enterprise use-case:
we'd like newly registered Enterprise Customer admins and learners
to be directed to the Enterprise Learner Portal (or Admin Portal) upon account activation.
This is likely a broad enough use case to be valuable in other endeavors.
2021-05-10 12:58:26 -04:00
Usama Sadiq
63a9327a9d refactor: pyupgrade second iteration (#27460) 2021-05-10 13:57:24 +05:00
Adeel Ehsan
798b523712 Revert "CTA dialogue added" (#27560) 2021-05-07 16:17:18 +05:00
Adeel Ehsan
03a8dbffb7 Merge pull request #27334 from edx/aehsan/Van-434/cta_dialogue_box_added
CTA dialogue added
2021-05-07 05:42:56 +05:00
adeelehsan
dc306f8f6d CTA dialogue added
VAN-434
2021-05-05 23:29:47 +05:00
Waheed Ahmed
3e87c1f277 refactor: update username suggestions logic (#27525)
Used integers instead of alphanumerics to generate username suggestions.

VAN-52
2021-05-05 23:28:55 +05:00
Uzair Rasheed
c450de4062 Merge pull request #27496 from edx/update-login-api
upgrade login api
2021-05-05 13:15:22 +05:00
Zainab Amir
8d4ccf950a Update validation messages for register endpoint (#27476)
As part of authn redesign, validation messages have been updated.
- created a new endpoint for validations
- updated username/email conflict message in registration api based on
authn check

VAN-288
2021-05-05 12:33:59 +05:00
Michael Terry
35f78a3241 feat!: remove all email_marketing djangoapp code
This djangoapp was designed for talking to sailthru, in a fairly
edx.org-specific way. Nowadays, edx.org doesn't need this code and
if other installations do, it's better off as a more distinct
plugin anyway, rather than direct support in the platform.

I've moved the one signal that was still useful (calling
segment.identify() whenever user fields change) into user_authn.

And I've left the EmailMarketingConfiguration model alone for now,
but will remove that shortly. Nothing uses it as of this commit.

AA-607
DEPR-139
2021-05-03 16:39:01 -04:00
uzairr
ac054f92b1 upgrade login api
Modify the existing login api in a way that
it will allow the user to login via username as well.
currently it is only allowing email to log the user in.

VAN-445
2021-05-03 11:38:07 +05:00
Shafqat Farhan
30bf95b053 VAN-437 - Unlocking the learners upon successful password reset 2021-04-30 18:36:21 +05:00
Binod Pant
735d01283e ENT-4383 fix the hinted login page experience when enterprise login enables hinted login (#27431)
* fix: 🐛 Correctly check that saml provider is available using tpa_hint in next param

This fixes the issue of 404 when an enterprise customer sends a tpa_hint in next, but that param is not correctly checked to disable auth MFE. The hinted login page now works with this change.

ENT-4383

* feat: comment update

comment update

ENT-4383
2021-04-27 11:33:00 -04:00
Julia Eskew
4462ed37b2 Revert "update login api" (#27416)
This PR might be causing e2e tests to fail. Reverting and merging without waiting on tests.
2021-04-26 10:07:36 -04:00
Mubbshar Anwar
2ab1f8f9c9 Merge pull request #27380 from edx/VAN-366
Add country code in MFEAppContextView
2021-04-23 20:05:59 +05:00
mubbsharanwar
709e31a2aa Add country code in MFEAppContextView
add new api MFEAppContextView to handle country code
add unit test MFEAppContextViewTest
this newly created api will be marged in TPAContextViewTest when margeing code in master branch

VAN-366
2021-04-23 19:12:35 +05:00
uzairr
5103f59df9 upgrade login api
Modify the existing login api in a way that
it will allow the user to login via username as well.
currently it is only allowing email to log the user in.

VAN-445
2021-04-23 17:21:18 +05:00
Waheed Ahmed
5aa8245133 add username suggestions functionality (#27387)
Added username suggestions functionality upon username already exists
validation error for both registration and registration validation
endpoints.

VAN-52
2021-04-22 14:08:40 +05:00
Igor Degtiarov
70ab50181a fix: Hide enterprise/login button if enterprise integration disabled. (#27130)
* fix: Hide enterprise/login button if enterprise integration disabled.

[BTR-52](https://openedx.atlassian.net/browse/BTR-52)
Fix an issue with existing button for enterprise login on the login page
when enterprise integration is disabled.

* Address review comments
2021-04-15 11:54:56 +05:00
Ali-D-Akbar
fcf8a0e221 fix: allow staff or superuser to reset password from support tools 2021-04-14 16:26:47 +05:00
Ali Akbar
d1856c27a1 Merge pull request #27284 from edx/aakbar/PROD-2337
Allow reset password from Support Tools
2021-04-12 21:32:20 +05:00
Ali-D-Akbar
2b5cb1caad fix!: allow reset password from support tools 2021-04-12 21:06:41 +05:00
uzairr
1d5a95facb Add independent ratelimit setting for forms
Currently, login and registration forms and view to log the user in
are sharing same ratelimit settings which is causing too much noise
while rendering forms.This PR will introduce a separate
setting for logistration forms.

VAN-436
2021-04-09 21:10:08 +05:00
Jawayria
7024f51a17 Merge pull request #26603 from edx/jawayria/bom-2408-5
BOM-2408: Removed unused imports from openedx/core/djangoapps/{themin…
2021-04-09 19:32:12 +05:00
Usama Sadiq
d540688f8e refactor: Ran pyupgrade on openedx/core/djangoapps/user_authn 2021-04-07 18:54:33 +05:00
Jawayria
6ad42655b4 Refactor: Removed unused imports
Removed unused imports from openedx/core/djangoapps/{theming, user_authn, xblock}
2021-04-06 17:15:39 +05:00
Robert Raposa
96be45f1bd Merge pull request #27222 from edx/robrap/ARCHBOM-1721-toggle-doc-cleanup
ARCHBOM-1721: docs: update toggle docs
2021-04-05 10:47:55 -04:00
Feanil Patel
ba4d98898e Merge pull request #27231 from edx/feanil/more_safe_sessions_updates
fix: Reduce safe-sessions false alarms.
2021-04-02 14:45:22 -04:00
Feanil Patel
c45ffd7509 test: Test login redirects prefer session cookies.
Add a test to ensure that the login page redirect as long as we have a
valid session even if we have expired on non-existent JWT cookies.
2021-04-02 14:19:10 -04:00
Feanil Patel
118f095110 fix: Assume logged in if user has a valid session.
Previously they also had to have a valid JWT cookie which led to a weird
corner case where a user was logged in but still showed the login form
resulting in some confusion and odd behavior.

This change gives precedence to the session token to determine whether
or not someone is logged into the LMS but ensures that if you go through
the login flow, you refresh your JWT cookies. This should not cause any
breakage for MFE flows that might redirect to the LMS login page since
the JWT would get refreshed if it's out of date but the session is
valid.
2021-04-02 14:19:10 -04:00
Robert Raposa
8ef8b35a54 docs: update toggle docs
A variety of updates were made to improve the toggle documentation:
* Added comments to help ensure that the waffle(), waffle_switches(),
  waffle_flags() anti-pattern won't be contagious (copied).
* Some minor toggle_description updates.
* Removed empty toggle_target_removal_date annotations for
  non-temporary toggles.
* Removed empty optional toggle_warnings annotations.
* Removed empty optional toggle_tickets annotations.
* Removed deprecated toggle_category, toggle_status,
  and toggle_expiration_date annotations.
* Fixed some indents, use cases, and implementations.

ARCHBOM-1721
2021-04-01 21:58:29 -04:00
adeelehsan
c329de3235 skip hinted login field added in tpa context 2021-04-01 01:16:54 +05:00
Waheed Ahmed
b200699fc6 Keep user on FE if there is a running pipeline for SAML IDPs.
For some SAML providers, learners are redirected to MFE and breaking
the flow. Check for running pipeline and if the provider is a SAML
provider keep them on FE.

VAN-425
2021-03-25 18:43:19 +05:00
Zainab Amir
8cc5f13daf Add rate limit to registration endpoint (#27060)
Currently the registration endpoint has no rate limit. Added a new ratelimit
variable to support the change, it's value is set to 60/7d.

VAN-302
2021-03-25 16:28:30 +05:00
Waheed Ahmed
e3406257fe Fix edxloggedin cookie not present issue.
If edxloggedin cookie is not present but the user is authenticated;
user is redirected to authn MFE and then back to dashboard instead
of the desired redirect URL (e.g. finish_auth) resulting in learners
not enrolling into the courses.

VAN-415
2021-03-24 16:26:31 +05:00
Waheed Ahmed
4af767e0fb Fix finish auth url for MFE
Currently extra query params are not being handled in get TPAContextView,
Fixed using already available get_next_url_for_login_page().

VAN-415
2021-03-18 19:19:14 +05:00
Zainab Amir
3cdbb5b36a Track total time it takes users to register (#27020)
Added a new property in edx.bi.user.account.registered event to
track total time it took the user to register.

VAN-413
2021-03-18 13:02:12 +05:00
Stu Young
5107aa41e9 DENG-803: add traits to segment context for enrollment activated events (#26842)
add traits to segment context for enrollment activated events
2021-03-16 14:28:22 -04:00
Michael Terry
c697acec2b Merge pull request #26927 from edx/mikix/ace-braze
feat: update to edx-ace 1.0.0
2021-03-12 11:05:30 -05:00
Michael Terry
570a869bd3 feat: update to edx-ace 1.0.0
The new version switches how you specify recipients, to use
lms_user_id instead of usernames.

AA-489
2021-03-12 10:25:54 -05:00
Adeel Khan
725cd3f083 Fix button/title text for;
1) Account activation email.
2) Password reset email.
3) Password reset success.

VAN-272
2021-03-10 00:47:49 +05:00
Zainab Amir
a39befb548 VAN-113: Add error code for registration workflow (#26821) 2021-03-08 18:09:26 +05:00
Adeel Khan
231dd68f90 Make button style primary
VAN-274
2021-03-04 07:50:09 +05:00