Commit Graph

38 Commits

Author SHA1 Message Date
Jeremy Bowman
d44e6297ae PLAT-1847 Fix cms tests under Django 1.9 2017-12-13 15:29:02 -05:00
Tyler Hallada
95bb6e3db0 Use pytest-style asserts in test_signals.py 2017-12-07 13:43:49 -05:00
Tyler Hallada
6e791c58ea Fix hold back error
Also add try/except that prevents enroll failure caused by Schedule creation
exception in the future.

Address PR comments

Split one-line docstrings on their own line

Add period to the end of docstring summaries

Use kwargs.get to be more defensive

Disable pylint unused-argument about sender param
2017-12-07 13:43:47 -05:00
Nimisha Asthagiri
8acf3434c0 Revert "Merge pull request #16728 from edx/pacing/remove-create-schedules-from-course-waffle-flag"
This reverts commit 8b652ad352, reversing
changes made to b212af2488.
2017-12-06 11:58:39 -05:00
Nimisha Asthagiri
c6ee8eb68d Move ACE Common code out of Schedules 2017-12-05 11:36:14 -05:00
Alessandro Roux
8b652ad352 Merge pull request #16728 from edx/pacing/remove-create-schedules-from-course-waffle-flag
Dynamic Pacing: Removed references to CREATE_SCHEDULE_WAFFLE_FLAG.
2017-12-04 16:11:27 -05:00
sandroroux
4dbb935ca7 Removed references to CREATE_SCHEDULE_WAFFLE_FLAG. 2017-12-04 14:10:29 -05:00
Tyler Hallada
3425502a23 Schedules: change logging from DEBUG to INFO/EXCEPTION 2017-12-03 22:34:33 -05:00
sandroroux
13edb0b03e Updated course_has_highlights and get_week_highlights. Methods ensure that a course has highlights_enabled_for_messaging
Responded to Nimisha's review feedback.
2017-11-27 17:23:29 -05:00
Gabe Mulley
1f3085b2bc rename test methods 2017-11-17 14:05:15 -05:00
Gabe Mulley
26303580a5 update schedule start when course start date changes 2017-11-17 13:28:31 -05:00
Gabe Mulley
46c7327211 make image_url a function instead of a property 2017-11-15 12:37:13 -05:00
Gabe Mulley
6f20cd5cf2 support a GA tracking pixel 2017-11-15 08:35:35 -05:00
Gabe Mulley
e5a0bcfc32 hold back some users from dynamic pacing features 2017-11-08 09:48:48 -05:00
Tyler Hallada
5332b6920f Merge pull request #16466 from edx/thallada/ret-fix-absolute-url
Schedules: absolute_url returns given URL if already absolute
2017-11-06 16:44:43 -05:00
Nimisha Asthagiri
98e647fa24 Schedule-based Highlights email update 2017-11-06 14:30:28 -05:00
Tyler Hallada
1f88d528bd Add unit tests for absolute_url 2017-11-06 13:17:52 -05:00
Nimisha Asthagiri
4f2fdde2d8 Course Week Highlights accessor 2017-11-03 13:33:46 -04:00
Gabe Mulley
7fd643faa4 Add tests for experience types, ensure courses have a verified mode 2017-11-01 16:51:10 -04:00
Tyler Hallada
57bf89c8e2 Create schedule experience on schedule creation 2017-11-01 16:51:00 -04:00
Gabe Mulley
95d1e5c25e use a left outer join for experience types 2017-11-01 16:50:28 -04:00
Nimisha Asthagiri
08d31e1a43 Schedules: Tests for Course Update messages 2017-10-30 14:13:59 -04:00
Calen Pennington
07bb3ea564 Make the exclude orgs a bit more natural by returning a filtered query 2017-10-25 09:10:17 -04:00
Calen Pennington
fa7b9a132a Move the org_list and exclude code into the resolvers 2017-10-25 09:10:16 -04:00
Calen Pennington
f0fd40421b Use SiteConfigurationFactory a bit more idiomatically 2017-10-24 10:15:36 -04:00
Calen Pennington
5dd172b3d0 Use consistent beginning_of_day function 2017-10-24 10:15:36 -04:00
Calen Pennington
d222b2d718 Move bin-task enqueuing into a classmethod (rather than having it on the RecipientResolvers 2017-10-24 10:15:31 -04:00
Calen Pennington
bb050381a0 Move async_send_task binding to commands to allow tasks.py to import resolvers.py 2017-10-24 10:12:47 -04:00
Calen Pennington
4700656980 Move bin-count constants into resolvers.py nearer to the queries that use them 2017-10-24 10:12:46 -04:00
Tyler Hallada
9876f597e6 Refactor common task querying into a separate func
Address some of Cale's PR comments

Combine query functions into one. No debug logging

Pull int variables out into static class variables

Mixin needs to call super __init__ too

Remove multi-course copy from upgrade reminder

Address Cale's round 2 comments
2017-10-06 13:36:13 -04:00
Tyler Hallada
004ca4800e Add tests for upgrade_reminder
Fix test_templates

By passing the date pre-formatted to ace.

Address PR comments

Fix linting

Add TODO comment about using LoggerAdapter

More lint fixes

Fix upgrade_reminder task from silently failing
2017-10-06 13:35:00 -04:00
Nimisha Asthagiri
813007bb49 Schedules/ACE - support debug logging via waffle 2017-09-16 22:03:28 -04:00
Nimisha Asthagiri
65f8731a73 Update schedule start only if new course start date is in the future 2017-09-11 16:19:46 -04:00
Nimisha Asthagiri
5193649956 Update Schedules when start date changes on non-live courses 2017-09-10 08:41:26 -04:00
Gabe Mulley
9429128776 do not create schedules for instructor led courses 2017-09-06 15:25:10 -04:00
Gabe Mulley
6a36eb0183 Use ACE to 'send' Recurring Nudge emails 2017-08-31 16:58:08 -04:00
Clinton Blackburn
986afbfa38 Powering courseware deadline with schedules 2017-08-05 22:06:17 -04:00
Clinton Blackburn
1e7f7df79b Added CourseEnrollment.upgrade_deadline
This new property knows how to rely on schedule deadliens and fallback to course mode deadlines, when necessary.
2017-08-05 22:06:17 -04:00