Commit Graph

17975 Commits

Author SHA1 Message Date
Ned Batchelder
5fad9ccca4 Fix LMS-530, reflected XSS
Limit the page and chapter numbers to digits, to keep malicious URL
components from being inserted onto the page.
2013-07-02 13:29:59 -04:00
Giulio Gratta
3c461f7a94 reverts to browser default focus state and reenables the open_close_accordion feature 2013-07-02 09:26:43 -07:00
Giulio Gratta
1bb71a8621 increasing visibility of tab navigation on site by making focus state very obvious 2013-07-02 09:26:42 -07:00
Giulio Gratta
a5c9db0889 increased text contrast to make text more legible 2013-07-02 09:26:42 -07:00
Giulio Gratta
86a1e4263d added alt tags to course cover images and find course page logo 2013-07-02 09:26:41 -07:00
Giulio Gratta
93da389671 Removing selection styling from sass files
- removed ::selection css from reset.scss
- removed variables from variables.scss
- removed variable calls from course/base/base.scss and base/base.scss
2013-07-02 09:26:41 -07:00
Giulio Gratta
7452381f1c making sequence titles available to non-sighted users 2013-07-02 09:26:40 -07:00
Giulio Gratta
7af6409dc5 use jquery to focus on alert messages 2013-07-02 09:26:40 -07:00
Ned Batchelder
f6b0ffd01f Make some helpers for the tests. 2013-07-02 11:48:03 -04:00
Ned Batchelder
4ff2de69e7 Pylint fixes 2013-07-02 11:36:47 -04:00
Ned Batchelder
25d0f4d500 Remove unused URL /book-shifted/ 2013-07-02 11:36:47 -04:00
Ned Batchelder
6c3563cc1a Simple refactoring and reformatting of the view code. 2013-07-02 11:36:47 -04:00
Ned Batchelder
b5aebf0e02 Tests for staticbook 2013-07-02 11:36:47 -04:00
Ned Batchelder
c160b39bbd Provide names for the other courseware book URLs. 2013-07-02 11:36:46 -04:00
Adam Palay
c692428fe5 fix pylint violations 2013-07-02 10:22:26 -04:00
Ned Batchelder
4e4c209ae3 Fix LMS-530, reflected XSS
Limit the page and chapter numbers to digits, to keep malicious URL
components from being inserted onto the page.

Conflicts:
	lms/urls.py
2013-07-02 10:11:40 -04:00
Felix Sun
15317de252 Made explanation for hints field in crowdsource_hinter.py more clear.
Fixed various commenting things.

Removed an unused function in the crowdsourced module coffeescript.

Improved commenting in hint_manager.

Fixed pep and pylint violations.
2013-07-01 19:05:31 -04:00
Adam Palay
03aee3ed79 add tests 2013-07-01 18:21:47 -04:00
Felix Sun
728ccd4bca Fixed some docstring formatting things.
Expanded test coverage a little.
2013-07-01 18:03:36 -04:00
Felix Sun
801853f691 Fixed a small, but dangerous, string-to-integer casting bug in hint_manager.
Expanded tests of hint_manager.

Enabled the hint_manager by default in development environments.
2013-07-01 18:03:36 -04:00
Felix Sun
4071a57f68 Fixed broken tests. Made the hint manager enabled in testing environments - this lets us test the hint manager. 2013-07-01 18:03:36 -04:00
Felix Sun
bc2cab2fda Made the hint management instructor view off by default. 2013-07-01 18:03:36 -04:00
Felix Sun
696cc3a4db Fixed numerous code-formatting issues and pep8 violations.
Began enforcing one-vote-per-person.  This can be disabled with debug="True" in the <crowdsource_hinter> tag.

Started tests of the hint manager.
2013-07-01 18:03:36 -04:00
Felix Sun
4a406901b3 Moved the crowdsourced hinter module into mako template form.
Fixed some bugs in the tests for crowdsourced hinter.
2013-07-01 18:03:36 -04:00
Felix Sun
aba99084f2 Finished prototype of hint moderation view. Began re-writing tests of the crowdsource hinter module. (Old tests no longer cover all the code, now that moderation has been added.) 2013-07-01 18:03:35 -04:00
Felix Sun
0c0de20a2f Began work on instructor view to hinting system.
Added moderation feature - you can now choose to hold all hints for moderator approval before showing.
2013-07-01 18:03:35 -04:00
Jean Manuel Nater
5cb4c1a750 Removed some pep8 violations. 2013-07-01 17:07:24 -04:00
Calen Pennington
1a7b833146 Merge pull request #269 from edx/dhm/incidental-functionality-improvements
Incidental functionality improvements from Next Gen Modulestore work
2013-07-01 13:04:20 -07:00
Jean Manuel Nater
72b4561e3a Moved xml_store_config, mongo_store_config, and draft_mongo_store_config to xmodule/modulestore/tests/django_util.py
Removed some repeated instances of xml_store_config.
Reverted some changes to mongo_store_config so each modulestore gets it's own uuid.
2013-07-01 14:45:53 -04:00
Don Mitchell
ddfbe59814 Make DraftModuleStore mongo only
DraftModuleStore was originally designed as a mixin, but never used that
way, and with the upcoming changes to use the versioned module store,
never will be. This changes removes a circular dependency between
mongo.py and draft.py.
2013-07-01 12:33:08 -04:00
Felix Sun
0c4d6ba6d9 Made explanation for hints field in crowdsource_hinter.py more clear.
Fixed various commenting things.

Removed an unused function in the crowdsourced module coffeescript.

Improved commenting in hint_manager.

Fixed pep and pylint violations.
2013-07-01 11:52:52 -04:00
Felix Sun
970a7f0916 Fixed some docstring formatting things.
Expanded test coverage a little.
2013-07-01 10:25:04 -04:00
Felix Sun
b6760cebca Fixed a small, but dangerous, string-to-integer casting bug in hint_manager.
Expanded tests of hint_manager.

Enabled the hint_manager by default in development environments.
2013-07-01 10:25:04 -04:00
Felix Sun
6890563d43 Fixed broken tests. Made the hint manager enabled in testing environments - this lets us test the hint manager. 2013-07-01 10:25:04 -04:00
Felix Sun
f219228e4a Made the hint management instructor view off by default. 2013-07-01 10:25:04 -04:00
Felix Sun
ab303e7567 Fixed numerous code-formatting issues and pep8 violations.
Began enforcing one-vote-per-person.  This can be disabled with debug="True" in the <crowdsource_hinter> tag.

Started tests of the hint manager.
2013-07-01 10:25:04 -04:00
Felix Sun
bb922ed8d8 Moved the crowdsourced hinter module into mako template form.
Fixed some bugs in the tests for crowdsourced hinter.
2013-07-01 10:25:04 -04:00
Felix Sun
b64fe5c537 Finished prototype of hint moderation view. Began re-writing tests of the crowdsource hinter module. (Old tests no longer cover all the code, now that moderation has been added.) 2013-07-01 10:25:03 -04:00
Felix Sun
100f6bf11e Began work on instructor view to hinting system.
Added moderation feature - you can now choose to hold all hints for moderator approval before showing.
2013-07-01 10:25:03 -04:00
Sarina Canelake
e5f97b372b pep8 fixes 2013-06-28 18:00:41 -04:00
Jay Zoldak
b1424a75b8 Add a test for 404 raised when requesting the profile page of a user that does not exist 2013-06-28 16:51:24 -04:00
Sarina Canelake
09501a62e2 Handle exception with a 404 2013-06-28 16:14:56 -04:00
Vik Paruchuri
b38a36d44a Fix test 2013-06-28 14:38:13 -04:00
Renzo Lucioni
4a41ce804f Merge pull request #293 from edx/renzo/fix-idashboard-event-types
Standardize types used for logging events from the instructor dashboard
2013-06-28 09:07:45 -07:00
Renzo Lucioni
d53114abda Shorten line length 2013-06-28 11:46:20 -04:00
Ned Batchelder
ff60034849 Merge pull request #273 from edx/ned/remove-obsolete-and-distracting-scss-file
Remove obsolete and distracting SCSS file
2013-06-28 08:40:56 -07:00
Valera Rozuvan
97d7421432 Fix for bug Blades/BLD-152. Added test for bugfix. Optimized bug fix. 2013-06-28 13:52:04 +03:00
Carlos Andrés Rocha
a844548fb8 Add setting to set the virtual host of a Celery broker 2013-06-27 17:58:51 -04:00
jnater
7d0b72a41e Merge pull request #204 from edx/jnater/courseware_tests
Jnater/courseware tests
2013-06-27 13:50:51 -07:00
Jean Manuel Nater
3e0f933a73 Formatted a docstring. 2013-06-27 16:40:04 -04:00