Commit Graph

13683 Commits

Author SHA1 Message Date
Edward Zarecor
2f44415eba Merge pull request #32099 from open-craft/navin/fix-video-transcripts 2023-05-18 14:29:34 -04:00
nsprenkle
1839bc01c6 feat: update text for sharing to Twitter
Updated logic to include organization info, when available. Also
refactored away some no-longer-relevant code and pulled Twitter handle
from config.

style: add missing newline

fix: fix outdated signature in test

refactor: make organization optional arg

Required to fix some tests

style: fix pylint issues

chore: organization is a dict change the accessor + linting
2023-05-18 13:51:51 -04:00
Leangseu Kim
f72d27c6af chore: remove studio check
chore: remove duplicate code

chore: update get_public_video_url because reverse doesn't work on cms
2023-05-18 13:08:01 -04:00
Leangseu Kim
ee3a854d14 chore: update og:url for video sharing 2023-05-18 10:41:30 -04:00
Syed Ali Abbas Zaidi
d7053a6783 fix: eslint autofixable issues (#32181)
* fix: eslint operator-linebreak issue

* fix: eslint quotes issue

* fix: react jsx indent and props issues

* fix: eslint trailing spaces issues

* fix: eslint line around directives issue

* fix: eslint semi rule

* fix: eslint newline per chain rule

* fix: eslint space infix ops rule

* fix: eslint space-in-parens issue

* fix: eslint space before function paren issue

* fix: eslint space before blocks issue

* fix: eslint arrow body style issue

* fix: eslint dot-location issue

* fix: eslint quotes issue

* fix: eslint quote props issue

* fix: eslint operator assignment issue

* fix: eslint new line after import issue

* fix: indent issues

* fix: operator assignment issue

* fix: all autofixable eslint issues

* fix: all react related fixable issues

* fix: autofixable eslint issues

* chore: remove all template literals

* fix: remaining autofixable issues

* fix: failing js test
2023-05-18 11:03:59 +05:00
Muhammad Adeel Tajamul
d8db64cf2a feat: hide discussion tab when disabled (#32195) 2023-05-16 05:17:06 +05:00
Navin Karkera
a06c9b17be fix: update transcripts field in video on upload 2023-05-12 18:36:59 +05:30
bszabo
dc4a54060c Bszabo/tnl 10683 birth year (#32200)
* fix: TNL-10683 birthyear protected 


No unit tests yet

* fix: TNL-10683 add unit tests

* fix: TNL-10683 fix lint errors

* fix: TNL-10683 add required docstrings

* fix: TNL-10683 hide year-of-birth feature name

---------

Co-authored-by: Bernard Szabo <bszabo@edx.org>
2023-05-09 12:36:22 -04:00
Syed Ali Abbas Zaidi
adf879e8b2 Revert "fix: all auto fixable eslint issues (#31900)" (#32203)
This reverts commit 228180b1ef.
2023-05-09 13:53:54 +05:00
Syed Ali Abbas Zaidi
228180b1ef fix: all auto fixable eslint issues (#31900)
* fix: eslint operator-linebreak issue

* fix: eslint quotes issue

* fix: react jsx indent and props issues

* fix: eslint trailing spaces issues

* fix: eslint line around directives issue

* fix: eslint prefer template issue

* fix: eslint semi rule

* fix: eslint newline per chain rule

* fix: eslint space infix ops rule

* fix: eslint space-in-parens issue

* fix: eslint space before function paren issue

* fix: eslint space before blocks issue

* fix: eslint arrow body style issue

* fix: eslint dot-location issue

* fix: eslint quotes issue

* fix: eslint quote props issue

* fix: eslint operator assignment issue

* fix: eslint new line after import issue

* fix: indent issues

* fix: operator assignment issue
2023-05-09 11:57:15 +05:00
Piotr Surowiec
9d9bd63926 Merge pull request #32177 from open-craft/braden/fix-warnings
Fix some warnings from usage of deprecated properties
2023-05-08 16:04:28 +02:00
Agrendalath
2af5ddbf8a fix: support files with a unicode signature in the Instructor Dashboard API
Without this, files with BOM (byte order mark; generated e.g., by Microsoft
Excel) cannot be read properly.
2023-05-04 17:20:18 +02:00
jansenk
4de07c25d0 refactor: video sharing js
test: add testing for VideoSocialSharingHandler

test: fix context tests

refactor: move most link logic to django

chore: update python test

chore: update linting
2023-05-04 09:33:16 -04:00
Braden MacDonald
11a46bde54 chore: properly mark usage of deprecated accessors in test_block_render
lms/djangoapps/courseware/tests/test_block_render.py:

DeprecationWarning: runtime.seed is deprecated. Please use the user service `user_id` instead.
DeprecationWarning: runtime.user_id is deprecated. Use block.scope_ids.user_id or the user service instead.
DeprecationWarning: runtime.user_is_staff is deprecated. Please use the user service instead.
DeprecationWarning: runtime.get_user_role is deprecated. Please use the user service instead.
...
2023-05-03 12:42:43 -07:00
Nathan Sprenkle
745cda1580 feat: course overrides of video sharing settings (#32169)
* refactor: public sharing enabled toggle

Cherry-picked from https://github.com/openedx/edx-platform/pull/32150

* feat: course video share setting on video block

Adds awareness of course.video_sharing_options setting to video XBlock.
This can override whether or not sharing is enabled for a video or fall
back to per-video settings

* test: course video share setting on video block

Adds awareness of course.video_sharing_options setting to video XBlock.
This can override whether or not sharing is enabled for a video or fall
back to per-video settings

* test: course video share setting on preview page

Extends checking for course override of video share settings to public
video preview page.
2023-05-03 13:23:34 -04:00
Syed Ali Abbas Zaidi
f1fb38ed83 fix: multi lines and spaces issues (#31885)
* fix: multi lines and spaces issues

* fix: eslint operator-linebreak issue

* fix: eslint quotes issue

* fix: remaining quotes issues

* fix: eslint object curly newline issue

* fix: eslint object curly spacing issue

* fix: eslint brace-style issues

* fix: react jsx indent and props issues

* fix: eslint trailing spaces issues

* fix: eslint linbreak style issue

* fix: eslint space unary operator issue

* fix: eslint line around directives issue

* fix: void and typeof space unary ops issue
2023-05-03 12:22:46 +05:00
Agrendalath
aa85257b19 fix: use student-specific anonymous IDs in CAPA and HTML XBlocks
After changes from #31472, the user service of a "leaf" XBlock gets overridden
with the one created for its parent (SequenceBlock). Therefore, the
`requires_per_student_anonymous_id` is ignored in these XBlocks. The
subsequent renders of an XBlock (e.g., when requesting the solution) use
the student-specific IDs.

This removes choosing the proper ID (course-specific or student-specific) from
the runtime initialization. Instead, both IDs are passed to the user service.

There are only two XBlocks that relied on the
`requires_per_student_anonymous_id` - `ProblemBlock` and `HtmlBlock`. They
now request the "deprecated" (student-specific) user ID directly from the user
service.
2023-05-02 17:58:22 +02:00
Mubbshar Anwar
73e32b5156 Revert "Revert "refactor: recommendations code refactoring (#31990)" (#32047)" (#32135)
This reverts commit 3b991e6620.
2023-05-02 11:08:43 +05:00
Adam Stankiewicz
1e8acf49fd fix: include isLearnerPortalEnabled as part of EnterpriseDashboardSerializer (#32142)
* fix: include isLearnerPortalEnabled as part of EnterpriseDashboardSerializer

* chore: test serializer changes

---------

Co-authored-by: Hamzah Ullah <hamzahullah@yahoo.com>
2023-04-28 11:29:37 -04:00
Jody Bailey
e3cb59ca2e fix: adjusted cross product recommendations course filtering and response (#32119)
* fix: adjusted cross product recommendations course filtering and response

* chore: added method descriptions

* test: adjusted mock course data

* chore: removed logs

* chore: removed extra empty line

* fix: removed redundant active course run logic, added active course run filtering
2023-04-28 09:35:03 +02:00
Muhammad Adeel Tajamul
f30277ffc5 fix: label is showing staff for learner when global staff (#32144) 2023-04-27 16:11:01 +05:00
Pooja Kulkarni
1950949c9e refactor: rename descriptor -> block within remaining xmodule
Co-authored-by: Agrendalath <piotr@surowiec.it>
2023-04-26 17:10:54 +02:00
Pooja Kulkarni
702e14a28a refactor: rename descriptor -> block within remaining lms
Co-authored-by: Agrendalath <piotr@surowiec.it>
2023-04-26 17:10:54 +02:00
Pooja Kulkarni
c452fb3204 refactor: rename descriptor -> block within lms/djangoapps/mobile_api
Co-authored-by: Agrendalath <piotr@surowiec.it>
2023-04-26 17:10:54 +02:00
Pooja Kulkarni
4276e7daf3 refactor: rename descriptor -> block within lms/djangoapps/lti_provider
Co-authored-by: Agrendalath <piotr@surowiec.it>
2023-04-26 17:10:54 +02:00
Pooja Kulkarni
5cc6acae18 refactor: rename descriptor -> block within lms/djangoapps/instructor_task
Co-authored-by: Agrendalath <piotr@surowiec.it>
2023-04-26 17:10:54 +02:00
Pooja Kulkarni
5447a211de refactor: rename descriptor -> block within lms/djangoapps/edxnotes
Co-authored-by: Agrendalath <piotr@surowiec.it>
2023-04-26 17:10:53 +02:00
Pooja Kulkarni
a0d23b20f5 refactor: rename descriptor -> block within lms/djangoapps/course_api
Co-authored-by: Agrendalath <piotr@surowiec.it>
2023-04-26 17:10:53 +02:00
Pooja Kulkarni
c80fba689a refactor: rename descriptor -> block within lms/djangoapps/courseware
Co-authored-by: Agrendalath <piotr@surowiec.it>
2023-04-26 17:10:53 +02:00
Pooja Kulkarni
79f67b9ce3 refactor: rename descriptor -> block within lms/djangoapps/certificates
Co-authored-by: Agrendalath <piotr@surowiec.it>
2023-04-26 17:10:53 +02:00
Jeremy Ristau
472a3b5442 Merge pull request #31472 from open-craft/kaustav/unify_modulesystem_descriptorsystem
feat: unify ModuleSystem and DescriptorSystem [BD-13]
2023-04-24 10:03:19 -04:00
Jansen Kantor
9c769dd311 feat: gradebook api real name for masters students (#32104) 2023-04-21 13:57:59 -04:00
Agrendalath
522c48c137 refactor: do not rely on LmsModuleSystem in Video XBlock
It was introduced in 159b707. We are removing this class.
This also adds a missing test case.
2023-04-21 11:53:49 +02:00
Kaustav Banerjee
c5439221cb chore: address review comments 2023-04-21 11:53:49 +02:00
Kaustav Banerjee
d0fa2d65e3 test: fix test cases and lint issues 2023-04-21 11:53:49 +02:00
Kaustav Banerjee
20ed3d64ec feat: add _runtime_services attribute to DescriptorSystem 2023-04-21 11:53:49 +02:00
Kaustav Banerjee
7d8f54fa88 chore: cleanup LmsModuleSystem and PreviewModuleSystem 2023-04-21 11:53:49 +02:00
Kaustav Banerjee
09e1197053 feat: remove CombinedSystem 2023-04-21 11:53:49 +02:00
Kaustav Banerjee
18fea868a9 feat: remove usage of LmsModuleSystem and PreviewModuleSystem 2023-04-21 11:53:48 +02:00
Kaustav Banerjee
017f8469de feat: merge ModuleSystem with DescriptorSystem 2023-04-21 11:53:48 +02:00
Braden MacDonald
626f11f608 test: Import linter: optionally enforce usage of a package's public API (#31903)
* test: warn about dependencies from cms->openedx->lms and vice versa

* test: warn about importing from package's internal implementation code

* chore: Update some imports to use public APIs only

* chore: Update 'bookmarks' app to have stricter public API

* fix: we are sharing 'adapters' from olx_rest_api to content_staging
2023-04-20 11:34:51 -07:00
Justin Hynes
72d8d830c9 Merge pull request #32071 from openedx/jhynes/APER-2344
feat: publish CERTIFICATE_CREATED events to the event bus
2023-04-20 13:11:27 -04:00
Justin Hynes
2e68ca2377 feat: publish CERTIFICATE_CREATED events to the event bus
[APER-2344]

We would like to start consuming Certificate related events in Credentials from the event bus. This PR starts the process by publishing CERTIFICATE_CREATED events to the event bus. It also introduces a new feature flag (`SEND_CERTIFICATE_CREATED_SIGNAL`) to gate the functionality.
2023-04-19 19:53:35 +00:00
Muhammad Adeel Tajamul
2f036e2df6 feat: added edit_by_label and closed_by_label in threads response (#32070) 2023-04-19 19:55:10 +05:00
Mohammad Ahtasham ul Hassan
2a7b400770 fix: fix buy_subscription_url to use get method (#32079)
* fix: fix buy_subscription_url to use get method
2023-04-18 15:31:32 +05:00
Mohammad Ahtasham ul Hassan
e973266b2f feat: fetch program subscription details (#32023)
* feat: fetch program subscription details
2023-04-14 16:33:12 +05:00
Ali Nawaz
9c06ef5c17 chore: log the user triggering the retirement flow
chore: change user retirement permissions to allow support staff
2023-04-13 02:29:39 +05:00
Mubbshar Anwar
3b991e6620 Revert "refactor: recommendations code refactoring (#31990)" (#32047)
This reverts commit 20b1e65c21.
2023-04-11 11:17:29 +05:00
Mubbshar Anwar
20b1e65c21 refactor: recommendations code refactoring (#31990)
After moving the recommendations code from learner_home to learner_recommendations we need to remove the legacy code.
Point the learner dashboard recommendations API from legacy to new endpoint.

VAN-1310
2023-04-10 15:31:37 +05:00
Sathis
714b6cb109 fix: Allow download url in video component when MP4/WEBM format is available
When creating a new video component in Studio and specifying an HLS URL and MP4 URL along with setting Video Download Allowed equal to True the download link for MP4 has to be shown.

Fixes: https://github.com/openedx/edx-platform/issues/31300
2023-04-07 10:47:38 -05:00