Peter Fogg
3d4f9268da
Make sure that changing grading cutoffs triggers a save confirmation, and reliable reverting of changes.
2013-07-11 09:11:59 -04:00
Peter Fogg
eba1bd0972
Refactor and update acceptance tests around saving settings.
2013-07-11 09:11:59 -04:00
Peter Fogg
9094f1890b
Change course settings to require explicit save.
...
Rather than asynchronously saving when a setting is updated, we now
prompt the user to confirm their changes and only persist the data if
they hit the save button. Lettuce tests are updated to expect this
behavior and some new ones are added.
2013-07-11 09:11:07 -04:00
Peter Fogg
164a469e9d
Factor showNotificationBar out into ValidatingView.
...
When all settings require an explicit save, this functionality will be
shared between each view (with slight changes, e.g. click handlers.)
2013-07-11 09:11:07 -04:00
Jonah Stanley
786f422ffa
Merge pull request #298 from edx/jonahstanley/acceptance-tests-unique-database
...
Jonahstanley/acceptance tests unique database
2013-07-10 14:09:28 -07:00
JonahStanley
a0900f09cc
Commented why Acceptance_static is needed
2013-07-10 16:23:26 -04:00
JonahStanley
4685cacc7b
Databases are now cleaned properly
...
Acceptance_static is used to prevent collect static from using a seed
test.py had its seed removed due to redundancy
2013-07-10 15:28:23 -04:00
David Baumgold
cb62797306
Merge pull request #347 from edx/update-sass
...
Update SASS and Bourbon, add Neat
2013-07-10 11:09:11 -07:00
David Baumgold
18474986f3
Removed deprecated mixins from _textbooks.scss
2013-07-10 13:00:07 -04:00
Adam Palay
d056c8a8f2
replace test setting changes with test-specific mock.patch.dicts
2013-07-10 10:18:58 -04:00
Frances Botsford
a0962cc3b9
updated sass transitions to use newer bourbon syntax
2013-07-10 09:18:00 -04:00
Brian Talbot
a09866a48f
Studio: refining timing variable comment in Sass
2013-07-10 09:18:00 -04:00
Brian Talbot
c10fc54509
Studio: abstracts and formalizes set animation/transition Sass variables
2013-07-10 09:17:59 -04:00
Brian Talbot
d046fdf743
resolves local Sass warnings/errors around missing mixins referenced in xmodule styling
2013-07-10 09:17:59 -04:00
Brian Talbot
b97c1bf5e3
Studio: corrects Sass @extend references
2013-07-10 09:17:59 -04:00
Brian Talbot
41d9fa3785
Studio: syncs up syntax, ordering, and timing for all Sass transition mixins
2013-07-10 09:17:59 -04:00
Brian Talbot
ed93fcb89a
Studio: adds back in transform-origin prop to dropdown nav icons
2013-07-10 09:17:59 -04:00
Brian Talbot
ee481dfdb5
Studio: resolves notification animation placement error
2013-07-10 09:17:59 -04:00
Brian Talbot
f708c42ec6
Studio: revises anim syntax, adds utility anims, and revises rotate transitions for nav
2013-07-10 09:17:59 -04:00
Brian Talbot
4a0a067327
Studio: revises syntax of calling preset animations for notifications
2013-07-10 09:17:59 -04:00
Brian Talbot
b42074716b
Studio: updates keyframes/animations syntax for all animations
2013-07-10 09:17:58 -04:00
David Baumgold
5bd79a8669
Changed @include box-shadow() to box-shadow
...
Bourbon's box-shadow mixin has been deprecated, and they recommend to use the
official spec.
2013-07-10 09:17:58 -04:00
David Baumgold
41374838cb
Changed @include border-radius() to border-radius
...
The official border-radius mixins were deprecated and removed in Bourbon 3.0.
https://github.com/thoughtbot/bourbon/pull/95
2013-07-10 09:17:58 -04:00
Brian Talbot
cef33bf285
Studio: updates shame file with related future maintenance work
2013-07-09 19:16:44 -04:00
Frances Botsford
6814163a45
cleanup and tweaks from feeback to PDF Textbooks FED and Sass
2013-07-09 19:16:44 -04:00
Brian Talbot
b9e7e992b5
Studio: revises subtitle of Textbooks view to be consistent with others
2013-07-09 19:16:44 -04:00
David Baumgold
17bef565f1
Added another test
2013-07-09 19:16:44 -04:00
David Baumgold
4155f9fe8c
Removed unused user_author_string function
2013-07-09 19:16:44 -04:00
David Baumgold
437e658f98
pylint fixes
2013-07-09 19:16:44 -04:00
David Baumgold
1a0d6d21bb
Forgot to call show() on saving notification
2013-07-09 19:16:43 -04:00
David Baumgold
8d809dbad6
Remove commented-out code
2013-07-09 19:16:43 -04:00
David Baumgold
32a902ca57
Remove create_json_response in favor of JsonResponse class
2013-07-09 19:16:43 -04:00
David Baumgold
628dff5398
pylint fixing
2013-07-09 19:16:43 -04:00
David Baumgold
c68895ca5d
world.css_click no longer returns a boolean
2013-07-09 19:16:43 -04:00
David Baumgold
cfa094e424
Validation tests for Backbone models
2013-07-09 19:16:43 -04:00
David Baumgold
eba5928009
Added a comment
2013-07-09 19:16:43 -04:00
David Baumgold
fe8587566f
All textbook chapters must have name and asset_path
...
Previously, for a textbook with only one chapter, we allowed that chapter to
not have a title -- under the assumption that it would be shown as a monolithic
textbook, instead of a chaptered textbook. However, the UI doesn't support that
idea, the code was getting a bit messy, and there was no real benefit to the idea
of not having to specify a chapter title. This commit removes that special case,
and ensures that all textbook chapters must have a name and an asset path.
2013-07-09 19:16:43 -04:00
David Baumgold
f9a10855d9
Add notes about JS validation functions returning non-i18n error messages
2013-07-09 19:16:42 -04:00
David Baumgold
fa62f48e57
Fix Jasmine test failures
2013-07-09 19:16:11 -04:00
David Baumgold
e7088d50fd
Display error message when trying to upload a non-PDF file as a PDF textbook
2013-07-09 19:16:11 -04:00
David Baumgold
7506562f50
Another lettuce test, and fixes to make it work
2013-07-09 19:16:11 -04:00
David Baumgold
ca2339f15e
Remove unneeded arguments
...
They are the defaults now
2013-07-09 19:16:10 -04:00
David Baumgold
ee61b15345
Added a few more tests, to increase diff coverage
2013-07-09 19:16:10 -04:00
David Baumgold
c5c1fd08ae
i18n
2013-07-09 19:16:10 -04:00
David Baumgold
e1ed5c3d2d
docstrings
2013-07-09 19:16:10 -04:00
David Baumgold
b97f5585b9
Re-added a missing import
2013-07-09 19:16:10 -04:00
David Baumgold
0b8aec718f
Add another pdf textbook test
2013-07-09 19:16:10 -04:00
David Baumgold
bacb904ce3
Skip failing unit test
2013-07-09 19:16:10 -04:00
David Baumgold
a90590a442
Remove unused imports/constants
2013-07-09 19:16:10 -04:00
Frances Botsford
b41d23747a
PDF Textbooks: implemented "View Live" link
2013-07-09 19:16:09 -04:00
