Commit Graph

29 Commits

Author SHA1 Message Date
Usama Sadiq
a597f1c783 refactor: ran pyupgrade second iteration (#27463) 2021-05-11 15:19:48 +05:00
M. Zulqarnain
2c44315ce0 refactor: pyupgrade on pavelib & scripts (#26769) 2021-03-12 14:14:53 +05:00
Tim McCormack
edeabc3faf Add --summary-format=json option to XSS linter (#25851)
This will simplify updating of the linter thresholds file after XSS linter
violations are addressed.
2020-12-11 12:34:04 +00:00
Samuel Walladge
71fcf6e725 Fix issues with xss linters
Improve accuracy of javascript-escape linter: Previously this would
match on FOOescape() and FOO.escape calls, but neither are the global
escape function we are worried about.

The regex probably isn't 100% accurate; there may be still false
positives (javascript allows a large range of characters in identifiers,
some of which may not be covered by [\w.$]). The main thing is to avoid
false negatives here though - this will definitely catch any use of
`escape()` or `window.escape()`.

Also remove javascript-interpolate lint - this was deemed unecessary.
StringUtils.interpolate is not in fact safe (it does no html escaping),
so the results of this lint are misleading.
2020-05-04 09:27:18 +09:30
Feanil Patel
9cf2f9f298 Run 2to3 -f future . -w
This will remove imports from __future__ that are no longer needed.

https://docs.python.org/3.5/library/2to3.html#2to3fixer-future
2019-12-30 10:35:30 -05:00
asadazam93
7a43721f81 Upgrade python 3 decode error 2019-10-04 16:17:11 +05:00
aarif
66942bc74c python 3 fixes
python 3 fixes

python 3 fixes
2019-09-26 14:19:18 +05:00
Awais Qureshi
8fcb74efa4 BOM-594
Python3 fix.
2019-09-22 04:25:31 +05:00
Awais Qureshi
0dcee53c1c BOM-594
Python3 fix.
2019-09-21 23:42:54 +05:00
Adeel Khan
37c6b60fc8 Adds Django template linter.
This adds Django template linter that
would check for all trans/blocktrans
tag expressions for escaping.

PROD-465
2019-07-25 18:54:03 +05:00
Aarif
a806a7f046 Merge pull request #21042 from edx/INCR-387
INCR-387 Python 3 compatibility
2019-07-18 13:14:10 +05:00
Ayub khan
07f907ec56 INCR-388 python3 compatibility 2019-07-15 13:15:11 +05:00
aarif
0bf108ea8a ran python-modernize and isort on files mentioned in INCR-387 2019-07-10 15:47:38 +05:00
cclauss
bb31716c97 Use ==/!= to compare str, bytes, and int literals 2019-03-19 21:40:06 +01:00
Matt Hughes
2f9819f247 Improve XSS lint for underscore templates
See also
https://edx.readthedocs.io/projects/edx-developer-guide/en/latest/conventions/preventing_xss.html#javascript-edx-namespace

The failure totals in test_main appear to've been wrong previously;
I'm just updating them to run clean via `pytest scripts/xsslint/tests`
2019-02-07 13:54:52 -05:00
Ned Batchelder
2d438d8bb5 Fix 'W605 invalid escape sequence' errors from pycodestyle 2018-11-02 06:06:43 -04:00
Jeremy Bowman
713d64e1e2 TE-2702 Update Read the Docs links to HTTPS 2018-08-15 17:34:01 -04:00
Calen Pennington
07a15c681f Reapply the XBlock RequireJS -> Webpack changes
This reverts commit 105db2cf59, reversing
changes made to 447457594f.
2018-06-27 22:27:07 -04:00
Eric Fischer
e72549cdbe Revert "Merge pull request #18340 from cpennington/fix-studio-xblock-rendering"
This reverts commit 9a70ca78a5, reversing
changes made to efd5b9abbd.

Hopefully fixes EDUCATOR-3053
2018-06-15 13:18:27 -04:00
Calen Pennington
1491491d21 Don't treat self-closing tags as context starters 2018-06-13 10:00:13 -04:00
Calen Pennington
be3c7e05c5 Reapply "Switch container factory to webpack"
This reverts commit 18d93b00ba.
2018-06-07 15:52:05 -04:00
Calen Pennington
18d93b00ba Revert "Switch container factory to webpack" 2018-06-07 13:46:47 -04:00
Calen Pennington
0abe75a7c6 Re-apply the changes to convert XBlocks to Webpack
Reapplies edx/edx-platform#17509

This reverts commit 0f7e2373d0.
2018-06-06 12:52:12 -04:00
Calen Pennington
0f7e2373d0 Revert "Switch container factory to webpack" 2018-05-29 16:01:38 -04:00
Calen Pennington
ee6360543b Convert webpackified factories to es6 modules with global exports, and remove the invoke_page_factory pattern 2018-05-29 12:21:46 -04:00
Michael Terry
a34c8c8233 Drop remaining coffee use
This basically commits the transpiled CoffeeScript JS (with minor
cleanup) and removes coffee build support.

A tiny amount of support for xblocks exists, because external users
may have xblocks with coffee. But no coffee in our tree anyway.
2018-04-13 14:10:40 -04:00
Anthony Mangano
edc98939b5 Define XSS-linter rules on Linter classes. 2018-03-23 16:58:27 -04:00
Anthony Mangano
3e7df8688f Add config module for xsslint 2018-03-01 16:52:42 -05:00
Anthony Mangano
07ca440226 Refactor XSS linter into smaller files 2018-03-01 09:46:16 -05:00