Commit Graph

22684 Commits

Author SHA1 Message Date
uzairr
5103f59df9 upgrade login api
Modify the existing login api in a way that
it will allow the user to login via username as well.
currently it is only allowing email to log the user in.

VAN-445
2021-04-23 17:21:18 +05:00
Justin Hynes
35cfca0be1 Merge pull request #27357 from edx/jhynes/microba-1164_revoke-program-certs-bugfix
fix: fix bug with `revoke_program_certificates` task
2021-04-22 07:38:32 -04:00
Julia Eskew
efa13ff1d2 fix: TNL-8233: Change exception raised at problem creation failure from generic exception to LoncapaProblemError. (#27361)
Raising this specific exception will cause the failure to be handled more gracefully by problem rescoring code.
2021-04-21 16:13:23 -04:00
Justin Hynes
a7bc9d1cc1 fix: fix bug with revoke_program_certificates task
[MICROBA-1164]
* cast `course_key` as a string when scheduling the `revoke_program_certificates` task
* Update existing unit tests
* Move test utility method in test_tasks.py out from the middle of the test cases
* Fix spelling in test function name
2021-04-21 14:43:03 -04:00
Albert (AJ) St. Aubin
a21d0ff224 [bug] Updated confusing text about when a certificated is available
Currently when a certificate availability date is set the text on the
course dasboard is confusing to the learner and could lead them to the
wrong conclusions. The cert should not be available until on or after
the available date.
2021-04-21 12:43:53 -04:00
Usama Sadiq
ab41a7daee refactor: Apply lint-amnesty on pylint violations 2021-04-20 21:43:59 +05:00
Ali Akbar
9e8684cc72 Merge pull request #27367 from edx/aakbar/xss-disable-2
Refactor: disable xsslint for numerous files
2021-04-19 15:51:30 +05:00
Ali-D-Akbar
de87916768 refactor: disable xsslint: PROD-2310 2021-04-19 12:37:08 +05:00
Awais Jibran
9722e37492 Enable Course Olx Validation during Course Import (#27300)
* Enable import failure and email with Errors/Warnings

This PR enables course import failure in case of olx validation errors. Here is the flow.
  * Course Import tries to import foo.tar.gz into their course shell
  * Course olx contains validation errors
  * During course import, olx is validated and import is failed with the error message "Course olx validation failed. Please check your email."
  * System generates an email with ERRORs & WARNINGs in the body of the email.

This PR also adds a waffle flag contentstore.bypass_olx_failure. The purpose of this test flag is to allow course teams to unblock by enabling them to bypass the
the olx-validation failure.
The workaround is shared on the ticket TNL8214.

* Disable olx validation out of the box.
2021-04-16 18:45:59 +05:00
Ali-D-Akbar
eb2c369750 refactor: disable xsslint: PROD-2311 2021-04-16 17:13:05 +05:00
Ali Akbar
baa83d77e3 Merge pull request #27337 from edx/aakbar/xss-disable
refactor: disable xss for numerous files
2021-04-15 20:11:39 +05:00
alangsto
a45bcd158b feat: Add tracking event for IDV photo mode (#27349)
As part of the ongoing A/B experiment for IDV, we would like to know how users submitted their photos (either by upload or camera) in addition to the other information we are tracking
2021-04-15 11:07:40 -04:00
Igor Degtiarov
70ab50181a fix: Hide enterprise/login button if enterprise integration disabled. (#27130)
* fix: Hide enterprise/login button if enterprise integration disabled.

[BTR-52](https://openedx.atlassian.net/browse/BTR-52)
Fix an issue with existing button for enterprise login on the login page
when enterprise integration is disabled.

* Address review comments
2021-04-15 11:54:56 +05:00
Ali-D-Akbar
eb1eb06bbd refactor: disable xss PROD-2312 2021-04-14 21:03:45 +05:00
stvn
6990befcee style: Cleanup whitespace 2021-04-14 07:38:55 -07:00
stvn
970980f25a style: Alphabetize some imports 2021-04-14 07:38:55 -07:00
stvn
a3a58533a8 docs: Add and cleanup comments 2021-04-14 07:38:55 -07:00
stvn
479471b406 style: Rename variables to mark as CONSTANT 2021-04-14 07:26:39 -07:00
stvn
301ccd31dc refactor: Remove unused test factory 2021-04-14 07:26:39 -07:00
stvn
1b3d915af7 refactor: Move RequestFactoryNoCsrf helper to common/ 2021-04-14 07:26:39 -07:00
stvn
f646971c74 refactor: Move OrgInstructorFactory helper to common/ 2021-04-14 07:26:39 -07:00
stvn
31bc741410 refactor: Move OrgStaffFactory helper to common/ 2021-04-14 07:26:39 -07:00
stvn
ffcfc05a61 refactor: Move BetaTesterFactory helper to common/ 2021-04-14 07:26:39 -07:00
stvn
22fb1ec124 refactor: Move InstructorFactory helper to common/ 2021-04-14 07:26:39 -07:00
stvn
8869a30bcd refactor: Move UserFactory helper to common/ 2021-04-14 07:26:39 -07:00
stvn
2fa36fb0cf refactor: Move StaffFactory helper to common/ 2021-04-14 07:26:39 -07:00
stvn
5dd8302d8b refactor: Move GlobalStaffFactory helper to common/ 2021-04-14 07:26:39 -07:00
stvn
7d33d0d1e9 Merge PR #27289 refactor/lms-to-core/get-course-by-id
* Commits:
  refactor: Import a single function, not the whole module
  refactor: Move get_course_by_id helper from LMS to core
2021-04-14 07:08:19 -07:00
Dillon Dumesnil
3a89ed4275 Merge pull request #27262 from edx/ddumesnil/switch-relative-dates-to-course-waffle-aa-677
refactor: AA-677: Switch relative dates to CourseWaffleFlag
2021-04-14 06:17:08 -07:00
Awais Qureshi
c7f643bfeb Merge pull request #26776 from edx/factory-boy
upgrade factory-boy
2021-04-14 17:33:10 +05:00
Ali-D-Akbar
f82955bb62 refactor: disable xss PROD-2313 2021-04-14 17:17:32 +05:00
Justin Hynes
d35dea576a Merge pull request #27321 from edx/jhynes/microba-1077_bulk-regen-update
feat: skip bulk certificate invalidation during bulk regeneration in v2 certs
2021-04-14 08:12:21 -04:00
Asad Iqbal
80298ae31e feat: add COURSES_INVITE_ONLY setting (#27252)
Setting COURSES_INVITE_ONLY to True overrides the INVITE_ONLY setting across all courses in a given deployment.

Co-authored-by: tasawernawaz <tasawer.nawaz@arbisoft.com>
Co-authored-by: asadiqbal08 <asad.iqbal@arbisoft.com>
2021-04-14 08:06:46 -04:00
Awais Qureshi
d26a076131 refactor: upgrading factory-boy. 2021-04-14 16:44:37 +05:00
Ali-D-Akbar
b8d36e7a18 refactor: disable xss PROD-2316 2021-04-14 16:42:57 +05:00
Justin Hynes
19d1105d0f feat: skip bulk certificate invalidation during bulk regeneration in v2 certs
[MICROBA-1077]
* Skip bulk certificate invalidation during bulk regeneration. I couldn't come up with a reason to continue to invalidate certificates right before we attempted regeneration.
2021-04-14 07:33:21 -04:00
Awais Qureshi
6b6e87e797 refactor: upgrading factory-boy. 2021-04-14 15:17:32 +05:00
stvn
f08dcdbf51 refactor: Import a single function, not the whole module 2021-04-13 23:25:48 -07:00
stvn
43698fff0a refactor: Move get_course_by_id helper from LMS to core
This helper is used by the LMS, CMS, _and_ `openedx.core`,
so let's move it to `openedx.core` to reduce import complexity.

The following files no longer import from LMS:
- cms/djangoapps/contentstore/management/commands/edit_course_tabs.py
- lms/djangoapps/ccx/migrations/0006_set_display_name_as_override.py
- openedx/core/djangoapps/ccxcon/api.py
- openedx/core/djangoapps/verified_track_content/models.py
- openedx/features/course_experience/plugins.py

Note: The LTI XBlock has a dependency on this import path (!?);
a fix can be found here [1].

- [1] https://github.com/edx/xblock-lti-consumer/pull/154
2021-04-13 23:25:48 -07:00
Thomas Tracy
a4b338febc refactor: reformat the manual verifications command to allow for single user verification (#27305)
* refactor: reformat the manual verifications command to allow for single user verifications

* reformat error message

* linting

* linting: add doc string

* whitespace
2021-04-13 11:02:56 -04:00
Hammad Ahmad Waqas
d904534fc8 Merge pull request #27239 from edx/hammad/ENT-4361
ENT-4361 | Added user's "id" and "email" as public fields in ACCOUNT_VISIBILITY_CONFIGURATION.
2021-04-13 17:21:43 +05:00
Justin Hynes
2c96a2aca9 feat: stop removing verify_uuid value when revoking course certificates
[MB-1077]
- Stop removing the verify_uuid when revoking course certificates. In v2 of course certificates this will allow us to retain the same URL to the certificate. If a learner's certificate is revoked (from being invalidated or no longer passing the course) the UUID will remain intact and the URL will not change.
- Look for an existing cert for the user in a course-run during generation. If one exists, use the UUID from the existing certificate when updating the record.
- Stop generating a `key` for v2 web-certificates. This is not needed for web-certs (this is used in PDF cert generation).
2021-04-12 14:39:21 -04:00
HammadAhmadWaqas
3aa9248dcf * Added user's "id" and "email" as public fields in ACCOUNT_VISIBILITY_CONFIGURATION.
* Updated api/user/v1/accounts list view to search based on multiple emails as well.
2021-04-12 21:13:53 +05:00
Kyle McCormick
4531e15519 refactor!: stop using import_shims
Attempting to import packages from
lms/djangoapps, cms/djangoapps, or common/djangoapps
as if they are import roots will now
simply raise ImportErrors (like any other invalid
import) instead of DeprecatedEdxPlatformImportError.

See docs/decisions/0007-sys-path-modification-removal.rst
for more details.
2021-04-12 09:43:59 -04:00
Kyle McCormick
f92740b39f refactor: remove superfluous courseware/__init__.py warning 2021-04-12 09:43:59 -04:00
Awais Jibran
30c80082c3 Use config settings for olxcleaner (#27294)
* Use config settings for olxcleaner

Use config settings instead of hardcoded values for olx validation. This would help in adding a great deal of control when you want to change these settings in the future. With this approch we would not need a redeploy.

* Use configs and deprecate waffleflag and also add / update tests
2021-04-12 16:27:42 +05:00
Uzair Rasheed
488069f0cf Merge pull request #27292 from edx/add-separate-ratelimit-var
Add independent ratelimit setting for forms
2021-04-10 14:46:53 +05:00
Feanil Patel
16e4aa3c62 chore: Remove decentralized devstack config.
We have decided not to pursue the decentralized devstack design right
now and so we want to cleanup files and task that were built as a part
of the process.

Related Ticket: ARCHBOM-1685
2021-04-09 15:50:03 -04:00
uzairr
1d5a95facb Add independent ratelimit setting for forms
Currently, login and registration forms and view to log the user in
are sharing same ratelimit settings which is causing too much noise
while rendering forms.This PR will introduce a separate
setting for logistration forms.

VAN-436
2021-04-09 21:10:08 +05:00
Bianca Severino
83ceefc4c5 Merge pull request #27244 from edx/bseverino/proctoring-info-masquerade
[MST-738] Pass username into CourseHomeMetadataView
2021-04-09 10:44:04 -04:00