Commit Graph

62318 Commits

Author SHA1 Message Date
Agrendalath
3380f88ab3 refactor: delete class XmlDescriptor
It also adds `@XBlock.needs("i18n")` to `XModuleMixin` because this service is
required there.
2022-12-05 13:57:41 +01:00
Agrendalath
8127d19115 refactor: replace XmlMixin with XmlParserMixin
Most of the methods in `XmlMixin` act as wrappers for the official API for
serialization and deserialization (parse_xml() and add_xml_to_node()).
`XmlParserMixin` contains the code which does the actual serialization and
deserialization.
2022-12-05 13:57:41 +01:00
Agrendalath
499f09e2fb refactor: convert from_xml to parse_xml for TranslateCustomTagBlock 2022-12-05 13:57:41 +01:00
Agrendalath
20f6650f53 refactor: convert from_xml to parse_xml for VideoBlock 2022-12-05 13:57:41 +01:00
Agrendalath
1bfd3842c7 refactor: convert from_xml to parse_xml in CourseBlock 2022-12-05 13:57:41 +01:00
Agrendalath
da2e89db83 refactor: move resources_dir from XmlMixin to XmlParserMixin 2022-12-05 13:57:41 +01:00
Hammad Ahmad Waqas
18df1f020e Merge pull request #31389 from openedx/hammad/ENT-6470
fix: updated management command to consider in-progress courses before suggestion.
2022-12-05 17:17:54 +05:00
SaadYousaf
d71b21156b feat: add forum response event for marking responses as answered or endorsed 2022-12-05 16:35:52 +05:00
Muhammad Adeel Tajamul
7a0010ad0e feat: added topics v3 api (#31330)
Co-authored-by: adeel.tajamul <adeel.tajamul@arbisoft.com>
2022-12-05 15:07:21 +05:00
edx-pipeline-bot
883b816430 Merge pull request #31393 from openedx/private_to_public_c1e4cb3
Mergeback PR from private to public.
2022-12-05 02:58:36 -05:00
Ali Akbar
c1e4cb3a87 Merge pull request #253 from edx/moeez96/LEARNER-9001
fix: Fix retiring user auth models on disable event
2022-12-05 11:53:58 +05:00
Jenkins
6ed0a6bc4d chore(i18n): update translations 2022-12-04 15:58:36 -05:00
Rebecca Graber
23e12ac779 feat: pass event_metadata to event bus (#31390) 2022-12-02 09:42:14 -05:00
hammadahmadwaqas
583346f67b fix: updated management command to consider in-progress courses before suggestion. 2022-12-02 16:08:20 +05:00
Alfredo Guillem
08007033f3 Merge pull request #31386 from openedx/enterprise-bump
chore: version bump edx-enterprise to 3.58.15
2022-12-02 10:09:48 +01:00
Alfredo Guillem
5a5edd4efb chore: version bump edx-enterprise to 3.58.15 2022-12-01 17:33:01 +00:00
Alfredo Guillem
817722b16a Update development.txt 2022-12-01 16:07:04 +01:00
Alfredo Guillem
fbec399650 chore: version bump edx-enterprise to 3.58.15 2022-12-01 16:06:35 +01:00
Alfredo Guillem
1ded84e2c5 chore: version bump edx-enterprise to 3.58.15 2022-12-01 16:05:15 +01:00
Jansen Kantor
8eb3277414 feat: add problemgradereport config for writing to disk (#31385)
in the problemgradereport currently we must currently hold the entire file in memory before writing it all at once. to avoid out of memory celery issues to resolve a blocking bug for some MIT courses, add a temp waffle flag `instructor_task.use_on_disk_grade_reporting` which when activated uses this new report to (hopefully) allow the report to complete. Additional testing and consideration is required for this approach.
2022-12-01 09:48:50 -05:00
ayesha waris
ecc9a7c3e3 Merge pull request #31336 from openedx/INF-628
fix: course_staff and course_admin added in get_course api
2022-12-01 16:35:13 +05:00
Mehak Nasir
8be2b7355b fix: thread will only be returned for matching course ID (#31340) 2022-12-01 16:17:19 +05:00
Usama Sadiq
9bfcc6ca3d fix: Remove custom mypy admin classes (#31379)
* fix: remove custom mypy admin classes
2022-12-01 16:13:18 +05:00
Muhammad Soban Javed
1b17819b21 Merge pull request #31364 from openedx/zshkoor/circle-ci-removed
Removed Circle CI
2022-12-01 15:04:10 +05:00
ayeshoali
1363fcb501 fix: test cases fixed 2022-12-01 14:36:57 +05:00
ayeshoali
67bbf46920 fix: course_staff and course_admin added in get_course api 2022-12-01 14:33:54 +05:00
Andrew Shultz
cd1d278ba2 Merge pull request #31380 from openedx/ashultz0/more-goal-email-info
fix: wrap course goals email handle to report on errors
2022-11-30 16:06:36 -05:00
Jenkins
dc4a868685 chore: geoip2: update maxmind geolite country database 2022-11-30 16:03:29 -05:00
Jansen Kantor
0577944c4e temp: additional memory usage logging for problem report (#31381)
* temp: additional memory usage logging for problem report

* fixup! Merge branch 'master' into jkantor/temp-problemreport-logging

* fixup! fixup! Merge branch 'master' into jkantor/temp-problemreport-logging
2022-11-30 15:54:41 -05:00
Alejandro Cardenas
cd54e8b275 feat: add django admin page for survey report (#31323)
* feat: add django admin page for survey report

* fix: solve quality test errors

* feat: remove delete buttons and delete actions

* docs: add help_text to fields

* test: fix quality test issues

* docs: remove model form and add help_text in model

* feat: add migration to apply field changes
2022-11-30 12:22:46 -05:00
Andrew Shultz
5bd39dd79a Merge branch 'master' into ashultz0/more-goal-email-info 2022-11-30 12:15:30 -05:00
Michael Roytman
ef31ad6302 Merge pull request #31373 from openedx/mroytman/bump-xblock-lti-consumer-7.0.2
Upgrade lti-consumer-xblock to Install Fixes to Basic Outcomes Service and Result Service
2022-11-30 12:06:46 -05:00
Andrew Shultz
480e2fafe8 Merge branch 'master' into ashultz0/more-goal-email-info 2022-11-30 11:51:54 -05:00
michaelroytman
32d48e7881 feat: upgrade lti-consumer-xblock to install fixes to Basic Outcomes Service and Result Service
This commit upgrades the version of the lti-consumer-xblock library from version 6.4.0 to version 7.0.2. This includes versions 7.0.0, 7.0.1, and 7.0.2.

Version 7.0.0 includes refactoring to remove deprecated method calls to rebind_noauth_module_to_user, get_real_user, runtime.hostname, and runtime.course_id.

Version 7.0.1 includes a fix to the clean method of the LtiConfiguration model. The fix changes the way we look up the course ID so that we can access the course ID without needing to load the XBlock.

Version 7.0.2 includes fixes to LTI 1.1 Basic Outcomes Services and LTI 2.0 Result Service when using an external_user_id as a user identifier.

Note that version 7.0.1 was originally deployed in https://github.com/openedx/edx-platform/pull/31369. It was reverted soon after in https://github.com/openedx/edx-platform/pull/31377. The issue occurred in version 7.0.0, in the following line https://github.com/openedx/xblock-lti-consumer/pull/249/files#diff-ab027143adc95b9776c12e973e28f025a21b0d88112937af93645829686527fdL186. self in the call to the service is an instance of the OutcomeService. self should be an instance of an XBlock (i.e. LtiConsumerXBlock). Version 7.0.2 fixes this bug by moving the call to the service to the LtiConsumerXBlock, where self is an instance of an XBlock. Therefore, we are deploying this version to fix forward.

Please see the CHANGELOG entries below for these versions for a full description of the changes.

Version 7.0.0: https://github.com/openedx/xblock-lti-consumer/blob/master/CHANGELOG.rst#700---2022-11-29
Version 7.0.1: https://github.com/openedx/xblock-lti-consumer/blob/master/CHANGELOG.rst#701---2022-11-29
Version 7.0.2: https://github.com/openedx/xblock-lti-consumer/blob/master/CHANGELOG.rst#702---2022-11-29.

The commit messages of each version are included below for convenience.

7.0.0
-----
refactor: replace block.location with block.scope_ids.usage_id

7.0.1
-----
fix: do not attempt to load the block just to look at the location
the block is not loadable in exams so clean fails in that IDA, but
we shouldn't need the block to ask a question about the course

7.0.2
-----
In #307, we added the ability to send a stable, static user identifier (i.e. external user ID) to fix failed launches with the QwikLabs tool. This is because the QwikLabs tool did not work with the course-anonymized user IDs we used to send (i.e. anonymous user IDs). Inadvertently, this change broke the LTI 1.1 Basic Outcomes Service and the LTI 2.0 Result Service for courses that use the external user ID (i.e. they have the lti_consumer.enable_external_user_id_1p1_launches CourseWaffleFlag enabled). The Basic Outcomes Service and Result Service handle grade pass backs. Because we now have two ways to identify a user in LTI 1.1/2.0, we must update the Basic Outcomes Service and Result Service to support both. This commit fixes this bug.
2022-11-30 11:40:51 -05:00
Andy Shultz
5ff9b73da3 fix: wrap course goals email handle to report on errors
currently this is failing many runs but the exception information is
lost at some higher level. Report on it immediately.
2022-11-30 10:55:02 -05:00
Glib Glugovskiy
33968fb376 docs: ADR for signatures migration 2022-11-30 10:13:57 -05:00
Henrry Pulgarin
93fd8cc148 fix: prevent 500 error when course mode currency is not the same as the one configured in settings (#31312)
This commit solves the http 500 error when course concurrency is setted different for PAID_COURSE_REGISTRATION_CURRENCY and course modes.
2022-11-30 09:50:48 -05:00
Usama Sadiq
929d4b97d2 Revert "feat: update xblock lti library to version 7" (#31377) 2022-11-30 13:19:49 +05:00
Feanil Patel
5bb84e9962 Merge pull request #31366 from openedx/feanil/minimal_config
feat: Add a minimal yaml file for use with production.py
2022-11-29 15:19:18 -05:00
Feanil Patel
456eecb479 Merge pull request #31370 from openedx/feanil/partial_rtd_yaml_config
docs: Try to explicitly set python 3.8 for docs.
2022-11-29 15:18:35 -05:00
Marlon Keating
1582b800c7 Merge pull request #31371 from openedx/marlonkeating-versionbump
chore: version bump edx-enterprise to 3.58.14
2022-11-29 11:59:35 -08:00
Feanil Patel
df4b59d93e docs: Update build operating system.
Co-authored-by: Carlos Muniz <cmuniz@tcril.org>
2022-11-29 14:54:20 -05:00
Feanil Patel
f83865212f feat: Add a minimal yaml file for use with production.py
Sometimes you just want to run a few paver or django commands without
having to bring up the entire development stack.
2022-11-29 14:10:04 -05:00
Jansen Kantor
db082830e3 fix: slight change to logic of how teams is considered enabled (#31277)
* fix: slight change to logic of how teams is considered enabled

* fixup! fix: slight change to logic of how teams is considered enabled
2022-11-29 14:01:55 -05:00
Navin Karkera
c302c8a22b feat: block metadata api - index_dictionary
Adds new api to return block metadata which includes index_dictionary.
Reason for new api instead of adding it to course blocks API: data like
index_dictionary are too large for the cache used by course/blocks
transformers API.
2022-11-29 10:49:36 -08:00
Marlon Keating
8dca5638df chore: version bump edx-enterprise to 3.58.14 2022-11-29 18:03:19 +00:00
Andrew Shultz
92d3d7988b Merge pull request #31369 from openedx/ashultz0/lti701
feat: update xblock lti library to version 7
2022-11-29 12:31:15 -05:00
Andy Shultz
1985cd6d15 feat: update xblock lti library to version 7
7 removed use of various deprecated block methods, 7.0.1 includes
a minor bugfix
2022-11-29 11:54:32 -05:00
Feanil Patel
a2499f94ef docs: Try to explicitly set python 3.8 for docs.
This repo currently builds multiple RTD projects out of it and the yaml
config doesn't really have a way to specify which project it's for so we
keep this minimal.

The hope is that any settings it doesn't find here it will pick up from
the advanced project settings in RTD.

We need to explicitly set the python version because RTD seems to be
defaulting to Python 3.7 otherwise and that's not compatible with some
of the requirements in our docs.txt file which no longer support
python<3.8

We need to explicitly list any extra requirements files we want to
install and that can't be set per project but luckily all the doc
projects share the same requirements file.
2022-11-29 11:51:26 -05:00
Feanil Patel
eaf4ba6054 Merge pull request #31367 from openedx/feanil/bleach_css
feanil/bleach css
2022-11-29 11:25:07 -05:00