Commit Graph

59161 Commits

Author SHA1 Message Date
David Ormsbee
35b2780658 perf: avoid invoking codejail for problem response report
We don't need to execute instuctor code for the problem response
report because we're grabbing existing student state and scores.
Running codejail is expensive, slow, and risks report failures if
there is CPU intensive instructor code that is run at times when
the servers are already heavily loaded (and things start timing
out). This came up in TNL-8183 (and many others).
2021-04-07 11:11:07 -04:00
Kyle McCormick
19ba691e33 refactor: clean up some courseware URL handling docs & tests
Based on Julia's code review.
2021-04-07 10:24:58 -04:00
Kyle McCormick
a69567b18b feat: default staff to courseware MFE if active (via jump_to)
The /jump_to/ LMS endpoint is used in a number of places
to direct users to courseware. It currently only redirects to
Legacy courseware URLs, which then conditionally may
redirect to the Learning MFE.

Two issues with this:
1. Performance Impact: In most cases, going to Legacy first
   is just an extra redirect.
2. Confusion for Privileged Users: Neither course nor global
   staff are auto-redirected from the Legacy experience to the
   MFE. Thus, these priviliged users confusingly never see the
   MFE by default; they must always manually click into it.

This commit makes it so that /jump_to/ directs
users to whatever the default courseware experience is
for them. For staff of courses active in the new experience,
this will impact (at a minimum) the "View Live"
links in Studio, all links on the old and new LMS
course outline, and the "Resume" links on the course
dashboard. Learners should see no difference other than
a performance improvement when following courseware links
from the LMS.

This also adds an optional 'experience=[legacy|new]'
query param to /jump_to/, allowing us to specifically
generate Legacy courseware URLs for the
"View in Legacy Experience" tool.

TNL-7796
2021-04-07 10:24:58 -04:00
Kyle McCormick
4a5928d3e8 refactor: in TestJumpTo, say 'sequence' instead of 'section'
'section' is a very outdated (<2012) way to refer sequences,
which we also call 'subsections'. The old terminology still exists
throughout the courseware djangoapps, but I decided to clean up this
one test case while I'm working on it.
2021-04-07 10:24:58 -04:00
Kyle McCormick
4c027b99a2 refactor: factor out _toggle_mfe_waffle_flag test util 2021-04-07 10:24:58 -04:00
Jansen Kantor
079f43f40d EDUCATOR-5571: filter gradebook api by course staff role (#26994)
feat: add excluded_course_roles parameter to gradebook view to allow omitting staff
2021-04-07 10:09:16 -04:00
Usama Sadiq
25b275bca4 refactor: Ran pyupgrade on openedx/core/djangoapps
Ran pyupgrade on openedx/core/djangoapps/{xblock, xmodule_django, zendesk_proxy}
2021-04-07 18:57:52 +05:00
Usama Sadiq
ac8c3b6a03 refactor: Ran pyupgrade on openedx/core/djangoapps
Ran pyupgrade on openedx/core/djangoapps/{util, verified_track_content}
2021-04-07 18:57:12 +05:00
Usama Sadiq
d540688f8e refactor: Ran pyupgrade on openedx/core/djangoapps/user_authn 2021-04-07 18:54:33 +05:00
Piotr Surowiec
bc1e9afe4b feat: allow overriding unit icons (#21433)
This:
1. Introduces a new override using the `pluggable_override` decorator.
It is now possible to specify a custom way of getting XBlock's icon
by defining `GET_UNIT_ICON_IMPL` in settings.
2. Introduces a way to add custom `XBLOCK_MIXINS` by defining
`XBLOCK_EXTRA_MIXINS` in settings. This allows, e.g. to add
new fields to XBlocks.
2021-04-07 09:42:12 -04:00
Christie Rice
3d20c848f8 style: Use constants for certificate status. Update certificate status and grade documentation. (#27250)
MICROBA-1074
2021-04-07 09:38:56 -04:00
Ahtisham Shahid
581230d16d Fixed notes background color contrast (#27004)
* Fixed notes background color contrast
2021-04-07 17:26:02 +05:00
Saqib
10fc3f4b38 docs: add annotations for CUSTOM_CERTIFICATE_TEMPLATES_ENABLED feature flag (#27185) 2021-04-07 08:21:14 -04:00
Awais Jibran
1d39e431e3 Use allowed_xblocks settings (#27265)
* Use allowed_xblocks in olxcleaner validate.
2021-04-07 15:45:04 +05:00
Muhammad Ammar
9d7e804236 Merge pull request #27255 from edx/ammar/update-cache-key-for-dsc
update cache key for DSC
2021-04-07 15:27:42 +05:00
edX requirements bot
e16f813a55 Updating Python Requirements 2021-04-07 14:16:06 +05:00
Jawayria
d892792ff7 Merge pull request #26557 from edx/jawayria/bom-2352-4
BOM-2352: Remove unused imports from lms/djangoapps/{course_wiki, cou…
2021-04-07 13:55:37 +05:00
Jawayria
cf81718b10 Merge pull request #26601 from edx/jawayria/bom-2408-4
BOM-2408: Remove unused imports from openedx/core/djangoapps/{dark_la…
2021-04-07 12:56:37 +05:00
Jawayria
a4744dfde1 Merge pull request #26600 from edx/jawayria/bom-2408-3
BOM-2408: Removed unused imports from openedx/core/djangoapps/{conten…
2021-04-07 12:56:20 +05:00
Jawayria
707f940770 Refactor: Removed unused imports
Removed unused imports from lms/djangoapps/{course_wiki, coursewarehistoryextended, discussion}
2021-04-07 12:54:21 +05:00
Ahtisham Shahid
f3a62b5f89 Error message for proctor exam show to user (#27238)
* Error message for proctor exam visible to user

* Created exception class for Invalid Proctor settings
2021-04-07 10:46:19 +05:00
Zaman Afzal
194f29ca55 ENT4134 Add the support for multiple IDPs (#27073)
* ENT4134 Add the support for multiple IDPs
2021-04-06 23:27:20 +05:00
Robert Raposa
29c98511eb Merge pull request #27260 from edx/robrap/improve-course-override-docs
ARCHBOM-1721: docs: improve CourseWaffleFlag admin docs
2021-04-06 12:28:12 -04:00
Awais Jibran
9b4f19f204 Update olxcleaner (#27261) 2021-04-06 21:26:24 +05:00
Awais Jibran
d4c557f765 Reference openedx/olxcleaner (#27256)
* Reference openedx/olxcleaner and remove pypi for olxcleaner
2021-04-06 20:40:25 +05:00
Justin Hynes
6645d0348a Merge pull request #27258 from edx/jhynes/microba-974_invalidate_cert_properly
fix: invalidate certificate properly when regenerating certs from the support tool
2021-04-06 11:27:22 -04:00
Robert Raposa
280f8e1577 docs: improve CourseWaffleFlag admin docs
Improve the docs for how to configure CourseWaffleFlag
overrides via Django admin.

ARCHBOM-1721
2021-04-06 11:05:44 -04:00
Zaman Afzal
3bcfe511b3 update edx-enterprise version (#27259) 2021-04-06 20:02:12 +05:00
Justin Hynes
2d6a4126e7 fix: invalidate certificate properly when using regeneration from support tool
[MICROBA-974]
* Update `regen_cert` function to call the certificate objects `invalidate` method, instead of just setting the certificate status as 'unavailable'. This change will make it so the certificate revoked signal is sent in an attempt to keep data in the Credentials IDA in sync
2021-04-06 10:30:19 -04:00
Justin Hynes
eda12d8cf8 Merge pull request #27246 from edx/jhynes/microba-1109_update_checks
fix: update v2 certificate generation eligibility logic
2021-04-06 10:14:40 -04:00
Jawayria
83aa5f02f1 Refactor: Removed unused imports
Removed unused imports from openedx/core/djangoapps/user_api
2021-04-06 18:25:35 +05:00
Azan Bin Zahid
7c3f22a0a2 Merge pull request #27257 from edx/IM/security-fixes-10-thresholds
chore: update thresholds after IM security fixes 10
2021-04-06 18:23:56 +05:00
Justin Hynes
13d174fdda fix: update v2 certificate generation eligibility logic
[MICROBA-1109]
* Remove the requirement for the `auto_certificate_generation` waffle switch to be enabled in order for a learner to be eligible for a certificate. This switch should control _when_ a certificate is generated, not _if_ a certificate will be generated for a learner.
* Move the `auto_certificate_generation_enabled` check to happen before we try to generate v2 certificates in signals.py
* Update unit tests
* Update documentation
2021-04-06 08:50:54 -04:00
Jawayria
772f8cbe90 refactor: Removed unused imports
Removed unused imports from cms using 'unimport'
2021-04-06 17:47:48 +05:00
muhammad-ammar
3929d098b6 update cache key for dsc 2021-04-06 17:34:42 +05:00
Jawayria
4cdf466215 refactor: Removed unused imports
Removed unused imports from openedx/core/{djangolib, lib} and openedx/{tests, features}
2021-04-06 17:24:04 +05:00
Jawayria
6ad42655b4 Refactor: Removed unused imports
Removed unused imports from openedx/core/djangoapps/{theming, user_authn, xblock}
2021-04-06 17:15:39 +05:00
Jawayria
8fc7333982 Refactor: Remove unused imports
Removed unused imports from openedx/core/djangoapps/{dark_lang, django_comment_common, embargo, lang_pref, oauth_dispatch, plugins, programs, schedules}
2021-04-06 17:11:59 +05:00
Sarina Canelake
6e71251f57 Merge pull request #27209 from raccoongang/ideg/fix_language_preferences_change
fix: Language preferences change enhancement.
2021-04-06 08:09:40 -04:00
Jawayria
df06d1312d refactor: Removed unused imports
Removed unused imports from openedx/core/djangoapps/{content_libraries, coursegraph,courseware_api, crawlers, credentials, credit}
2021-04-06 17:07:13 +05:00
Jawayria
106b22ea70 Merge pull request #27182 from edx/jawayria/bom-2462-commit-msg
build: updating commit message
2021-04-06 17:03:45 +05:00
Azan Bin Zahid
705253e20a chore: update thresholds after IM security fixes 10 2021-04-06 15:40:04 +05:00
edX requirements bot
401789dad3 Updating Python Requirements (#27251) 2021-04-06 13:03:24 +05:00
Usama Sadiq
91ea53da56 refactor: Ran pyupgrade on openedx/core/djangoapps/user_api 2021-04-06 12:50:48 +05:00
Usama Sadiq
c14eab1332 refactor: Ran pyupgrade on openedx/core/djangoapps/site_configuration 2021-04-06 12:50:34 +05:00
Usama Sadiq
ebcf204d60 refactor: ran pyupgrade on openedx/core/djangoapps
ran pyupgrade on openedx/core/djangoapps/{schedules, self_paced, service_status}
2021-04-06 12:50:11 +05:00
edX cache uploader bot
9106174b5a Updating Bokchoy testing database cache 2021-04-06 12:19:47 +05:00
Simon Chen
1d186b34bf MST-734 Fix production issue on Learner Onboarding Status Panel (#27248)
* MST-734 Fix production issue on Learner Onboarding Status Panel
Fix the prod issue where learning sequence service object missing the needed get_user_course_outline service API
The user web API call currently returns 500
2021-04-05 16:54:58 -04:00
stvn
716b84d9df Merge PR #27202 fix/capa/empty-option-text
* Commits:
  fix: Allow capa_problem optioninput option with empty text
  refactor: Refactor capa_problem optioninput option text handling
2021-04-05 13:27:22 -07:00
Simon Chen
151efd2cb6 Add edx-proctoring=3.8.2 to edx-platform constraint file to prevent others from upgrading it to 3.8.3 accidentally (#27249) 2021-04-05 15:57:22 -04:00