David Baumgold
c26edbd631
jasmine-jquery compatiblity post-backport
2013-05-23 10:14:47 -04:00
David Baumgold
4736527952
Add Jasmine tests to cover AJAX error notifications
2013-05-22 15:55:56 -04:00
David Baumgold
0a7222b123
Allow an AJAX call to specify that it should not notify on error
...
Because there are some cases where it's OK to fail, and it's not the user's fault
2013-05-22 15:55:56 -04:00
Brian Talbot
2359c43855
studio - revises z-index/element depth levels for modals, notifications, prompts, and alerts to use universal .depth Sass extends
2013-05-22 15:55:56 -04:00
David Baumgold
3738078ce9
Load system feedback template for SectionEdit tests
2013-05-22 15:55:56 -04:00
Brian Talbot
bc6e480103
studio - corrects some errand new icon-based typography rules to use the line-height() mixin
2013-05-22 15:55:55 -04:00
David Baumgold
3cfadb8ae8
Migrated internationalization text into template for section name
2013-05-22 15:55:55 -04:00
Frances Botsford
fa330784d3
removed symbolset, replaced with fontawesome for gradable status; added transform-origin for saving notification animation to remove wobble
2013-05-22 15:55:55 -04:00
David Baumgold
dc2acb18ee
Moved global AJAX Error handler definition to main.coffee
2013-05-22 15:55:55 -04:00
David Baumgold
f3523d805f
Escape section name in Backbone to prevent XSS
2013-05-22 15:55:55 -04:00
Brian Talbot
bb0460cc0d
studio - changes all specific ss-icon-based selectors to use Font Awesome/generic icon- class name in notifications/prompts/alerts Sass
2013-05-22 15:55:55 -04:00
Frances Botsford
4e79d064a0
removed symbolset, replaced with fontawesome for alerts, notifications, and all references in js files
2013-05-22 15:55:55 -04:00
David Baumgold
9e864834bd
Unify system feedback templates
...
Also, a SystemFeedback model no longer has a `type`, it has an `intent`. This is
because SystemFeedback views have `type`, as well, and this prevents a naming
collision.
2013-05-22 15:55:55 -04:00
David Baumgold
1e7e38824a
Shorten secondary action detection code
2013-05-22 15:55:54 -04:00
David Baumgold
5a06c69289
Add toBeShown and toBeHiding matchers for Jasmine
...
To reduce redundancy in tests
2013-05-22 15:55:54 -04:00
David Baumgold
0052eaacbc
Backbone section: don't save name on validation error
2013-05-22 15:55:54 -04:00
Brian Talbot
7ae534799b
studio - revises error message copy when section name is left blank on outline view
2013-05-22 15:55:54 -04:00
David Baumgold
c628a8a360
Fix test
2013-05-22 15:55:53 -04:00
David Baumgold
a8431eeae2
Section model shouldn't react to AJAX errors
...
Doing so overrides the AJAX error popup
2013-05-22 15:55:53 -04:00
David Baumgold
525fe2d581
Expose a dummy gettext function in the Jasmine test env
2013-05-22 15:55:53 -04:00
Brian Talbot
0fd3bb6079
studio - removes the .is-fleeting class/animation that is handled by backbone's min/max time for notifications
2013-05-22 15:55:53 -04:00
Brian Talbot
02e022ec7b
studio - revises the min amount of time the saving notification appears on the outline view
2013-05-22 15:55:53 -04:00
David Baumgold
a0a71c0df2
Internationalization for JS
2013-05-22 15:55:53 -04:00
David Baumgold
9cbfee9894
Fix Jasmine tests related to invalid messages for section model
2013-05-22 15:55:53 -04:00
David Baumgold
2b01273f7f
Added some Jasmine tests for section views in Backbone
2013-05-22 15:55:52 -04:00
David Baumgold
6ed5a2aa01
Added tests for Backbone section models
2013-05-22 15:55:52 -04:00
David Baumgold
56d8a467c8
Add tests for minShown and maxShown in views
2013-05-22 15:55:52 -04:00
David Baumgold
09a8075355
If a Backbone view can't find its template, I want to know
2013-05-22 15:55:52 -04:00
David Baumgold
d10e644c6e
Added sinon.js to project
2013-05-22 15:55:52 -04:00
David Baumgold
dc76d71c42
4-space indents for coffeescript
2013-05-22 15:55:52 -04:00
David Baumgold
fcf4cdc75e
Implement minShown and maxShown for notification views
2013-05-22 15:55:51 -04:00
David Baumgold
91c2594c8d
Fix section name validation alerting
2013-05-22 15:55:51 -04:00
David Baumgold
4af3325976
Move display logic into view
...
Model shouldn't know about things like close buttons, visibility, and so on
2013-05-22 15:55:51 -04:00
David Baumgold
528987342a
Add tests for primary and secondary CSS classes
2013-05-22 15:55:51 -04:00
David Baumgold
fedfe8627f
Add tests for click events on views
2013-05-22 15:55:51 -04:00
David Baumgold
070d24cf61
Jasmine doesn't like asserting on the <body> element :(
2013-05-22 15:55:51 -04:00
David Baumgold
10ec604630
Got jasmine tests working with fixtures properly
2013-05-22 15:55:50 -04:00
David Baumgold
0c368011da
Move underscore templates into separate files, included in Mako templates
2013-05-22 15:55:50 -04:00
David Baumgold
5275e41e4a
Adding new feedback view tests
2013-05-22 15:55:50 -04:00
David Baumgold
39f81df476
Added a few more tests for feedback models
2013-05-22 15:55:50 -04:00
David Baumgold
e440580c79
Started writing Backbone tests
...
Hacking the Python, because our JS dependency management is borked.
2013-05-22 15:55:50 -04:00
David Baumgold
69a6ec0c97
Don't fall over if a model doesn't have actions defined
...
It appears that one notification stealing focus from another causes some weirdness:
both clicking on a button on one view triggers the event on both views (the original
and the new view that stole the div). As long as the first view does *not* define
any click events, everything is fine -- this is the case for the saving notification.
I'll worry about the reason for this later; it has something to do with views
listening to models even after they no longer should be.
2013-05-22 15:55:50 -04:00
David Baumgold
1333717871
Message action callbacks have model set to this
2013-05-22 15:55:50 -04:00
David Baumgold
f5f7cf705f
Subclass CMS.Models.SystemFeedback
...
To create handy WarningMessage, ErrorMessage, and ConfirmationMessage classes
2013-05-22 15:55:50 -04:00
David Baumgold
c6c5e50d86
Hook up notification framework to default AJAX error callback
...
And delete `CMS.ServerError`
2013-05-22 15:55:49 -04:00
David Baumgold
e2f5acef46
Turn course sections into Backbone models
...
Hook up course name edit interaction, with notification framework
2013-05-22 15:55:49 -04:00
David Baumgold
cd2f67afa4
Clone the attributes object
...
So that modifications don't affect the model
2013-05-22 15:55:49 -04:00
David Baumgold
0dc3446523
Handle saving popup
2013-05-22 15:55:49 -04:00
David Baumgold
5746121f5c
Set up Notification and Prompt
2013-05-22 15:55:49 -04:00
David Baumgold
5c2116a4b3
Make abstract view, make Alert inherit from it
2013-05-22 15:55:49 -04:00
