Commit Graph

22953 Commits

Author SHA1 Message Date
Christie Rice
87a620612f fix: Remove V2 certificate checks from the certificates app, since V2 of course certificates has been enabled globally for all course runs (#28108)
MICROBA-1083 DEPR-155
2021-07-08 14:27:27 -04:00
Matthew Piatetsky
73bbe8272f Merge pull request #28048 from edx/AA-874c
[AA-874] fix student progress url on student admin dashboard
2021-07-08 12:40:38 -04:00
Christie Rice
c194b3fa57 fix: Remove V2 certificate checks from the certificates app, since V2 of course certificates has been enabled globally for all course runs (#28102)
MICROBA-1083 DEPR-155
2021-07-08 09:23:58 -04:00
Matt Tuchfarber
63cb6a97ff Revert "feat: Reimagine certificate_availability_date and certificates_display_behavior" 2021-07-07 16:53:05 -04:00
Christie Rice
b4df37d48e docs: Mark ADR as accepted (#28110)
DEPR-157
2021-07-07 14:07:23 -04:00
Matt Tuchfarber
14fb517a78 Merge pull request #27830 from edx/tuchfarber/studio_changes
feat: Reimagine certificate_availability_date and certificates_display_behavior
2021-07-07 09:45:06 -04:00
Matt Tuchfarber
2a7106acfb feat: reimagine certificate display settings
The course settings `certificate_available_date` (CAD) and
`certificates_display_behavior` (CDB) were previously acting indedependantly
of one another. They now work in tandem. This change:
- limits CDB to a dropdown
- removes "early_with_info" and adds "end_with_date"
- only takes CAD into account if "end_with_date" is selected
- Moves CDB to the main course schedule settings page
- updates CourseOverview to validate these fields and choose sane
defaults if they aren't expected values

Certificates will now show under the following circumstances:
"Immediately upon passing"
certificate_availability_date = null
certificates_display_behavior = "early_no_info"

"End date of course"
certificate_availability_date = null
certificates_display_behavior = "end"

"A date after the course end date"
certificate_availability_date = <date>
certificates_display_behavior = "end_with_date"
2021-07-06 16:45:23 -04:00
Justin Hynes
ecd257ae29 feat!: Remove temp certificates mgmt cmd
[MICROBA-1311]
- Remove temporary management command used to fix records incorrectly created with a default `mode` of "honor".
2021-07-06 15:51:32 -04:00
Christie Rice
384bc6b514 fix: Fix cert status (#28097)
MICROBA-1372
2021-07-06 12:48:21 -04:00
Kyle McCormick
d86aa824c1 revert: feat: add & expose courseware.use_learning_sequences_api flag (#28054)
The learning_sequences.use_for_outlines flag was recently added,
intended to serve the same purpose
as courseware.use_learning_seuqences_api. We do not need
both flags.

Furthermore, exposing either flag in the Courseware
Metadata API is neither necessary nor helpful, since
the easiest and quickest way for the Learning MFE to see
if the Learning Sequences API is enabled is to hit it,
and fall back to a different API if a 403 is returned.

This reverts commit 78f1e2b3bd.

TNL-8330
2021-07-06 11:34:40 -04:00
Thomas Tracy
986f52faab [feat] Add has_scheduled_content to outline API
The outline API that the learning MFE needs to know if a course has
upcomming content for a new alert.
2021-07-06 11:33:53 -04:00
Christie Rice
b8114ebc59 fix: Remove V2 certificate checks, since V2 has been enabled globally for all course runs (#28077)
MICROBA-1083 DEPR-155
2021-07-06 11:00:54 -04:00
Matthew Piatetsky
0fc4fb581f Merge pull request #28033 from edx/AA-874
[AA-874] feat: add user id parameter to progress page
2021-07-02 08:39:16 -04:00
Matthew Piatetsky
6922f75a52 feat: add user id parameter to progress page 2021-07-01 15:50:13 -04:00
Adeel Ehsan
ee640cb7b2 Merge pull request #28075 from edx/aehsan/activation_cta_outline_removed
focused outline removed
2021-07-01 22:07:28 +05:00
Feanil Patel
4b2987205c Merge pull request #28066 from edx/feanil/arch-1821-alternative
fix!: Make default queue names service variant specific.
2021-07-01 09:56:18 -04:00
Justin Hynes
c1eb7c9054 Merge pull request #28070 from edx/jhynes/microba-1298
feat!: Remove certificate generation segment event
2021-07-01 09:43:04 -04:00
Justin Hynes
ad9c580ae1 Merge pull request #28064 from edx/jhynes/microba-1311_fix
feat: Add temporary mgmt cmd to fix certificate data
2021-07-01 08:39:11 -04:00
adeelehsan
254594dbed focused outline removed 2021-07-01 13:09:56 +05:00
Arjun Singh Yadav
52ab785764 fix: set answer notification alignment to bottom (#27022)
On focus to the answer submition notification, the
notification was scrolled to center of screen. This
behaviour was on Chrome(87+) browser.
This commits overrides the focus jQuery plugin to
set the alignment of answer notifications to the bottom of the
viewport.

Fix the custom focus jQuery plugin

Co-authored-by: Agrendalath
2021-06-30 14:34:44 -04:00
Justin Hynes
c40e772d04 feat: Add temporary mgmt cmd to fix certificate data
[MICROBA-1311]
* Add temporary mgmt cmd to certificates app to fix certificate records with incorrect data stemming from CR-3792.
2021-06-30 12:58:15 -04:00
Justin Hynes
4cd15acaf9 Fix failing unit test in courseware 2021-06-30 10:21:10 -04:00
Feanil Patel
c2d848860d fix!: Make default queue names service variant specific.
common.py has queue names that always get overridden by production.py
and lead to confusion.  Set a default SERVICE_VANIANT in common.py and
then set the queue names based on that in common.py so that
production.py doesn't make it more complicated.

This should prevent the issue where if you copy a queue name in
common.py it ends up being incorrect in the production system.  This is
what happened with the sample_task change.

https://github.com/edx/edx-platform/pull/23731 made it so that the queue
name for that queue is independently configurable but the default was
set to the value of HIGH_PRIORITY_QUEUE in common.py which is not the
same as the value set in production.py leading to stale tasks that never
get picked up in production.

BREAKING_CHANGE: If anyone was building a different settings file on top
of common, the default names in common.py are now change to be service
variant specific. eg 'edx.cms.core.high' instead of 'edx.core.high'
2021-06-30 10:06:28 -04:00
Justin Hynes
c1f7272174 feat!: Remove certificate generation segment event
[MICROBA-1298]
* Remove a Segment certificate event that was, historically, only emit from the courseware.

The Segment event that was previously (only) issued in the courseware doesn't seem to be important or referenced anywhere we could see. Since this event only tracked certificate generation attempts from one (of multiple) paths to initiate certificate generation in v1, I didn't think the historical event data captured is complete. We approached our data teams and I determined this event was not of high importance. For this reason, I am suggesting we just stop using this event and remove the code responsible for sending it.

We will continue to track certificate creation/generation using the existing `edx.certificate.created` event.
2021-06-30 09:23:46 -04:00
Christie Rice
e0b3829252 feat!: Remove management commands for V1 of course certificates, and PDF course certificates. (#28053)
These have been replaced by V2 of course certificates, and the cert_generation management command.

DEPR-155 MICROBA-1357 MICROBA-1358
2021-06-30 09:09:03 -04:00
Braden MacDonald
e2a867e975 fix: xblock-poll's celery tasks were not registered (#28019) 2021-06-30 16:10:56 +05:00
Zaman Afzal
843e9ba29b ENT4083: Removed ENABLE_MULTIPLE_USER_ENTERPRISES_FEATURE waffle switch (#28057) 2021-06-30 13:58:11 +05:00
Michael Terry
c62626227a fix: jump_to should redirect to first unit on invalid key
Previously, it would 404. While accurate, it's not a great user
experience. Users can be offered invalid jump_to paths in the normal
course of things, if course content disappears or they lose access
to it.

In both cases, they might be offered a resume URL in the courseware
that would be to a now-invalid location.

With this change, that invalid link will at least give them
*something* (the first unit in the course) rather than an error
page.

This also (unrelatedly) fixes an exception when the learning MFE
outline page tries to render a course that contains sequences
with no children.

AA-867
2021-06-28 15:43:12 -04:00
Christie Rice
24367919bb fix: Update logic for certificate generation status, and create cert with all available info (#28004)
MICROBA-1306 CR-3792
2021-06-28 10:05:34 -04:00
Albert (AJ) St. Aubin
b23169560f fix: Corrects issue with refund logic and certificates.
[MICROBA-1307]

Before this change a user would not be auto refunded if they had a
certificate in a course with any status. This had unintended
consequences. This change updates the logic to only block auto refund
for statuses that we do not want to refund on such as downloadable.
2021-06-28 09:20:00 -04:00
Manjinder Singh
9616a1c367 fix: adding code owner info to celery tasks (#28040)
Celery tasks needs decorator to correctly add ownership info:
https://github.com/edx/edx-django-utils/blob/master/edx_django_utils/monitoring/docs/how_tos/add_code_owner_custom_attribute_to_an_ida.rst#handling-celery-tasks
2021-06-28 09:15:31 -04:00
Matthew Piatetsky
36de3b8677 fix: fix student progress url on student admin dashboard 2021-06-28 09:15:14 -04:00
SaadYousaf
16972b4991 test: add tests to test override_legacy_discussion_settings flag with different roles 2021-06-28 11:54:17 +05:00
SaadYousaf
608f1994b7 refactor: move waffle flag calculation to utils file and other updates 2021-06-28 11:54:16 +05:00
SaadYousaf
90921e19e2 test: add tests for discussion settings and tab visibility with override_discussions_setting flag. 2021-06-28 11:54:16 +05:00
SaadYousaf
039a816e57 refactor: move pages_and_resources_mfe WaffleFlag to use in both LMS and Studio 2021-06-28 11:54:16 +05:00
SaadYousaf
09c8ef931e feat: Add CourseWaffleFlag for overriding course discussion settings for legacy experience. 2021-06-28 11:54:16 +05:00
Kyle McCormick
78f1e2b3bd feat: add & expose courseware.use_learning_sequences_api flag (#27993)
Add a Waffle Flag. When enabled, the courseware pages of the
Learning MFE should use the Learning Sequences HTTP API instead
of the Course Blocks HTTP API in order to load course structure
data. We expect that this switchover will lead to performance
improvements and a more comprehensible system.

(We are putting the switchover behind a temporary flag in order to
enable debugging, incremental rollout, and comparison testing.)

The flag is exposed to the MFE via the Course API.
As of this commit, the new flag is not enabled in any environment,
and the MFE does not have any code to act on the flag's value.
So, this commit on its own should have no production impact.

TNL-8330
2021-06-25 11:19:28 -04:00
Christie Rice
69580aa592 feat!: Read from the allowlist model, instead of from the whitelist model. Only write to the allowlist model. (#27974)
MICROBA-982
2021-06-25 09:47:32 -04:00
Dillon Dumesnil
61358b230e feat: AA-869: Add in logic to mark special exams as complete
This is technically a revert of a revert that also includes some new
logic. The original PR was https://github.com/edx/edx-platform/pull/27770
and the revert PR was https://github.com/edx/edx-platform/pull/27973.

The new logic is to mock a request and create a module with user state
taken into account. We also put this into a celery task to help avoid
any potential concerns with recursing through children.
2021-06-24 12:06:11 -07:00
Thomas Tracy
346ec161fe [refactor] Ttracy/MICROBA-1297: ID verify messaging updates on dashboard (#28012)
* [refactor] Reword dashboard verify ID message

Small change to reword ID verification messaging on the course dashboard
and remove one of the buttons.

* set coloring of warning message

* follow patter for theme font colors
2021-06-24 10:32:50 -04:00
Diana Huang
29548459fa refactor: Remove PyContracts usage. (#27887)
* refactor: Remove PyContracts usage.

We have not used PyContracts in a while and it is overhead we don't
need in edx-platform.

https://openedx.atlassian.net/browse/DEPR-147

* chore: Updating Python Requirements (#28018)

Co-authored-by: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com>
2021-06-23 18:24:06 -04:00
Carla Duarte
c708322f2b Merge pull request #28008 from edx/ciduarte/AA-866
fix: make scores floats rather than ints in progress tab api
2021-06-23 14:10:10 -04:00
Kshitij Sobti
d2c2fcdefe feat: Course Apps API [BD-38] [TNL-8103] [BB-2716] (#27542)
* feat: Course Apps API

This adds a new concept called course apps. These are exposed via a new
"openedx.course_app" entrypoint, which helps the LMS and studio discover such
apps and list them in a new rest api for the same.

These course apps will drive the pages and resources view in the course authoring
MFE. This system will track which apps are enabled and which are disabled. It
also allows third-party apps to be listed here by using the plugin entrypoint.

* Apply feedback from review
2021-06-23 21:51:12 +05:00
Christie Rice
29fcf8b868 fix: Copy data from the certificate whitelist to the certificate allowlist, including copying the created date (#28007)
MICROBA-982
2021-06-23 12:21:58 -04:00
Carla Duarte
b08a9d61ef fix: make scores floats rather than ints in progress tab api 2021-06-23 11:34:19 -04:00
Christie Rice
532b97b4e2 fix: Temporarily disable generating certificates with a non-downloadable status (#28000)
CR-3792 MICROBA-1306
2021-06-22 15:56:11 -04:00
adeelehsan
2e650110c9 activation a11y issue fixed 2021-06-22 21:44:15 +05:00
Justin Hynes
336e4dc7c9 Merge pull request #27990 from edx/jhynes/microba-1179_allowlist
refactor: Rename "whitelist" references to "allowlist" where possible in Instructor Dashboard/Certificates apps
2021-06-22 11:20:42 -04:00
Michael Terry
7952ab659b Merge pull request #27989 from edx/mikix/progress-access
feat: add learner_has_access field to progress tab data
2021-06-22 09:45:22 -04:00