Commit Graph

1591 Commits

Author SHA1 Message Date
Régis Behmo
9ab904fd19 fix: "Uncaught TypeError: n is null" during login to LMS (#29192)
When signing in from the LMS, the authentication request succeeds but
the user was never redirected to the dashboard. This is because of a
js error:

    Uncaught TypeError: userCookie is null
        userFromEdxUserCookie
        http://maple.openedx.overhang.io:8000/static/js/student_account/utils.js:32

The error comes from the fact that the util.js code ignores the
EDXAPP_EDXMKTG_USER_INFO_COOKIE_NAME setting name. Instead the cookie
name is abritrarily prefixed by "stage-" or "prod-" depending on the
hostname. This seems to be primarily motivated by the definition of
edX.org staging/prod environment hostnames :-(

To resolve this issue, we decided that the actual cookie name was not so
important. Instead, the js code needs to not crash even when the cookie
is absent.

This issue was first reported here:
https://github.com/edx/edx-platform/pull/28170#issuecomment-890449885

Close https://github.com/openedx/build-test-release-wg/issues/104
2021-11-09 11:12:24 -05:00
uzairr
a7d89aae06 feat: make year of birth compliant with coppa
Adds a check to make the UX in compliant with Coppa suggestions.
After this change only users older than 13 years are able to
cascade between their limited and full profile.

Fixes: VAN-753
2021-10-28 16:55:27 +05:00
Waheed Ahmed
d5ab616ca8 feat: COPPA - remove primary/elementary option from education (#29147)
Remove `primary/elementary` option from education field if COPPA compliance
feature flag is enabled. Also, renamed the flag.

VAN-762
2021-10-28 14:12:53 +05:00
Zainab Amir
6019971dd4 feat: put year of birth behind feature flag (#29007) 2021-10-22 12:17:06 +05:00
Attiya Ishaque
7e3985291d feat: [VAN-751] Put user's year of birth behind the feature flag (#29025) 2021-10-22 11:33:01 +05:00
Eugene Dyudyunov
7f40e3aa60 fix: course search sidebar filters (#28708)
Elasticsearch7 returns `aggs` instead of `facets`,
fixed elasticsearch response parsing on the FrontEnd.

YT: https://youtrack.raccoongang.com/issue/RGOeX-413
2021-10-06 11:04:52 -04:00
AsadAzam
208e1b177c feat: Implement program discussions iframe (#28770)
* feat: Implement program discussions iframe

* Fixed conflicts

* Fixed conflicts

* Fixed conflicts

* Refactored code
2021-09-21 16:24:52 +05:00
Ahtisham Shahid
f2c3b5939d feat: Moved Programs details data in respective tabs (#28700)
* feat: Moved Programs details data in respective tabs
2021-09-20 12:38:11 +05:00
edX Transifex Bot
879f0262fd chore(i18n): update translations 2021-09-15 23:39:09 +05:00
edX Transifex Bot
6e9d448a19 chore(i18n): update translations 2021-09-13 02:45:53 +05:00
edX Transifex Bot
15b965c201 fix(i18n): update translations 2021-09-06 02:50:49 +05:00
Zainab Amir
cfc8ab6298 fix: remove edX support URL from login page (#28577) 2021-09-01 11:29:39 +05:00
SaadYousaf
bf64c34d9d feat: add program discussion for learner dashboard 2021-08-31 11:15:44 +05:00
Manjinder Singh
4ff02c50a4 feat: fixing javascript in sandbox (#28565) 2021-08-30 15:41:32 -04:00
Sarina Canelake
31854bd7d7 Merge pull request #28486 from open-craft/shimulch/fix-duplicate-arabic-month
[BB-4649] fix: Duplicate Arabic month
2021-08-25 13:11:58 -04:00
Shimul Chowdhury
0670474beb fix: update localized date test 2021-08-24 09:32:50 +08:00
edX Transifex Bot
11eee8ff5c fix(i18n): update translations 2021-08-24 00:39:21 +05:00
Dillon Dumesnil
09bc2d11e6 fix: Updating the branding/api.py to use unicode copyright
This is really just the change to use the unicode copyright symbol
and then rerunning the pull translations logic (minus the transifex step)
to update the eo files. The other changes were just picked up as part of
running those scripts
2021-08-16 09:43:26 -04:00
edX Transifex Bot
fb161be624 fix(i18n): update translations 2021-08-15 20:47:16 +00:00
Manjinder Singh
f7c5a109d4 Revert "feat: add explicit courserun_key parameter to /event endpoint" (#28410) 2021-08-05 18:05:20 -04:00
kenclary
e14ceaab3f Merge pull request #28333 from edx/TNL-7752
feat: add explicit courserun_key parameter to /event endpoint
2021-08-05 13:59:42 -04:00
Ken Clary
bbb14a2c6a feat: add explicit courserun_key parameter to /event endpoint
We add 'courserun_key' (aka "course_id" though that's technically a
misnomer) as an optional parameter to the /event endpoint url. If it
is not present, it will still be parsed out of the url, if the url is
of the right format.

Additionally, Logger.log() in js adds this parameter to its /event
call, pulling it from the $$course_id global.

This provides opportunity for MFEs to (separately) provide the key
without concern about url parsing.

TNL-7752
2021-08-04 22:47:43 -04:00
mohtamba
30a70d06c2 Fixed spacing on dropdowns 2021-08-04 15:25:02 -04:00
Farhaan Bukhsh
fa5736285e fix: Passwored reset page throwing page not found error (#27982)
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
2021-07-22 09:51:02 -04:00
Albert (AJ) St. Aubin
26678daf1f feat: Add the Request Certificate button to a Course card
[MICROBA-678]

When a certificate is in an unexpected state (i.e. notpassing with a
passing grade) this alert will allow the user to attempt to resolve the
issue on their own. It will run the code that checks the certificates
status. It requires that the course is configured to allow users to
Request Certificates though.
2021-07-15 10:27:18 -04:00
Waheed Ahmed
13270cd733 fix: user info cookie name for Edge (#28170)
We were generating cookie name for only stage and prod, the script
was raising an error on the Edge environment.

VAN-659
2021-07-13 19:18:38 +05:00
Zaman Afzal
843e9ba29b ENT4083: Removed ENABLE_MULTIPLE_USER_ENTERPRISES_FEATURE waffle switch (#28057) 2021-06-30 13:58:11 +05:00
adeelehsan
2e650110c9 activation a11y issue fixed 2021-06-22 21:44:15 +05:00
Justin Hynes
336e4dc7c9 Merge pull request #27990 from edx/jhynes/microba-1179_allowlist
refactor: Rename "whitelist" references to "allowlist" where possible in Instructor Dashboard/Certificates apps
2021-06-22 11:20:42 -04:00
Justin Hynes
205911653b refactor: Rename "whitelist" references to "allowlist" where possible in Instructor Dashboard/Certificates apps
[MICROBA-1179]
- Continue renaming/removal of code referring to the Certificate "white list".

The Certificates Django app `CertificateWhitelist` model is going away in an effort to make our codebase more inclusive. It is being replaced
with the `CertificateAllowlist` model. This PR continues to replace references to the Certificate "whitelist" with "allowlist" wherever
possible. There should be no change in functionality, nor are there any changes in appearance.
2021-06-22 08:18:15 -04:00
Ali-D-Akbar
e17b2abbf4 fix: mishandled xss change 2021-06-21 23:53:41 +05:00
Adeel Ehsan
335a0f28de Merge pull request #27661 from edx/aehsan/VAN-434/account_activation_dialogue_box_added
Account activation popup added
2021-06-10 15:20:15 +05:00
adeelehsan
78f1f1916c Account activation popup added
VAN-434
2021-06-10 14:46:49 +05:00
Adam Stankiewicz
50c8ab2d7b fix: close modal on escape keydown (#27758) 2021-05-28 10:01:12 -04:00
Adam Stankiewicz
31f66a4f2c feat: enterprise learner portal access modal (#27736)
* feat: enterprise learner portal access modal

* fix: quality

* fix: remove log.info
2021-05-27 15:31:27 -04:00
Sameen Fatima
0be941b224 ENT-4095: Handle coupon expiration date scenario in LMS (#27704) 2021-05-24 14:50:34 +05:00
Sameen Fatima
d8b07ebacd Revert "ENT-4095: Handle coupon expiration date scenario in LMS (#27539)" (#27675)
This reverts commit 9f2a72ad08.
2021-05-19 18:06:21 +05:00
Sameen Fatima
9f2a72ad08 ENT-4095: Handle coupon expiration date scenario in LMS (#27539) 2021-05-19 12:47:11 +05:00
Omar Al-Ithawi
64f8c01a92 Remove "edX" from the logout popup message
Not using `settings.PLATFORM_NAME` because sharing it with this script would need too much platform changes for this small error.

Removing the word "edX" makes the statement more accurate for other forks. Generally there shouldn't be any mention of "edX" in the code.
2021-05-12 13:49:38 +03:00
Matt Tuchfarber
4c0f856962 Merge pull request #27562 from edx/tuchfarber/show_course_card_with_cert
feat: Show course enrollment with cert on dash
2021-05-11 10:46:12 -04:00
Alex Dusenbery
4b247013ff feat: account activation now supports a next query param. ENT-4433
This change causes the activation link that’s emailed to a newly-registered user
to utilize a next query parameter. The impetus for this change is an edX Enterprise use-case:
we'd like newly registered Enterprise Customer admins and learners
to be directed to the Enterprise Learner Portal (or Admin Portal) upon account activation.
This is likely a broad enough use case to be valuable in other endeavors.
2021-05-10 12:58:26 -04:00
Matt Tuchfarber
e6e3bade93 feat: Show course enrollment with cert on dash
Previously the programs dashboard picked the first course run enrollment
for a course to display on the dash if the user had multiple. Now it has
a preference for the enrolled course run that earned a certificate if
there is one.
2021-05-07 15:17:32 -04:00
Adeel Ehsan
798b523712 Revert "CTA dialogue added" (#27560) 2021-05-07 16:17:18 +05:00
Adeel Ehsan
03a8dbffb7 Merge pull request #27334 from edx/aehsan/Van-434/cta_dialogue_box_added
CTA dialogue added
2021-05-07 05:42:56 +05:00
adeelehsan
dc306f8f6d CTA dialogue added
VAN-434
2021-05-05 23:29:47 +05:00
dylan-grafmyre
8995f1bf32 fix: prevent a backbone fieldview race condition that can delete user input (#25950)
* prevent a backbone fieldview race condition that can delete user input

eslint for effected

* Fixing quality

* Allow _super in fields.js

* Fixing new issues

* Revert some changes

* Fixing errors, formatting

* Fix bug

* Fix eslint rule allowing _super

* Refactor code

Co-authored-by: Dylan Grafmyre <dylan@opencraft.com>
Co-authored-by: Paulo Viadanna <paulo@opencraft.com>
2021-05-04 12:17:15 -04:00
Matt Tuchfarber
b3e76dc151 fix: Facebook share button on course certificates.
Facebook requires a callback when using the `.ui()` method now. I don't
know when this changed, but the share button is currently broken on
course certificates.

Facebook documentation of the `.ui()` method:
https://developers.facebook.com/docs/javascript/reference/FB.ui/
2021-04-30 13:34:58 -04:00
Ali-D-Akbar
de87916768 refactor: disable xsslint: PROD-2310 2021-04-19 12:37:08 +05:00
Ali-D-Akbar
eb2c369750 refactor: disable xsslint: PROD-2311 2021-04-16 17:13:05 +05:00
Ali Akbar
baa83d77e3 Merge pull request #27337 from edx/aakbar/xss-disable
refactor: disable xss for numerous files
2021-04-15 20:11:39 +05:00