Commit Graph

5781 Commits

Author SHA1 Message Date
Jillian Vogel
c41e7fb93a refactor: deprecate ModuleSystem user attributes in favor of user service
The following ModuleSystem attributes are deprecated by this change, and should be pulled directly from the user service instead:

* anonymous_student_id
* seed
* user_id
* user_is_staff

Related changes:

* Removes the `user` and `anonymous_student_id` parameters from the ModuleService constructor.
* Stores anonymous_user_id in XBlockDjangoUserService's opt_attr
* Pulls out constants used by DjangoXBlockUserService opt_attr so they can be used in the platform code.
* LmsModuleSystem uses the user service created in wrapper function for runtime.publish to avoid requiring the user
  service to be "needed" by all XBlocks.
* LmsModuleSystem no longer checks for instances of XModuleDescriptor when deciding what kind of anonymous_user_id to
  provide:  all XModules are XBlocks, so this check is unnecessary.
* XBlockRuntime returns a user service when requested
* Adds tests for deprecated ModuleSystem attributes and changes to XBlockDjangoUserService.
2021-09-23 11:41:43 +09:30
Felipe Montoya
dbb4658819 Merge pull request #28640 from eduNEXT/MJG/2nd_batch_openedx_events
[BD-32] feat: add 2nd batch of Open edX Events
2021-09-22 14:12:06 -05:00
Phillip Shiu
6d7dcef8d6 fix: correct typo, content is locked, not lost (#28802) 2021-09-21 09:49:55 -04:00
Sarina Canelake
c699923d03 Merge pull request #28628 from edx/sarina/i18n-tuneup
fix: abstract edX-specific strings
2021-09-21 08:57:58 -04:00
julianajlk
42d79c5ef5 fix: get correct root URL for Track Selection page (#28772)
REV-2387
2021-09-20 09:56:42 -04:00
sarina
0c74d347f7 fix: abstract edX-specific strings 2021-09-19 14:01:20 -04:00
Jawayria
60f8bb0053 Merge pull request #28706 from edx/jawayria/bom-2784
fix: Updated the error message in test_bulk_change_enrollment
2021-09-16 17:02:02 +05:00
Phillip Shiu
b6e79c6dc8 fix: review comments on names and link variables 2021-09-15 15:20:23 -04:00
Maria Grimaldi
1c447e6176 feat: add 2nd batch of Open edX Events
* Add COURSE_ENROLLMENT_CHANGED: sent after the enrollment update
* Add COURSE_UNENROLLMENT_COMPLETED: sent after the user's unenrollment
* Add CERTIFICATE_CREATED after the user's certificate generation has
been completed
* Add CERTIFICATE_CHANGED: after the certification update has been
completed
* Add CERTIFICATE_REVOKED: after the certificate revocation has been
completed
* Add COHORT_MEMBERSHIP_CHANGED: when a cohort membership update ends
2021-09-15 14:50:28 -04:00
Phillip Shiu
8e0f7920bf style: fix pycodestyle issues 2021-09-15 13:09:27 -04:00
Phillip Shiu
09809f322e fix: add unit test
Pulled from @julianajlk's WIP, thank you!
2021-09-15 12:14:39 -04:00
Phillip Shiu
9d259d7a99 refactor: remove folder track_selection_types 2021-09-15 12:08:21 -04:00
Phillip Shiu
5cf419b9f6 refactor: add _redirect_to_course_or_dashboard 2021-09-15 12:08:20 -04:00
Phillip Shiu
2997e23f83 refactor: s/full_fbe/fbe, s/partial_fbe/unfbe + unfbe logic 2021-09-15 12:08:20 -04:00
Phillip Shiu
830878729d style: chop long lines 2021-09-15 12:08:20 -04:00
Phillip Shiu
1bafc0ff27 fix: remove check for verified - already performed earlier 2021-09-15 12:08:20 -04:00
Phillip Shiu
a8e841f523 fix: add track selection redirection for partial_fbe.html 2021-09-15 12:08:20 -04:00
Phillip Shiu
359f3cf3f6 fix: add partial_fbe.html 2021-09-15 12:08:20 -04:00
Phillip Shiu
2e5b922692 fix: abstract track selection bullets into new mako template 2021-09-15 12:08:08 -04:00
julianajlk
519872a993 feat: add SVGs for icons in Track Selection, refactor URLs and tests (#28701)
REV-2133
2021-09-15 09:37:31 -04:00
Shafqat Farhan
39ee98420a fix: VAN-474 - Deleted cookie for activation popup 2021-09-15 13:56:53 +05:00
Farhaan Bukhsh
48ad7effb1 feat: grant course/library creation rights by organization (#26616)
Current State (before this commit):

  Studio, as of today doesn't have a way to restrict a user to
  create a course in a particular organization. What Studio
  provides right now is a CourseCreator permission which gives
  an Admin the power to grant a user the permission to create
  a course.

  For example: If the Admin has given a user Spiderman the
  permission to create courses, Spiderman can now create courses
  in any organization i.e Marvel as well as DC.
  There is no way to restrict Spiderman from creating courses
  under DC.

Purpose of this commit:

  The changes done here gives Admin the ability to restrict a
  user on an Organization level from creating courses via the
  Course Creators section of the Studio Django administration
  panel.

  For example: Now, the Admin can give the user Spiderman the
  privilege of creating courses only under Marvel organization.
  The moment Spiderman tries to create a course under some
  other organization(i.e DC), Studio will show an error message.

  This change is available to all Studio instances that
  enable the FEATURES['ENABLE_CREATOR_GROUP'] flag.
  Regardless of the flag, it will not affect any instances that choose
  not to use it.

BB-3622
2021-09-10 12:43:26 -04:00
Jawayria
563f0a8462 fixed quality 2021-09-10 16:58:13 +05:00
Jawayria
06be2cfccd fix: Updated the error message in test_bulk_change_enrollment 2021-09-10 15:43:28 +05:00
Bianca Severino
bdc8653cca fix: use pending name change in IDV post_save signal 2021-09-08 12:25:29 -04:00
Zainab Amir
bf76fb3f7f move send_activation_email celery task (#28666)
- moved send_activation_email to user_authn app
- registered task under both new and old name
- exposed the old name for task invocation

VAN-417
2021-09-08 10:44:54 +05:00
Jawayria
e6ce376105 Merge pull request #28654 from edx/jawayria/bom-2766
chore: Removed django.utils.six as not supported in Django3
2021-09-07 18:06:53 +05:00
Syed Muhammad Dawoud Sheraz Ali
ea6cd613fd Merge pull request #28643 from edx/dsheraz/PROD-2447
refactor: move course location util to common djangoapp instead of xm…
2021-09-03 19:28:26 +05:00
Jawayria
506d61101f chore: Removed django.utils.six as not supported in Django3 2021-09-03 19:18:36 +05:00
Usama Sadiq
d075fc8033 fix: remove the created flag for user profile creation (#28645) 2021-09-03 16:29:00 +05:00
DawoudSheraz
e986d360c9 refactor: move course location util to common djangoapp instead of xmodule 2021-09-03 12:40:28 +05:00
Bianca Severino
2497adf22b Merge pull request #28546 from edx/bseverino/pending-name-change
[MST-803] Update account API to allow pending name changes
2021-09-02 14:45:00 -04:00
mariagrimaldi
c0618592d2 feat: add 1st batch of Open edX events
* Add STUDENT_REGISTRATION_COMPLETED event after the user's registration
* Add SESSION_LOGIN_COMPLETED event after the user's login session
* Add COURSE_ENROLLMENT_CREATED event after the user's enrollment creation
2021-09-02 10:05:23 -04:00
Usama Sadiq
fe20509d4e fix: Remove deprecated django.utils.decorator.available_attrs (#28597) 2021-09-02 12:12:01 +05:00
Bianca Severino
65905a01ec feat: update account API to allow pending name changes 2021-09-01 11:26:43 -04:00
Jhony Avella
95a6abcd1f revert: removing read_committed argument from outer_atomic function (#28161)
In the PR https://github.com/edx/edx-platform/pull/10659 the outer_atomic decorator/context manager was created to prevent nested atomic blocks. This method received a boolean parameter read_committed to enforce read-committed MySQL isolation level. From Django 2, the default isolation level Django sets is read-committed, so the aforementioned parameter for outer_atomic can be removed
2021-08-31 16:39:35 -04:00
Felipe Montoya
6e48ffd9f6 Merge pull request #28547 from eduNEXT/MJG/fix_missing_profile_for_tests
refactor: replace User.objects.create_user for UserFactory p2
2021-08-30 10:33:29 -05:00
Maria Grimaldi
54627e1101 refactor: replace User for UserFactory and its methods
This change is done so the profile is automatically created for tests users
2021-08-30 11:03:49 -04:00
Régis Behmo
6b1700803c fix: Milestones app feature flag docs
The feature flag that should be set is not ENABLE_MILESTONES_APP but
MILESTONES_APP.
2021-08-30 16:40:48 +02:00
Usama Sadiq
cde050618e build: Moved user and group management commands and unit tests to edx-django-utils
- Removed manage_user and manage_group commands and their unit tests from edx-platform and added then to edx-django-utils.
- Modified User.post_save signal to ensure the user profile is created when manage_user management command is run to create a user.
- Added edx-django-utils to INSTALLED_APPS for LMS and Studio.
- Moved generate_password from openedx.core.djangoapps.user_authn.utils to edx_django_utils.user along with its unit test.
2021-08-30 12:03:37 +05:00
julianajlk
646245508a fix: format audit deadline in Track Selection (#28558)
REV-2133
2021-08-27 13:45:03 -04:00
julianajlk
f427828361 Update waffle flag for Value Prop Track Selection (#28536)
REV-2133
2021-08-25 13:26:40 -04:00
Maria Grimaldi
2ee52ea96c refactor: replace some create_user with UserFactory to avoid non-existent profile errors 2021-08-24 15:49:21 -04:00
julianajlk
572965b742 Add waffle flag settings for new Track Selection template (#28523)
REV-2133
2021-08-24 13:02:30 -04:00
julianajlk
32d17c8810 Add audit_access_deadline to context and connect Value Prop Track Selection template (#28373)
REV-2133
2021-08-20 15:36:18 -04:00
Andy Shultz
97a5094efc chore: bump name affirmation to complete column removal
This is the last PR removing verified name is_verified,
so we can bring back the test.
2021-08-18 12:49:01 -04:00
Andy Shultz
9e05538573 chore: update 2/3 of proctoring library for is_verified removal
This update removes the field, but not yet the column, so it
includes the test skip.

MST-969
2021-08-18 09:31:52 -04:00
Ken Clary
8c8450f6dc feat: add explicit courserun_key parameter to /event endpoint
We add 'courserun_key' (aka "course_id" though that's technically a
misnomer) as an optional parameter to the /event endpoint url. If it
is not present, it will still be parsed out of the url, if the url is
of the right format.

Additionally, Logger.log() in js adds this parameter to its /event
call, pulling it from the $$course_id global.

This provides opportunity for MFEs to (separately) provide the key
without concern about url parsing.

TNL-7752
2021-08-11 14:40:25 -04:00
Thomas Tracy
af82c6270a MB-1192: [feat] Add course ended, not passing (#28438)
* MB-1192: [feat] Add course ended, not passing

If a student has not passed a course, the course has ended, and they have a verified seat, we want to show them a message at a glance on the
dashboard.
2021-08-11 11:35:15 -04:00
Matt Tuchfarber
d53d8e45a5 refactor: Merge the openedx certs app with lms one (#28435)
* refactor: Merge the openedx certs app with lms one

Move the certs API from openedx into the lms certificates app.
Functionally, this is a no-op. Cleanup will happen in a subsequent
commit. This is simply a move.
2021-08-11 10:25:55 -04:00