Commit Graph

66543 Commits

Author SHA1 Message Date
Kyle McCormick
dfa60a5e92 docs: update sys.path hacks ADR & add upgrade guide
The timeline of the import_shims removal has evolved
over time; notably, we are keeping the import_shims
in Lilac in order to make any lingering old-style
import paths obvious to operators.

Update the ADR to reflect this. Also, add a table
mapping old import paths to new ones.
2021-03-08 12:49:31 -05:00
Kyle McCormick
2b5d916512 refactor!: deprecated import paths now always raise
Previously, deprecated [lms|cms|common]/djangoapps
import paths would only raise errors if the
ERROR_ON_DEPRECATED_EDX_PLATFORM_IMPORTS
flag, which defaulted to False (but is overriden
to True for Devstack and *.edx.org), was enabled.

This change removes that setting and always raises
on use those deprecated import paths.
2021-03-08 12:49:31 -05:00
Raul Gallegos
e1614b5324 fix: revert back the bundle_draft_files cache key (#26897)
Changes the LMS/Studio bundle cache key,
thus invalidating all 47hr-TTL entries
in favor of new 50min-TTL entries.

TNL-7771
2021-03-08 12:34:51 -05:00
Awais Qureshi
a980145164 BOM-2375-student-part1
pyupgrade in student app.
2021-03-08 22:21:37 +05:00
edX cache uploader bot
aecf6f1d51 Updating Bokchoy testing database cache (#26896) 2021-03-08 21:04:33 +05:00
Jayram Nai
6848705f5c docs: add annotations for ENABLE_DISCUSSION_HOME_PANEL feature flag 2021-03-08 20:59:21 +05:30
Sarina Canelake
3cbf7d80f1 Merge pull request #26106 from open-craft/mavidser/se-3685-hide-help-link
Add option to disable the help link in the navbar
2021-03-08 10:24:30 -05:00
Jeremy Bowman
1692081dd0 Fix diff-cover with recent git versions on shallow repositories (#26879)
When we tried upgrading Jenkins workers from Ubuntu 16.04 to 20.04, `diff-cover` started silently failing with a return code of `1`.  We suspect this is due to https://github.com/Bachmann1234/diff_cover/issues/153 , so we're adding the workaround described in that ticket.
2021-03-08 10:23:50 -05:00
Adeel Ehsan
5fcf88f31e Merge pull request #26869 from edx/aehsan/van-390/datetimestamp_added_for_account_activation_event
datetimestamp added for account activation event
2021-03-08 19:59:43 +05:00
alangsto
e3099bc486 Update edx-proctoring version (#26895) 2021-03-08 09:22:37 -05:00
Jason Myatt
6e743bc41a Merge pull request #25941 from open-craft/mtyaka/SE-2888-forum-notification-url
Fix URL in forum notification post.
2021-03-08 09:13:20 -05:00
Kyle McCormick
f54e3752fa fix: lower bundle cache timeout from 47hrs to 50mins (#26863)
S3 URLs served by Blockstore have a max TTL of
1hr, since the temporary credentials the Blockstore
uses to sign the URLs themselves have a TTL of
1hr. Thus, we must cache Blockstore bundles for
less than 1hr.

TNL-7771
2021-03-08 08:47:30 -05:00
Awais Qureshi
8168a3a322 Merge pull request #26673 from edx/BOM-2374-pipelinemako
Run Pyupgrade on pipeline mako.
2021-03-08 18:39:32 +05:00
Awais Qureshi
6832c95d8e Merge pull request #26706 from edx/BOM-2376-terrain
Run Pyupgrade on terrain
2021-03-08 18:38:19 +05:00
Awais Qureshi
2dcaf9d5a6 BOM-2375-student-part1
pyupgrade in student app.
2021-03-08 18:29:25 +05:00
Zainab Amir
a39befb548 VAN-113: Add error code for registration workflow (#26821) 2021-03-08 18:09:26 +05:00
Matthew Piatetsky
b8da9fb59b Merge pull request #26868 from edx/AA-461
[AA-461] Add temporary debugging logs to determine why the highlights export is not working
2021-03-08 07:01:50 -05:00
Awais Qureshi
6b4bed37a3 BOM-2442
pyupgrade in calendar-sync.
2021-03-08 13:24:16 +05:00
Awais Qureshi
d0ed3ee942 BOM-2442
pyupgrade in calendar-sync.
2021-03-08 13:13:52 +05:00
Awais Qureshi
32601c1a39 BOM-2442
pyupgrade in announcements.
2021-03-08 12:58:04 +05:00
edX requirements bot
311c30aa69 Updating Python Requirements (#26886) 2021-03-08 12:41:55 +05:00
Matjaz Gregoric
6204e5bcec Fix URL in forum notification post.
urljoin('my.domain.com', '/my/path') returns '/my/path'. We have to make
sure to use the full base url (starting with http(s)://) and not just
the site's domain.
2021-03-08 08:32:13 +01:00
adeelehsan
4d24f4c005 datetimestamp added for account activation event
VAN-390
2021-03-08 11:29:58 +05:00
Michael Roytman
66f0f9891f feat: This upgrades the version of edx-proctoring library to 3.7.6. This includes a fix to a bug that prevented course staff members from marking proctored exam attempts as ready_to_resume. The bug was that the course ID was being incorrectly determined by the StudentProctoredExamAttempt PUT handler. (#26880) 2021-03-05 19:50:17 -05:00
Nathan Sprenkle
e5c9ba183a fix: add missing ORA hooks for some response areas (#26875) 2021-03-05 15:40:42 -05:00
Matthew Piatetsky
b46da1a7c1 Add temporary debugging logs to determine why the highlights export is not working 2021-03-05 10:23:35 -05:00
Awais Qureshi
f1f1933ab4 BOM-2374
Run Pyupgrade on edxmako.
2021-03-05 18:17:41 +05:00
Kyle McCormick
9aefd6f986 style: django-not-configured is not a sensible lint-amnesty value (#26862)
django-not-configured is an error raised by pylint (with
the pylint-django plugin) when it's not correctly configured.

We should not be applying lint amnesty for such a violation.
2021-03-05 08:11:58 -05:00
Justin Hynes
8155190511 Merge pull request #26857 from edx/jhynes/microba-1038_fix-removal-bug
MICROBA-1038 | Don't check enrollment status when removing allowlist entries
2021-03-05 08:02:03 -05:00
Ali-D-Akbar
7aa5e27201 fix override error message 2021-03-05 17:27:56 +05:00
Awais Qureshi
875a06d2fc Merge pull request #26674 from edx/BOM-2373-course_action_state
Run Pyupgrade on course-action-state.
2021-03-05 17:24:13 +05:00
Matthew Piatetsky
013f7bfe34 Merge pull request #26744 from edx/AA-461
[AA-461] Export highlights to s3 for use by braze
2021-03-05 06:46:57 -05:00
M. Zulqarnain
e35d3de376 refactor: pyupgrade on docs & pavelib (#26768) 2021-03-05 15:24:59 +05:00
M. Zulqarnain
41e5403f4e BOM-2369 (D): pyupgrade on contentstore/views (#26767)
* pyupgrade on contentstore/views

* Apply suggestions from code review

Co-authored-by: Usama Sadiq <usama.sadiq@arbisoft.com>

Co-authored-by: Usama Sadiq <usama.sadiq@arbisoft.com>
2021-03-05 14:55:14 +05:00
edX requirements bot
efe4041ef7 Updating Python Requirements (#26864) 2021-03-05 14:17:27 +05:00
edX cache uploader bot
39b9099cdf Updating Bokchoy testing database cache (#26861) 2021-03-05 14:14:42 +05:00
Sid Verma
e66b9e7fff Add option to disable the help link 2021-03-05 08:36:28 +05:30
Braden MacDonald
7a14c87865 Merge pull request #26535 from edx/ziafazal/annotations_ENABLE_ANNOUNCEMENTS
[TSD] Added annotations for ENABLE_ANNOUNCEMENTS feature flag
2021-03-04 15:15:45 -08:00
Matt Tuchfarber
7f1c5023cd Merge pull request #26841 from edx/tuchfarber/fix_race_condition_cert_date
Move cert date signals to avoid race conditions
2021-03-04 17:40:50 -05:00
edx-abolger
c26b29d5d6 Merge pull request #26858 from edx/edx-abolger/ent-4262-enterprise-version-bump
Bumping edx-enterprise requirements to 3.17.47
2021-03-04 16:48:15 -05:00
Simon Chen
c729502b14 MST-686 Update the IDV approval email to say our IDV is now valid for 2 years (#26859) 2021-03-04 16:25:42 -05:00
Matthew Piatetsky
8d1d7b2222 feat: Export highlights to s3 for use by braze
Things other than highlights may be exported in the future. The storage class is flexible so backends other than s3 may be used in the future.
AA-461
2021-03-04 15:57:30 -05:00
Matt Tuchfarber
6c97dfe1e5 Move cert date signals to avoid race conditions
COURSE_CERT_DATE_CHANGE was being called before saving the new data in
the course overview. The listeners were expecting to pull the data out
of the course overview, and thus were only right about half the time.
This moves the signal to trigger after the course publish signals are
handled.
2021-03-04 15:57:21 -05:00
Adrienne Bolger
20637d16fa edx-enterprise version bump 2021-03-04 14:26:04 -05:00
Justin Hynes
a3a05bc440 MICROBA-1038 | Don't check enrollment status when removing allowlist entries
[MICROBA-1038]
- Today, we check if a learner is actively enrolled in a course-run before we add or remove them from the Instructor Dashboard allow list. We ran into an issue where we couldn't remove an entry from the list because the learner is no longer actively enrolled in the course-run. Update instructor dashboard logic to only check enrollment status when _adding_ a learner to the allow list.
2021-03-04 13:44:45 -05:00
Felipe Montoya
b98bcb19e4 Merge pull request #26809 from jramnai/tsd-enable_cookie_consent2
[TSD] add annotaions for ENABLE_COOKIE_CONSENT feature flag
2021-03-04 12:19:29 -05:00
Jawayria
2b943d93eb Merge pull request #26537 from edx/jawayria/bom-2352-2
BOM-2352: Removed unused imports from lms/djangoapps/{certificates, c…
2021-03-04 20:40:36 +05:00
Jawayria
bf9e498be7 Merge pull request #26536 from edx/jawayria/bom-2352-1
BOM-2352: Removed unused imports from lms/djangoapps/{badges, brandin…
2021-03-04 20:39:23 +05:00
Jawayria
c5e5b307b5 Merge pull request #26507 from edx/jawayria/bom-2351-6
BOM-2351: Removed unused imports from common/lib/xmodule
2021-03-04 20:36:46 +05:00
Carla Duarte
368df80c05 Merge pull request #26838 from edx/ciduarte/AA-517
AA-517: fix duplicate IDs in MessageBannerView
2021-03-04 09:46:26 -05:00