Commit Graph

30 Commits

Author SHA1 Message Date
Ahtisham Shahid
db0b5adc69 fix: resolved issues with ses impl in goal reminder email (#36233) 2025-02-12 11:33:25 +05:00
Usama Sadiq
1a16073ad0 fix: enable pylint warnings (#36196) 2025-02-03 14:18:11 +05:00
Ahtisham Shahid
46c7f6db52 fix: bypass edx ace for sending goal reminder email using ses (#36148) 2025-01-27 12:07:29 +05:00
Ahtisham Shahid
953140aa1b fix: resolved edx.course.goal.email.filtered parsing error (#36059) 2024-12-26 14:34:46 +05:00
Ahtisham Shahid
e2a4b9e524 fix: updated goal reminder email time logger (#36045) 2024-12-18 15:38:05 +05:00
Ahtisham Shahid
d88fa76d52 chore: added logs for goal reminder email (#35958) 2024-12-12 13:25:47 +05:00
Fatima Sohail
f0c94cda13 feat: improved logging and tracking for goal reminder email (#35780)
* feat: improved logging and tracking for goal reminder email

* feat: updated base exception tracking
2024-11-08 01:40:03 +05:00
Fatima Sohail
af69cbe671 feat: waffle flag based switch to ses for goal reminder email (#35615)
* feat: waffle based switch to ses for goal reminder email

* test: added test cases for ace message parameters

* feat: updated logic to specify channel name

* chore: update edx-ace version
2024-10-14 19:20:02 +05:00
Muhammad Adeel Tajamul
f8bf592483 fix: added course_id in email sent event (#35422) 2024-09-05 15:01:43 +05:00
Andy Shultz
f2f71516bc fix: when making a hasty exit from goals, make sure to get the log out 2022-12-20 09:22:48 -05:00
Andy Shultz
646c5c7fbd fix: mail goals during the whole day, not just the morning
Goal mail jobs can easily take 4 hours to run and sometimes
fail. Restricting the allowable mail window to three morning hours
only means many goal mails will be missed.

Extend the window to the whole day so that mails are actually sent. It
will still prefer to send mail in the morning because that is the
first time it could encounter the goal and it will mark it as sent
afterwards.
2022-12-13 15:42:12 -05:00
Andy Shultz
0de55deff5 fix: intial chatty goals is a bit too chatty
it takes 20-30s to run through 1000 goals so this logs too often to
read in splunk. Every 10000 will be every few minutes.
2022-12-07 09:40:39 -05:00
Andy Shultz
08ead3ba01 fix: course goals email command logs more progress info 2022-12-06 10:56:25 -05:00
Andy Shultz
85ca6ad5ec fix: catch even base exceptions when exiting
prior exception catch is not triggering in cases where the job blows up,
there is one more level of exception available to catch and print
2022-12-05 10:41:17 -05:00
Andy Shultz
5ff9b73da3 fix: wrap course goals email handle to report on errors
currently this is failing many runs but the exception information is
lost at some higher level. Report on it immediately.
2022-11-30 10:55:02 -05:00
Andy Shultz
686b586ab1 fix: after failing to get course, stop trying to make a course message
we were failing to get the course and then going on to try course.field
which would generate a worse exception

also wraps the email send in an exception absorb because a single email
can fail to send for infinitely many boring reasons
2022-11-18 15:56:38 -05:00
Chris Deery
dddcadb706 feat: [AA-922] remove deprecated Goals backend (#29705)
* feat: [AA-922] remove deprecated Goals backend

While the new Weekly Learning Goals were being rolled out, the previous goal setting feature still existed behind a waffle flag.
The Weekly Learning Goals now become the one and only learning goal feature.

This change does not remove the old goals feature from the legacy backend, and therefore it does not remove any of the data that was used by the old goals feature.
The goals are now driven by the single pre-existing Waffle flag ENABLE_COURSE_GOALS

 - Removed COURSE_GOALS_NUMBER_OF_DAYS_GOALS waffle flag, replacing it where needed with the existing ENABLE_COURSE_GOALS

 - modified the API to remove the old goal_options, keeping the redundant weekly_learning_goal_enabled flag

 - updated tests

 - refactor tests to fit 50 line limit in lint
2022-01-11 09:02:03 -05:00
Jawayria
826fc33274 chore: Applied lint-amnesty on lms/djangoapps/{certificates, course_goals} 2021-12-17 16:16:51 +05:00
Matt Hughes
a92f372a3e fix: redirect behavior to learner-specific progress pages
JIRA:AU-375
2021-12-13 15:52:00 -05:00
Matthew Piatetsky
22cb639919 feat: Update ace email header to match braze email header (#29310) 2021-11-15 10:44:41 -05:00
Matthew Piatetsky
4822faccc4 [AA-910] Miscellaneous UI fixes and fixed unsubscribe link (#29288)
* fix: use pngs for the goal reminder email banner and remove redundant unsubscribe link

* fix: update

* fix: Miscellaneous UI fixes and fixed unsubscribe link
2021-11-09 13:56:12 -05:00
Matthew Piatetsky
3c0d824701 fix: use pngs for the goal reminder email banner and remove redundant unsubscribe link from the email (#29215)
* fix: use pngs for the goal reminder email banner and remove redundant unsubscribe link

* fix: update
2021-11-09 09:24:58 -05:00
Matthew Piatetsky
4583b639e6 fix: change svg to png and other email fixes (#29145) 2021-10-29 15:12:36 -04:00
Matthew Piatetsky
1a8d322e71 fix: make goal reminder email transactional (#29134) 2021-10-29 14:30:30 -04:00
Matthew Piatetsky
ec7205e679 fix: update goal reminder email urls (#29133) 2021-10-27 13:49:28 -04:00
Matthew Piatetsky
e0d2cda697 fix: ensure goal reminder command respects flag cofiguration of individual users (#29071) 2021-10-20 15:03:38 -04:00
Matthew Piatetsky
449d5c7a2d feat: only email users about their goal in the morning in their timezone (#28922) 2021-10-06 15:02:03 -04:00
Matthew Piatetsky
caec8f6f29 [AA-909] Create goal reminder email (#28822)
* feat: Create goal reminder email in ace

* creating email
2021-09-30 11:53:14 -04:00
Michael Terry
ce39f52680 chore: add tests for new goal reminder email management command 2021-09-20 14:32:06 -04:00
Dillon Dumesnil
659283d0fd feat: AA-908: Add goal reminder email management command 2021-09-15 17:44:28 -04:00