Commit Graph

58450 Commits

Author SHA1 Message Date
Matt Tuchfarber
6c97dfe1e5 Move cert date signals to avoid race conditions
COURSE_CERT_DATE_CHANGE was being called before saving the new data in
the course overview. The listeners were expecting to pull the data out
of the course overview, and thus were only right about half the time.
This moves the signal to trigger after the course publish signals are
handled.
2021-03-04 15:57:21 -05:00
Adrienne Bolger
20637d16fa edx-enterprise version bump 2021-03-04 14:26:04 -05:00
Justin Hynes
a3a05bc440 MICROBA-1038 | Don't check enrollment status when removing allowlist entries
[MICROBA-1038]
- Today, we check if a learner is actively enrolled in a course-run before we add or remove them from the Instructor Dashboard allow list. We ran into an issue where we couldn't remove an entry from the list because the learner is no longer actively enrolled in the course-run. Update instructor dashboard logic to only check enrollment status when _adding_ a learner to the allow list.
2021-03-04 13:44:45 -05:00
Felipe Montoya
b98bcb19e4 Merge pull request #26809 from jramnai/tsd-enable_cookie_consent2
[TSD] add annotaions for ENABLE_COOKIE_CONSENT feature flag
2021-03-04 12:19:29 -05:00
Jawayria
2b943d93eb Merge pull request #26537 from edx/jawayria/bom-2352-2
BOM-2352: Removed unused imports from lms/djangoapps/{certificates, c…
2021-03-04 20:40:36 +05:00
Jawayria
bf9e498be7 Merge pull request #26536 from edx/jawayria/bom-2352-1
BOM-2352: Removed unused imports from lms/djangoapps/{badges, brandin…
2021-03-04 20:39:23 +05:00
Jawayria
c5e5b307b5 Merge pull request #26507 from edx/jawayria/bom-2351-6
BOM-2351: Removed unused imports from common/lib/xmodule
2021-03-04 20:36:46 +05:00
Carla Duarte
368df80c05 Merge pull request #26838 from edx/ciduarte/AA-517
AA-517: fix duplicate IDs in MessageBannerView
2021-03-04 09:46:26 -05:00
Christie Rice
8c2ce91a15 MICROBA-1033 Remove temporary id verification code. Require users to have a current id verification. (#26834) 2021-03-04 09:08:56 -05:00
adeel khan
18aa50ec0f Merge pull request #26853 from edx/adeel/van_178_change_shadow_box_background_color
Change email shadow box color
2021-03-04 18:55:53 +05:00
adeel khan
cd848bf33c Merge pull request #26850 from edx/adeel/van_177_reduce_top_padding
Reduce top padding by half for emails
2021-03-04 18:23:13 +05:00
Adeel Khan
416546791d Change email shadow box color
VAN-178
2021-03-04 18:18:32 +05:00
Adeel Khan
883fffd2c6 Reduce top padding by half for emails
VAN-177
2021-03-04 17:28:41 +05:00
zia.fazal@arbisoft.com
d45d978aab Added annotations for ENABLE_ANNOUNCEMENTS feature flag
fixed quality violations

Changed indentation
2021-03-04 16:44:40 +05:00
Usama Sadiq
519384edca refactor: ran pyupgrade on lms/djangoapps (#26733)
ran pyupgrade on bulk_enroll & ccx apps.
2021-03-04 16:00:19 +05:00
Awais Jibran
ce0fc3804d refactor: use q objects when fetching user using an identifier #26683 (#26823) 2021-03-04 15:16:54 +05:00
M. Zulqarnain
5562944e87 BOM-2369 (A): pyupgrade on api,contentstore and cms_user_tasks apps under CMS (#26676)
* pyupgrade on cms api,contentstore and cms_user_tasks apps
2021-03-04 15:06:07 +05:00
Usama Sadiq
a8449334af refac: ran pyupgrade on lms/djangoapps/branding (#26730) 2021-03-04 14:42:42 +05:00
M. Zulqarnain
fa271dafe9 BOM-2369 (C): pyupgrade on contentstore/tests (#26759)
* pyupgrade on contentstore/tests
2021-03-04 14:37:39 +05:00
M. Zulqarnain
da970bf215 BOM-2369 (B): Pyupgrade on contentstore/management (#26758)
* pyupgrade on contentstore/management
2021-03-04 14:31:10 +05:00
adeel khan
32fd2407e3 Merge pull request #26819 from edx/adeel/van_274_fix_password_reset_button_style
Make button style primary
2021-03-04 10:59:54 +05:00
Adeel Khan
231dd68f90 Make button style primary
VAN-274
2021-03-04 07:50:09 +05:00
Carla Duarte
5868e3aef8 AA-517: fix duplicate IDs in MessageBannerView 2021-03-03 16:29:11 -05:00
Simon Chen
2b4b53d36f MST-669 bump up the version of edx-proctoring for new 'other_course_approved' proctoring status on Student Onboarding Status panel (#26839) 2021-03-03 16:27:53 -05:00
Justin Hynes
c658c7e0e6 Merge pull request #26836 from edx/jhynes/mb-1023_bugfix
MB-1023 | Fix defect when removing allowlist entry on instructor dashboard
2021-03-03 14:02:05 -05:00
Awais Qureshi
0fac7e7743 Merge pull request #26808 from open-craft/symbolist/fix-common-tests
Fix running tests in common/lib.
2021-03-03 23:50:01 +05:00
Justin Hynes
05c82810e0 MB-1023 | Fix defect when removing allowlist entry on instructor dashboard
[MB-1023]
- Fix issue from recent refactor. Verify certificate is not none before attempting to invalidate the certificate.
- Add more logging
2021-03-03 13:14:01 -05:00
Aarif
059d683441 Constrained diff-cover to fix upgrade job (#26830) 2021-03-03 23:04:41 +05:00
Matt Tuchfarber
30203c9e45 Merge pull request #26833 from edx/tuchfarber/add_credentials_username_to_cms
Add credentials service username to common cms
2021-03-03 12:26:46 -05:00
Matt Tuchfarber
0feeaaf817 Add credentials service username to common cms
We're now calling programs-related code from CMS so we need to have the
username for the credentials service available in CMS
2021-03-03 11:46:32 -05:00
Christie Rice
1b1781247c MICROBA-1032 Remove command in favor of querying the db for more detailed info (#26787) 2021-03-03 09:33:21 -05:00
Sarina Canelake
e15e372233 Merge pull request #26772 from edx/sarina/DEPR-142-TNL-7522
Remove the "role of users being enrolled" field from Instructor Dashboard
2021-03-03 08:57:16 -05:00
Usman Khalid
0e7664fbce test: Fix failing pytest asserts in GradesheetTest.test_weighted_grading. 2021-03-03 18:49:01 +05:00
Usman Khalid
8a8dbee340 test: Fix assertstore and modulestore tests failing because of missing equality functions.
https://github.com/edx/edx-platform/pull/26530 updated the tests to use pytest
assertions instead of unittest assertionss. However, some tests depended on custom
equality functions being set up in the test classes. These tests have been updated
to explicitly do the needed comparisons.
2021-03-03 18:49:01 +05:00
jawad khan
948d6351b6 LEARNER-8251 - Added BearerAuthenticationAllowInactiveUser in courseware view (#26829)
Added BearerAuthenticationAllowInactiveUser in courseware view
2021-03-03 18:39:42 +05:00
Justin Hynes
251a9e74d6 Merge pull request #26799 from edx/jhynes/mb-908_move_checks_to_cert_djangoapp
MICROBA-1024 | Move checks to certificates app
2021-03-03 07:31:58 -05:00
Usman Khalid
f35eed4e4c test: Fix test_capa_module.py::ProblemBlockTest::test_demand_hint_logging. 2021-03-03 16:39:34 +05:00
Azan Bin Zahid
936f19fa12 Merge pull request #26797 from edx/azan/PROD-2281
add user id (staff only) field in user_api
2021-03-03 15:22:27 +05:00
Jawayria
097613e8b9 BOM-2351: Removed unused imports from common/lib/xmodule 2021-03-03 14:33:54 +05:00
azanbinzahid
0ef2ba7e7c add lms user id in accounts endpoint 2021-03-03 14:27:44 +05:00
jawad khan
787649ba81 LEARNER-8158 - Fixed descendants typo and added tests
LEARNER-8158 
Fixed descendants typo and added tests
2021-03-03 11:38:34 +05:00
Awais Jibran
589716144c refactor: use q objects when fetching user using an identifier (#26726)
* refactor: use q objects when fetching user using an identifier #26683

* Nit
2021-03-03 10:45:48 +05:00
Michael Roytman
eb98d7fac5 MST-675: QuerySet Performance for StudentOnboardingStatusByCourse Endpoint (#26789)
* The original use of user.has_perm('can_take_proctored_exam') in the get_active_enrollments_for_course method had very poor performance when used for multiple learners. The permission is not designed for use in bulk operations. It was being called for each user in a loop by edx-proctoring, resulting in many queries to the database. This lead to timeouts on the client. This change exposes a new service endpoint that performs this permission checking in the database, resulting in one single query to the necessary LMS SQL tables and many fewer queries to the modulestore.

* bump version of edx-proctoring to 3.7.3
2021-03-02 19:46:58 -05:00
Michael Terry
877e8f1e83 Merge pull request #26803 from edx/mikix/nudge2
feat: add 'external course updates' experiment flag
2021-03-02 15:46:54 -05:00
Usman Khalid
7441702ade test: The exception on the pytest ExceptionInfo object can be accessed on the value attribute. 2021-03-03 01:03:36 +05:00
Justin Hynes
07837cf54e MICROBA-1024 | Move the allowlist and blocklist checks to certificates app
[MICROBA-1024]
- Move some of the recently added logic from the instructor app to the certificates app
- Attempt to not use other certificate models directly in the code I am touching, moving this logic to certificates as well.
2021-03-02 14:58:20 -05:00
Michael Terry
9570c1c72b feat: add 'external course updates' experiment flag
When this flag is enabled, users will be 50/50 bucketed into an
experiment where users get course highlights and nudges from an
external service (like sailthru or braze) rather than from
edx-platform via ACE.

AA-661
2021-03-02 14:51:45 -05:00
Christie Rice
f1ff795271 MICROBA-1032 Remove command in favor of using the allowlist (#26786) 2021-03-02 14:40:19 -05:00
Carla Duarte
15912fb129 Merge pull request #26806 from edx/ciduarte/AA-510
AA-510: a11y fix for learner dashboard enterprise link
2021-03-02 14:17:50 -05:00
Christie Rice
e5872cf8f2 MICROBA-1032 Add allowlist check and move tests (#26785) 2021-03-02 14:04:03 -05:00