Commit Graph

113 Commits

Author SHA1 Message Date
Calen Pennington
840eb0be4e Capture paver quality logs into the artifacts directory
Capture paver quality build stdout and stderr into separate log files
Send pylint results directly to a report file, so that we don't overwhelm jenkins
2017-12-01 14:34:48 -05:00
Calen Pennington
3c35fbb56b Switch to the parseable output-format for pylint 2017-12-01 14:34:48 -05:00
Jesse Zoldak
0bf0ba0c78 Improve output for quality failures 2017-11-30 14:43:35 -05:00
Ned Batchelder
e23e3a0486 Fix a number of unused-import pylint violations 2017-11-21 19:57:06 -05:00
John Eskew
c78ccf8fc1 Fix the systems parsing code for pylint.
Add lower pylint error threshold to guard against unsuccessful runs.
Increase upper pylint threshold. Add tests for pylint option parsing.
2017-11-18 10:50:20 -05:00
Andy Armstrong
8de47f247c Address feedback 2017-09-12 15:35:46 -04:00
Andy Armstrong
e5cab61897 Lint Sass files using the rules in stylelint-config-edx
Fixes
2017-09-11 22:02:59 -04:00
cahrens
e1e57b5d09 Convert course list to React.
EDUCATOR-625, AC-620
2017-08-09 15:09:37 -04:00
Robert Raposa
b370fe2314 Part II: Rename xss linter. 2017-06-30 13:20:23 -04:00
Andy Armstrong
93235d118d Reorder imports using isort (except lms and cms) 2017-05-30 16:04:54 -04:00
Andy Armstrong
435a6f5225 Make course_experience a feature 2017-03-22 13:00:38 -04:00
Calen Pennington
ea28eb6197 Revert "Revert "Merge pull request #13021 from cpennington/paver-timing""
This reverts commit acf50c4469.
2016-08-03 16:13:10 -04:00
Brian Jacobel
017dbffd5e Remove ESLint from build scripts and script tests 2016-08-02 10:15:53 -04:00
Brian Jacobel
af76273393 Install and configure eslint and eslint-config-edx (alongside JSHint for now) 2016-07-29 13:27:55 -04:00
Calen Pennington
acf50c4469 Revert "Merge pull request #13021 from cpennington/paver-timing"
This reverts commit ed80381b41, reversing
changes made to 205cb8b3eb.
2016-07-26 13:32:59 -04:00
Calen Pennington
f94530ba12 [EV-62] Add the ability to log timing information during paver tasks 2016-07-22 10:54:48 -04:00
Robert Raposa
143a22fb9f Enhance Jenkins integration of safe templates take 2
- Handle case when no files are linted
- Skip deleted files for safe commit script
- Add verbose options for safe commit
2016-05-13 09:59:23 -04:00
Robert Raposa
5ea529ae39 Revert: Enhance Jenkins integration of safe template linting 2016-05-11 09:56:23 -04:00
Robert Raposa
afdec6a99b Enhance Jenkins integration of safe template linting
- Add rule based thresholds
- Add safecommit to Jenkins
2016-05-10 15:50:45 -04:00
Robert Raposa
80c3f84262 Fix safe template issues for 0 violations for some rules 2016-05-10 15:35:57 -04:00
Robert Raposa
ec442789c0 Add Jenkins support for Safe Templates Linter 2016-04-26 12:36:25 -04:00
Ned Batchelder
02fa9c101d Stop adding lms/lib and cms/lib to the PYTHONPATH for pylint
These two directories are not added to sys.path when running the
application, so there is no need to add them for pylint.  When they are
added, they make it impossible to run pylint properly because
lms.lib.xblock is imported when trying to import xblock.
2015-12-09 15:07:37 -05:00
Christine Lytwynec
01d8a9bcad Fix paths for diff quality jshint comparison 2015-11-18 15:52:27 -05:00
Christine Lytwynec
9aa1f2b73f use .jshintignore instead of hardcoded directory list 2015-11-13 16:19:02 -05:00
Ben Patterson
4acde8e1fc Use correct reports for jshint diff-quality. 2015-09-23 16:13:57 -04:00
Ben Patterson
0683e5ff3f Add jshint diff-quality.
The platform includes jshint as a development tool, and our
builds are enforcing a limit on total number of jshint violations.
This commit will enforce no new jshint violations on a per-change
basis, much like pylint and pep8 are enforced. So with this change,
we'll be enforcing our linting requirements consistently, regardless
of type of violations.

Also on Jenkins, runs quality task after installing jshint.
2015-08-31 10:56:09 -04:00
Ben Patterson
c9cf8b6306 Post complexity metric to a file for downstream collection.
This complexity metric is created by using radon (see changed files for additional
documentation links). This tool calculates cyclomatic complexity and provides a numeric grade
where a lower number is better (e.g., less complex).
2015-07-23 15:36:36 -04:00
Ben Patterson
aebb35d361 Use jshint in paver, include in builds.
JShint will be executed with paver run_jshint, which will use a defined set of
directories (likewise defined are directories to ignore). A limit can be imposed
on the total number of violations. Note that this change does NOT include adding
jshint to diff-quality or `paver run_quality`.
2015-05-22 16:06:13 -04:00
Ned Batchelder
24e0c2c80f Run pylint on all our code, and only our code. TE-855
With the old logic, we weren't running pylint on openedx at all.  We
were also running it on lms/lib/comment_client twice, and on the
installed xblock third-party library.
2015-05-04 15:23:55 -04:00
Sarina Canelake
e77211b713 Run pep8 on all files, and fix uncovered errors 2015-03-23 15:50:29 -04:00
Sarina Canelake
bd090a6e58 Fix paver quality tests to reflect removed diff-quality call 2015-03-23 15:37:56 -04:00
Sarina Canelake
a51fbc8123 Refactor pep8 to run instead of diff-quality pep8 2015-03-23 11:01:32 -04:00
Sarina Canelake
1b65afdd04 Give run_pep8 more readable output
Jenkins "Quality Report" pep8 output now lists all pep8 violations,
not just the number of violations.
2015-03-23 11:01:32 -04:00
Ben Patterson
1d00508671 Merge pull request #7147 from edx/benp/static-code-analysis-radon
Benp/static code analysis radon
2015-03-05 06:48:25 -05:00
Christine Lytwynec
8919d3f8f7 Store count of pep8 and pylint violations to files in reports dir 2015-03-03 10:47:22 -05:00
Ben Patterson
ff2dd93405 Simplify reporting and execution of pep8.
We are not using the limit flag in the actual run_pep8 method; removing
that from scripts. Operationally, pep8 has been enforcing a limit of
zero for awhile; this finishes that realization.

Also, all pep8 reports now appear under the reports/pep8 folder, rather than
per-system.
2015-03-02 13:21:35 -05:00
Ben Patterson
7a2384cfd1 Make pep8 failure output easier to understand. 2015-03-02 13:14:23 -05:00
Ben Patterson
efbabdb7bb Revert "Extend quality checks to cover more directories"
This reverts commit 19c767eb52.
2015-03-02 11:20:53 -05:00
Ben Patterson
9c04df5c7e Revert "Refactor quality checks"
This reverts commit 747756a911.
2015-03-02 10:30:21 -05:00
stv
747756a911 Refactor quality checks 2015-02-27 11:49:48 -08:00
stv
19c767eb52 Extend quality checks to cover more directories 2015-02-27 10:04:52 -08:00
stv
a557c5d368 Parameterize system list for quality checks 2015-02-27 10:04:52 -08:00
Ben Patterson
471bd2c0a8 Enable code complexity reporting. 2015-02-27 07:02:04 -05:00
David Baumgold
d6b187d147 Update pylint to 1.4.0 2015-01-08 16:24:44 -05:00
Calen Pennington
980f30c17f Move lms.lib.xblock into lms.djangoapps.lms_xblock in preparation add database backed configuration to it 2014-12-12 21:45:21 -05:00
Christine Lytwynec
5007e98034 Merge pull request #6173 from edx/clytwynec/add_find_fixme_method
add find_fixme task
2014-12-10 11:08:25 -05:00
Christine Lytwynec
7f23c88dd3 add find_fixme task 2014-12-10 10:43:16 -05:00
Christine Lytwynec
25d76da4ef add disable fixme to pylintrc 2014-12-08 09:19:19 -05:00
Kevin Luo
2262906e0b Add compare-branch option to paver run_quality 2014-12-04 15:13:04 -08:00
David Baumgold
d981f98b9c Merge pull request #5814 from edx/disable-pylint-todo-comments
Pylint: ignore TODO comments
2014-11-12 10:51:40 -05:00