Commit Graph

22621 Commits

Author SHA1 Message Date
Dillon Dumesnil
01839789e0 Merge pull request #27153 from edx/ddumesnil/hidden-content-fix-aa-724-part-2
fix: AA-724: Updating the HiddenContentTransformer
2021-03-29 07:13:40 -07:00
Christie Rice
b452f3d5f3 docs: Add ADR on regular course certificate requirements (#27140)
MICROBA-1039
2021-03-29 09:53:50 -04:00
Ali-D-Akbar
ee5b383ff6 PROD-1136: [Support Tool] Update the Enrollments support tool to take entitlements into account. 2021-03-29 12:26:16 +05:00
Dillon Dumesnil
1614fb2956 fix: AA-724: Updating the HiddenContentTransformer
We heard about a bug where learners granted extensions would still
lose access to content if it was marked as "hidden after due date".
This was caused by the HiddenContentTransformer using the due date
from collection time (publish time) rather than the user date returned
from the edx-when DateOverrideTransformer.

A small subtletly of these PRs is that Transformers with the
FilteringTransformerMixin are executed before those without it so
part of the fix was to make the HiddenContentTransformer not use the
FilteringTransformerMixin to ensure the DateOverrideTransformer had
run first.

Part 2/3 - Updating transform method + updating Read version
2021-03-26 14:05:53 -07:00
Dillon Dumesnil
8551528370 Merge pull request #27152 from edx/ddumesnil/hidden-content-fix-aa-724-part-1
fix: AA-724: Updating the HiddenContentTransformer
2021-03-26 14:03:42 -07:00
Dillon Dumesnil
d96f756994 fix: AA-724: Updating the HiddenContentTransformer
We heard about a bug where learners granted extensions would still
lose access to content if it was marked as "hidden after due date".
This was caused by the HiddenContentTransformer using the due date
from collection time (publish time) rather than the user date returned
from the edx-when DateOverrideTransformer.

A small subtletly of these PRs is that Transformers with the
FilteringTransformerMixin are executed before those without it so
part of the fix was to make the HiddenContentTransformer not use the
FilteringTransformerMixin to ensure the DateOverrideTransformer had
run first.

Part 1/3
2021-03-26 10:59:55 -07:00
Carla Duarte
0d7140875f Merge pull request #27141 from edx/ciduarte/AA-722-2
fix: surface assignment type short_label in Progress Tab MFE API
2021-03-26 09:47:01 -04:00
Carla Duarte
4570d4e3d8 fix: surface assignment type short_label in Progress Tab MFE API 2021-03-25 17:52:15 -04:00
Saad Yousaf
229565a072 Merge pull request #27126 from edx/saad/TNL-7971-followup
[TNL-7971] - Correct filename for anonymized id report.
2021-03-26 00:40:03 +05:00
Feanil Patel
68bd33f310 Merge pull request #27138 from edx/feanil/add_request_user_change_logging
feat: Add more detailed request user change logging.
2021-03-25 14:01:52 -04:00
Feanil Patel
c2eabf6cca test: Update query counts.
The new WaffleFlag.is_enabled check in middleware increased query counts
for multiple tests.
2021-03-25 12:14:53 -04:00
Christie Rice
dabad9fdfd feat: Add cert_generation management command (#27131)
MICROBA-1078
2021-03-25 11:01:41 -04:00
Christie Rice
9a24e72643 fix: Require web certs (#27120)
MICROBA-1039
2021-03-25 09:29:51 -04:00
Régis Behmo
cfc45a1c19 docs: annotate REGISTRATION_EXTRA_FIELDS setting (#27136)
Close https://github.com/openedx/build-test-release-wg/issues/10
2021-03-25 08:02:24 -04:00
Zainab Amir
8cc5f13daf Add rate limit to registration endpoint (#27060)
Currently the registration endpoint has no rate limit. Added a new ratelimit
variable to support the change, it's value is set to 60/7d.

VAN-302
2021-03-25 16:28:30 +05:00
Carla Duarte
f88d049602 Merge pull request #27132 from edx/ciduarte/AA-722
AA-722: surface num_droppable assignments in MFE Progress Tab API
2021-03-24 16:10:36 -04:00
Carla Duarte
e8bfee28c5 AA-722: surface num_droppable assignments in MFE Progress Tab API 2021-03-24 13:55:56 -04:00
Azan Bin Zahid
5e466bc772 PROD-2314 2021-03-24 18:13:36 +05:00
Azan Bin Zahid
5c0fce308e PROD-2296 2021-03-24 18:13:36 +05:00
Sarina Canelake
e802614634 Merge pull request #27119 from edx/sarina/TNL-8138
fix: Add ‘ENABLE_HELP_LINK’ to Studio settings
2021-03-24 08:12:01 -04:00
SaadYousaf
5876c783f7 correct filename for anonymized id report. 2021-03-24 14:46:44 +05:00
jawad khan
186cc9f16c LEARNER-7858 (#26967)
Removed tabindex="-1" from main element to fix accessibility issue
Description

Removed tabindex="-1"  from main
We had a strange issue where TalkBack wasn’t reading content in some xBlocks but was reading some others. I figured out that if you remove tabindex=-1 from <main>, TalkBack works as expected again. Tangentially, this breaks the old method of implementing SkipNav links. Further tangentially, the SkipNav links were already broken (or in this case redundant on mobile). @wittjeff  will file two separate issues after this one PR is merged — one  for a better way to implement SkipNav links for  Learning MFE, and one for a better / functional way to implement SkipNav links for Mobile.

How to reproduce
Go to [this unit](https://courses.edx.org/xblock/block-v1:W3Cx+WAI0.1x+3T2019+type@html+block@2eb3c86c479f44ba964f88ff0bfd9211) on mobile and turn on TalkBack. It will skip main content. For further information on testing go to [Jira Ticket](https://openedx.atlassian.net/browse/LEARNER-7858)
2021-03-24 11:15:16 +05:00
sarina
51ccf48f1c fix: Add ‘ENABLE_HELP_LINK’ to Studio settings
Fixes an issue where the button that linked to edX documentation for
course teams in Studio that displayed beside the logged-in user's username/
drop-down menu is gone. Regression from PR #26106

Ref: TNL-8138
2021-03-23 16:16:21 -04:00
Simon Chen
4c5d56ef06 MST-682 Add external_user_key to the student profile CSV (#27091)
* MST-682 Add external_user_key to the student profile CSV
This is a request from some Masters school partners. They would like to download the student enrolled list with the Masters external_user_key data referenced. This way, the schools can properly match the students enrolled in the course with the students enrolled through Masters enrollment system
2021-03-22 14:25:34 -04:00
Calen Pennington
91b74b7fd3 Merge pull request #23457 from open-craft/agrendalath/bb-2063-fix-marking-blocks-as-completed-on-course-outline-page-upstream
[BB-2063] Calculate completion for custom blocks on the Course Outline page
2021-03-22 13:33:18 -04:00
Agrendalath
e571693455 Support EXCLUDED blocks in Block Completion Transformer
For now only the discussion blocks were supported. If we had a custom XBlock that specified `completion_mode = XBlockCompletionMode.EXCLUDED`, then it could never be marked as completed on the course outline page, despite being marked as such inside the learning sequence.
2021-03-22 16:21:43 +01:00
Agrendalath
5a27b5df39 Calculate completion for custom blocks on the Course Outline page
This adds support for displaying completion on the course outline page, to remove the discrepancies between this view and the learning sequence. It also simplifies course outline page by reusing existing APIs for determining completion state and finding the "Resume block"'s target.
2021-03-22 16:21:32 +01:00
Bianca Severino
ed63ffbb50 Merge pull request #27086 from edx/bseverino/proctoring-escalation-email
Allow `get_proctoring_escalation_email` to use a course key object
2021-03-22 10:12:45 -04:00
Christie Rice
43f32a8f6b feat: Add initial certificate generation checks for updated (V2) course certificates (#27090)
MICROBA-923
2021-03-22 10:07:21 -04:00
Robert Raposa
f9c11f061f Merge pull request #27059 from open-craft/nizar/update_block_structure_toggles_annotations
docs: updates ticket links for block structure settings and toggles
2021-03-22 09:29:48 -04:00
M. Zulqarnain
40a987d9d0 refactor: pyupgrade on LMS (#26851) 2021-03-22 17:51:23 +05:00
Awais Qureshi
c43cdd0cee Merge pull request #27100 from edx/revert-27097-revert-27087-fixing-toggles
Revert "Revert "temp: Apply pylint amnesy ( Type annotation-invalid-choice )""
2021-03-22 17:26:23 +05:00
Awais Qureshi
23bcd6f05d revert: Reverts #27097
#27097 reverted the pylint amnesty change. After reverting the ubuntu20 deployment, now this can be deployed again.
2021-03-22 15:17:22 +05:00
edX requirements bot
41c1d237eb Python Requirements Update (#27094)
* Updating Python Requirements

* fix proctoring test

Co-authored-by: Zulqarnain <muhammad.zulqarnain@arbisoft.com>
2021-03-22 15:15:46 +05:00
Awais Qureshi
20c39b267e Revert "temp: Apply pylint amnesy ( Type annotation-invalid-choice )" 2021-03-22 12:47:43 +05:00
Awais Qureshi
60cd0c1295 Merge pull request #27087 from edx/fixing-toggles
temp: Apply pylint amnesy ( Type annotation-invalid-choice )
2021-03-22 11:19:50 +05:00
Sofiane Bébert
5d7cd3d278 docs: annotate auto_certificate_generation (#26770) 2021-03-19 16:01:55 -04:00
Awais Qureshi
4611398429 temp: Apply pylint amnesy. 2021-03-19 23:01:31 +05:00
Usama Sadiq
aa618c460c refactor: remove unused-imports (#27083) 2021-03-19 22:42:14 +05:00
Bianca Severino
d7c944c387 Allow get_proctoring_escalation_email to use a course key object 2021-03-19 11:24:27 -04:00
Bianca Severino
7a7c87d277 Merge pull request #27080 from edx/bseverino/proctoring-3.7.12
Revert edx-proctoring to 3.7.12
2021-03-19 09:59:46 -04:00
Saqib
b367b276c9 docs: add annotations for ENABLE_LTI_PROVIDER feature flag (#27040) 2021-03-19 09:42:24 -04:00
Bianca Severino
557029b0db Revert edx-proctoring to 3.7.12 2021-03-19 09:38:43 -04:00
Sarina Canelake
2342f04447 Merge pull request #26435 from open-craft/shimulch/bb-3624-upstream
Fix missing email context values and pass site configuration to better multi-site customization
2021-03-19 08:42:38 -04:00
Awais Qureshi
05a5f5954b refactor: remove unused imports. 2021-03-19 10:15:59 +00:00
Shimul Chowdhury
e942f12adc Add missing context platform_name and contact_mailing_address. And pass
site configuration to email context.
2021-03-19 10:05:49 +06:00
Christie Rice
fa15afb062 fix: Update logging (#27065)
MICROBA-923
2021-03-18 15:00:52 -04:00
Bianca Severino
14fdb75c15 Merge pull request #27041 from edx/bseverino/proctoring-3.7.13
Update edx-proctoring to 3.7.13
2021-03-18 11:11:06 -04:00
Simon Chen
69da33cc9c Update the logging messages on ID Verification backend (#27061)
Currently in edx.org production, we have seen unhelpful error message that produces noises covering real important errors. This change would update the logging so we can have better and informative error messages for ID Verification
2021-03-18 10:32:25 -04:00
Dillon Dumesnil
1949675761 Merge pull request #27042 from edx/ddumesnil/segment-device-mode-aa-692
refactor: AA-692: Update location of is-hidden class when fa icon is …
2021-03-18 06:29:59 -07:00