Commit Graph

12296 Commits

Author SHA1 Message Date
Saad Yousaf
e4c00dd335 Merge pull request #23563 from edx/saad/PROD-1287-remove-flaky-test
[PROD-1287] - Remove flaky test lms.djangoapps.instructor_task.tests.test_tasks_helper.TestProblemGradeReport.test_grading_failure
2020-04-01 17:49:28 +05:00
SaadYousaf
8c4ae15766 remove flaky test. 2020-04-01 15:46:20 +05:00
Ahtisham Shahid
f6be77d493 Removed tech email form error templates
fixed tests

fixed test fail

Fixed failing tests
2020-04-01 14:53:01 +05:00
Awais Qureshi
30a2ae8aec BOM-1438
Fix course_id string.
2020-04-01 14:42:35 +05:00
David Ormsbee
5ea71beeb1 Make XBlock views/handlers non-atomic requests.
We're seeing slow commits on production for courseware_studentmodule
updates. Based on the slow queries during those times, we think it
might be because multiple worker processes are trying to update the
same rows from within long-running transactions (since courseware
is relatively slow).

The risk with this is that since the whole view execution is no
longer wrapped in a big implicit transaction, it's possible that
XBlock state will update and things that key off of that (e.g.
completion progress information or pre-req milestones) will fail
in a way that will leave the database in an unplanned-for state,
though this is already the case for those actions that trigger
asynchronous tasks like grades recalculation.

The query counts for the index view test were adjusted down
because save points count towards the total and we're no longer
setting them at the top level around the view as a whole.
2020-03-31 21:22:58 -04:00
Nimisha Asthagiri
d8774e4f8d Merge pull request #23555 from edx/arch/django2-bulk-email
Django2 bulk_email: bytestring conversion
2020-03-31 16:55:33 -04:00
Nimisha Asthagiri
90a330d0ad Django2 bulk_email: bytestring conversion 2020-03-31 16:04:45 -04:00
Nimisha Asthagiri
e320af0272 Merge pull request #23552 from edx/arch/django2-badges
Django2 Badges: fix course_id string
2020-03-31 15:46:11 -04:00
Manjinder Singh
b1baf5db77 Converting variable to string before assignment in tests (#23546)
* Converting variable to string before assignment in tests

Django 2 is stricter of string typing, so it will no longer do implicit conversions in some cases.
While the release notes only mention dropping bytestring support in some places, they seem to have also dropped implicit conversion to str for whole host of things.
2020-03-31 15:31:52 -04:00
Nimisha Asthagiri
8a0d57eec3 Django2 Badges: fix course_id string 2020-03-31 14:23:53 -04:00
Nimisha Asthagiri
da55a740a1 Django2 experiments app: Fix course_id string 2020-03-31 13:42:02 -04:00
Saad Yousaf
521f5f2dc8 Merge pull request #23531 from edx/saad/PROD-1287-fix
[PROD-1287] - Optimize problem_grade_report code - FIX.
2020-03-31 14:35:08 +05:00
adeelehsan
8d840e6f55 Merge pull request #23529 from edx/revert-23509-aehsan/prod-1222/added_logs_for_investigation
Revert "Added logs for investigation"
2020-03-31 12:31:05 +05:00
Nathan Sprenkle
02392879b7 Team Management Upload A11y Improvements (#23502)
* Expose team management file input for better a11y
* Disable upload button when file not selected
2020-03-30 17:03:15 -04:00
SaadYousaf
6fb9d199a0 optimize code for problem_grade_report. 2020-03-30 20:33:49 +05:00
adeelehsan
82bf1d744a Revert "Added logs for investigation" 2020-03-30 19:15:26 +05:00
Saad Yousaf
a458491f04 Revert "[PROD-1287] - initial work to optimise problem_grade_report code." 2020-03-30 19:05:54 +05:00
M Zulqarnain
0aba1af792 Merge pull request #23526 from edx/zulqarnain/BOM-1422
BOM-1420 : Fix Django 2.x tests in Discussion app
2020-03-30 17:48:47 +05:00
Zulqarnain
34bece208a Fix discussion notif pref tests 2020-03-30 16:01:06 +05:00
Saad Yousaf
4c5006988f Merge pull request #23267 from edx/saad/PROD-1287
[PROD-1287] - initial work to optimise problem_grade_report code.
2020-03-30 15:14:10 +05:00
Waheed Ahmed
a23a31c2be Allow Block Structures Collect to work in Studio.
The collect process was broken before this commit because Studio's
runtime does not permit handler_url invocation on "thirdparty"
XBlocks.

PROD-1393
2020-03-30 13:24:34 +05:00
SaadYousaf
4e4bffe404 initial work to optimise problem_grade_report code. 2020-03-30 13:14:01 +05:00
Zachary Hancock
b9bafed817 add pending role assignment model (#23506) 2020-03-27 14:29:09 -04:00
adeelehsan
c04341f863 Merge pull request #23509 from edx/aehsan/prod-1222/added_logs_for_investigation
Added logs for investigation
2020-03-27 18:21:21 +05:00
adeelehsan
da875856c8 Added logs for investigation 2020-03-27 17:37:37 +05:00
David Ormsbee
1e8b6d5a00 Make upgrade to get the latest edx-when (1.1.3)
Also pinned httpretty < 1.0 because that upgrade broke many tests.
2020-03-26 12:06:27 -04:00
Simon Chen
b1f61d929d MST-157 Part 3 Create the Program Enrollments Inspector tool UI and link to the Support tool index page 2020-03-25 13:08:48 -04:00
Adam Butterworth
a2c4b00246 Skip flaky courseware MFE redirect tests (#23483) 2020-03-24 12:50:14 -04:00
HammadAhmadWaqas
48d9c82e0a added sleep of 1 second in create_orders_for_old_enterprise_course_enrollment command so that we should not hit ecommerce API more that 60 calls per minute. 2020-03-24 15:50:14 +05:00
Adam Butterworth
1f59463720 Swap courseware-mfe CourseWaffleFlag with ExperimentWaffleFlag (#23429)
TNL-7000
2020-03-23 13:46:42 -04:00
Michael Terry
abc43a9352 Merge pull request #23463 from edx/mikix/verification-email-fix
Fix error in verification email command
2020-03-20 12:50:47 -04:00
Michael Terry
1aa49c93b8 Merge pull request #23456 from edx/mikix/enrollment-end
enrollment_end support for experiments
2020-03-20 12:17:42 -04:00
Michael Terry
7999bdfbe9 Fix error in verification email command
We are seeing an error in the send_verification_expiry_email job
because one verification model instance had a null expiry_date but
a non-null expery_email_date.

This makes us more robust to that odd data and makes the job more
robust by having it still send other emails out even if one fails.

AA-70
2020-03-20 11:32:03 -04:00
Waheed Ahmed
02b900cf64 Remove unnecessary check.
If `courseoverview.display_name` is set we don't get it from block
and we can remove this unnecessary check.
2020-03-20 13:50:51 +05:00
Simon Chen
0b90de1d94 MST-157 PART-2 Complete the functionality of searching for user info on program enrollment. The search result will be displayed on support tool's frontend. 2020-03-19 20:50:47 -04:00
Alex Dusenbery
c8d78eb3db Fix a flaky teams test - sort lists before comparison. 2020-03-19 17:49:12 -04:00
Michael Terry
c4868d07bf enrollment_end support for experiments
Now in addition to enrollment_start support in ExperimentWaffleFlag,
you can set an enrollment_end date for your experiment. All enrollments
after this date will get the control experience.
2020-03-19 15:10:57 -04:00
Jansen Kantor
21c6d6b08d EDUCATOR-4952: Allow Users to join one team per open teamset (#23423)
*allow users to join one team per teamset
2020-03-19 13:56:35 -04:00
Dillon Dumesnil
a13b695660 AA-74: Only show cert available date in Instructor paced courses 2020-03-18 12:41:27 -07:00
Alex Dusenbery
5f00228b11 Add grades how_tos doc. 2020-03-18 14:38:07 -04:00
Kyle McCormick
b40b55cbbf Improve Django admin listings for program_enrollments 2020-03-18 14:33:36 -04:00
Kyle McCormick
f4d5bc22f9 Improve repr() output of program_enrollments models 2020-03-18 14:33:36 -04:00
Alex Dusenbery
2cdb244858 remove some potentially problematic tests 2020-03-18 13:26:48 -04:00
Alex Dusenbery
f2efb28833 Generate migrations for changes to default values of fields in the CourseTeam model. 2020-03-18 13:26:48 -04:00
Awais Jibran
1296b6a79d Merge pull request #23427 from edx/logs-cleanup
Remove/Limit log.info
2020-03-18 12:08:23 +05:00
Matt Hughes
acce8baca4 Add management command for retroactively adding sso IdV for IdP
We sometimes update preexisting SAML SSO providers to configure them
to automatically create SSO identity verification (IdV) records when a
learner links an account via that provider. Turning that configuration
from off to on does make it such that when learners log back in via
their linked account, a new IdV record will be created for them. But
it's possible we'd want this process to happen more automatically and
seamlessly, for which this management command will be helpful.

Note that this does not help with removing SSO verification records
for a provider for which this configuration has been turned off.

JIRA:EDUCATOR-4947
2020-03-17 16:04:24 -04:00
atesker
7e51f438e4 EDUCATOR-4903. Move defaults to correct place
EDUCATOR-4903. Move defaults to correct place - cr
2020-03-17 15:53:15 -04:00
Nicholas D'Alfonso
8e77a822fe AA-73 courseware nonetype error
- ensure logic for displaying reset dealines banner in courseware
  is behind the relative dates waffle flag, only shows if the
  course is self paced, and handles the situation where no
  sequentials exist.
2020-03-17 14:05:15 -04:00
Nathan Sprenkle
9535c37c79 Fix UX issues on Team Management tab (#23417)
* Don't disable download button after click

* Allow reuploading for team membership CSV
2020-03-17 12:03:53 -04:00
Nathan Sprenkle
8219ddc40a Fix A11y issues on Team Management tab (#23403)
* Change upload div to a button for focus styling

* Fix team membership button resize on focus

* Remove box shadow from focus styling
2020-03-17 11:16:24 -04:00