Commit Graph

418 Commits

Author SHA1 Message Date
Andy Armstrong
5316cbee02 Merge pull request #8809 from edx/zoldak/update-sinon
Update Sinon library
2015-09-24 13:17:03 -04:00
Jesse Zoldak
1aa181c90a Update sinon to version 1.17.0 2015-09-24 10:55:48 -04:00
Eric Fischer
02b72abccb Disable button while running
Now using withDisabledElement to prevent multiple event handling. I've
attempted to write this as a common function in view_utils, so that this
approach can be used more generally, wherever needed. Includes a unit test.

Thanks to Christina and Andy for all their help on this one.
2015-09-24 10:13:30 -04:00
Andy Armstrong
b2a0b2f728 Improve response handling in AjaxHelpers
I've changed the logic so that AjaxHelpers keeps
track of which requests have not yet had mock
responses sent. This ensures that every response
is handled before moving on to the next one,
rather than always handling the last request.
My intention is that this won't allow bugs to creep
in where a request isn't fired and instead the test
responds to an old request. It also should ensure
that extra events aren't accidentally fired.
2015-09-23 20:23:09 -04:00
Andy Armstrong
d09034e065 Improve team testing of routers 2015-09-23 13:10:46 -04:00
Diana Huang
a53903c46a Add team column to grade reports. 2015-09-23 12:21:13 -04:00
Christine Lytwynec
f96d4b7142 Manage focus on modal confirmation prompt 2015-09-21 13:36:02 -04:00
Muhammad Ammar
edf88962b5 Merge pull request #9534 from edx/ammar/update-factory-boy
Update factory_boy
2015-09-18 19:04:48 +05:00
Christina Roberts
56fd445f5c Merge pull request #9798 from edx/christina/teams-dashboard
Emit event when last_activity_at is updated.
2015-09-18 09:54:36 -04:00
muhammad-ammar
6a5ce5d544 Upgrade factory_boy
TNL-3179
2015-09-18 18:02:38 +05:00
Kevin Falcone
81abdbe81b Merge pull request #9819 from edx/release
Release
2015-09-17 21:30:48 -04:00
cahrens
0d99449899 Emit event when last_activity_at is updated.
TNL-3303
2015-09-17 17:19:17 -04:00
Peter Fogg
0f78989220 Escape team name in screenreader text. 2015-09-17 16:15:50 -04:00
John Eskew
7c0663f25e Merge remote-tracking branch 'origin/release' into jeskew/resolve_issues_with_release 2015-09-16 15:58:08 -04:00
Peter Fogg
33f559b04a Remove membership field from teams when serializing memberships.
TNL-3281
2015-09-15 13:05:10 -04:00
Peter Fogg
e38fc82650 Merge pull request #9752 from edx/peter-fogg/handle-elasticsearch-errors
Add error handling for elastic search.
2015-09-14 17:01:10 -04:00
Peter Fogg
ca124354ba Add error handling for elastic search. 2015-09-14 16:15:17 -04:00
Andy Armstrong
f80b6221d9 Fix duplicate calls to search API
TNL-3198

Also fixed a regression with the search breadcrumbs
where it wasn't possible to navigate back to the
full list.
2015-09-14 13:32:45 -04:00
Peter Fogg
0612e914dc Various accessibility fixes for Teams.
Update teams breadcrumb aria-label, make team membership display as a
<ul>, fix contrast issues, and remove an extraneous angle bracket.
2015-09-11 15:25:30 -04:00
Bill DeRusha
4234ff5959 Merge pull request #9707 from edx/bderusha/edx-search-config
Add edx-search configuration to lms
2015-09-11 14:45:23 -04:00
Bill DeRusha
eec2bed0c7 Add edx-search configuration to lms
remove "defensive code" until we can figure out how to actually
catch the errors,
2015-09-11 13:55:39 -04:00
Peter Fogg
12c9d6b52f Merge pull request #9714 from edx/peter-fogg/fix-slow-memberships
Prevent over-expansion of team memberships.
2015-09-11 13:37:50 -04:00
Peter Fogg
48f72612c3 Prevent over-expansion of team memberships.
TNL-3202
2015-09-11 12:55:39 -04:00
Daniel Friedman
44fd787a98 Fix syntax error in teams_tab_spec.js 2015-09-11 11:43:20 -04:00
Diana Huang
222c3ba01e Merge pull request #9713 from edx/diana/eventing-updates
Add course id contexts to teams events
2015-09-11 09:16:06 -04:00
Andy Armstrong
5f5310446f Remove unnecessary breadcrumbs for Teams tab
TNL-3249
2015-09-10 21:48:44 -04:00
Diana Huang
f37ffc2f03 Add the course as part of the context for teams events.
TNL-3248
2015-09-10 17:24:54 -04:00
Eric Fischer
17e6453546 Merge pull request #9520 from edx/efischer/teams-instructor-toolbar
Teams Instructor Tools bar
2015-09-10 17:24:39 -04:00
Eric Fischer
65cbab739a Team deleted and learner removed events
Now emitting `edx.team.deleted` event where relevant. Includes tests.
Also includes tests to cover learner_removed events that are fired
as part of the deletion process, as well as learner_removed events
fired from the edit membership view.

Adding these deleted events has brought about a change in the teams
API - the DELETE membership endpoint now takes an optional `admin`
query parameter to differentiate between admin removal and self
removal for analytics purposes.

Also includes some changes needed to get page viewed events working
with admin tools changes made in this PR.
2015-09-10 16:37:04 -04:00
Eric Fischer
6edadc2acc Developer-quality css
Adding my humble attempts at making the tools match the wireframes
given in invision. Only done via changes in _developer.scss, the
real rules will be made by UX team elsewhere.

Includes preliminary accessibility feedback, and basic RTL.
2015-09-10 16:37:03 -04:00
cahrens
3662fbc133 Edit Membership functionality and tests
TNL-1913
2015-09-10 16:36:55 -04:00
Andy Armstrong
55b2ea374f Merge pull request #9684 from edx/andya/fix-teams-i18n
Fix i18n for last activity date on team cards
2015-09-10 16:27:00 -04:00
Peter Fogg
f8da90e533 Merge pull request #9667 from edx/peter-fogg/join-team-redirect
Fix redirecting to topics page after joining a team.
2015-09-10 12:46:29 -04:00
Peter Fogg
0c3be8e121 Delete Team functionality and tests
TNL-3164 TNL-3163
2015-09-10 12:42:33 -04:00
Eric Fischer
8942b31d31 Introducing instructor toolbar
All the non-CSS changes to get instructor toolbar working as in
wireframes, with non of the functionality or style.
2015-09-10 12:39:41 -04:00
Daniel Friedman
b03ba6f997 Merge pull request #9705 from edx/dan-f/remove-silly-debugger-statement
Remove debugger statement from JS spec
2015-09-10 11:58:52 -04:00
Peter Fogg
146078e2c6 Fix redirecting to topics page after joining a team.
TNL-3232
2015-09-10 11:55:27 -04:00
Daniel Friedman
68060d5139 Remove debugger statement from JS spec 2015-09-10 11:15:41 -04:00
Andy Armstrong
439ddfa97e Merge pull request #9668 from edx/andya/team-search-i18n-bug
Improve support for Chinese characters in team search
2015-09-10 11:09:17 -04:00
Daniel Friedman
3b957a7ee9 Add page viewed events to teams app.
TNL-3188
2015-09-09 23:04:44 -04:00
Peter Fogg
1c910cfbbb Merge pull request #9631 from edx/peter-fogg/teams-ajax-errors
Respond to AJAX errors in Teams UI.
2015-09-09 18:49:39 -04:00
Andy Armstrong
6817e89f4a Fix i18n for last activity date on team cards 2015-09-09 17:59:25 -04:00
Peter Fogg
95339311b0 Respond to AJAX errors in Teams UI.
TNL-3042
2015-09-09 17:04:23 -04:00
Andy Armstrong
321a0ea6a0 Fix searching with Chinese characters
TNL-3228
2015-09-09 14:16:05 -04:00
Clinton Blackburn
b5d6b210fd Merge pull request #9681 from edx/release
Release 2015-09-09
2015-09-09 12:38:15 -04:00
Andy Armstrong
72ea41f9c7 Don't localize search indexes for teams
TNL-3239
2015-09-08 18:26:12 -04:00
Bill DeRusha
49807ab6a5 Add search specific feature flag in front of search features 2015-09-08 17:13:30 -04:00
Diana Huang
0b78ffdf83 Merge pull request #9632 from edx/diana/teams-changed-event
Add events for tracking when teams are edited.
2015-09-08 15:21:49 -04:00
Bill DeRusha
62ef4b5b8f Add more defensive code around elasticsearch connection 2015-09-08 12:12:05 -04:00
Diana Huang
8c1bf2cd3a Add events for tracking when teams are edited.
TNL-3190
2015-09-04 15:27:40 -04:00