Commit Graph

609 Commits

Author SHA1 Message Date
Nimisha Asthagiri
99ce254b15 Fix import required by downstream commit. 2016-10-05 01:25:57 -04:00
J. Cliff Dyer
62042188f5 Revert "Fix Gating to use grades API, instead of its own calculations"
This reverts commit 318121411a.
2016-10-04 17:19:30 -04:00
Eric Fischer
4793a42767 Silence more grades-related logging 2016-10-01 23:23:09 -04:00
Nimisha Asthagiri
969c75a7d1 Fix for grade assertions 2016-10-01 23:23:09 -04:00
Eric Fischer
d772cb0ada Revert "Merge pull request #13614 from edx/efischer/revert_grades"
This reverts commit 0ea8e1b9b2, reversing
changes made to e3db08f194.
2016-09-30 16:52:05 -04:00
Adam
9aa35cd8ad Merge pull request #13614 from edx/efischer/revert_grades
Potential Grades revert PR
2016-09-30 14:08:58 -04:00
Eric Fischer
853d2a8688 Revert "Handle null weighted_possible values safely."
This reverts commit 2ec95262ab.
2016-09-30 14:08:44 -04:00
Eric Fischer
242f3a79c5 Quality fix in revert 2016-09-30 10:46:45 -04:00
J. Cliff Dyer
2ec95262ab Handle null weighted_possible values safely.
Rather than failing, treat them as unscored blocks.

[TNL-5689](https://openedx.atlassian.net/browse/TNL-5689): Server error when
checking a problem.
2016-09-30 10:21:35 -04:00
Eric Fischer
ac2f71df99 Revert "Merge pull request #13547 from edx/beryl/correct_weight"
This reverts commit 663fbbbaa0, reversing
changes made to 3f7441c80f.
2016-09-30 10:06:10 -04:00
Eric Fischer
ca287c73c7 Revert "Merge pull request #13461 from edx/cdyer/test-block-types"
This reverts commit c050ccc318, reversing
changes made to 9ba9772239.
2016-09-30 10:06:01 -04:00
Eric Fischer
e00fe03d9d Revert "Merge pull request #13539 from edx/sstudent/TNL-5601"
This reverts commit e3db08f194, reversing
changes made to 51c2444de3.
2016-09-30 10:05:44 -04:00
sanfordstudent
e3db08f194 Merge pull request #13539 from edx/sstudent/TNL-5601
fire SCORE_CHANGED on student state reset
2016-09-30 09:34:59 -04:00
Eric Fischer
e4c626d362 Merge pull request #13607 from edx/release
Hotfix 2016-09-29b release to master
2016-09-29 18:06:21 -04:00
Eric Fischer
ce067618c9 Drop noisy grades logging to debug level
These need to be dropped down to avoid splunk, as they are currently
flooding our infrastructure.
2016-09-29 13:58:19 -04:00
Sanford Student
e9f92bd05a fire SCORE_CHANGED on student state reset 2016-09-29 13:42:12 -04:00
J. Cliff Dyer
ddb383c3c2 Test different problem types. 2016-09-28 16:38:38 -04:00
Nimisha Asthagiri
5ba77275d8 Fix problem weights in persisted grades
TNL-5599
2016-09-27 10:09:09 -04:00
Nimisha Asthagiri
318121411a Fix Gating to use grades API, instead of its own calculations
TNL-5062
2016-09-24 00:46:28 -04:00
Cliff Dyer
8930376bfb Merge pull request #13540 from edx/cdyer/visible-block-version
Add version to VisibleBlocks model.
2016-09-23 16:58:39 -04:00
J. Cliff Dyer
37fc450b8b Add version to VisibleBlocks model.
TNL-5600
2016-09-23 13:52:30 -04:00
Eric Fischer
9b9ab2e44f Standardize logged errors
For easier consumption by splunk, match the pattern used by other grades-
related log statements. Also, reduce the firehose of events being logged
in splunk.
2016-09-22 11:53:12 -04:00
Eric Fischer
c90186f802 Merge pull request #13494 from edx/efischer/skip_tests
Readd imports to fix broken tests
2016-09-16 12:14:15 -04:00
Nimisha Asthagiri
88297788b9 Merge pull request #13478 from edx/tnl/explicit-grade-values
Explicit grade values so saved grades are immune to subsection graded
2016-09-16 10:50:52 -04:00
Eric Fischer
d0ad808d39 Readd imports to fix broken tests 2016-09-16 10:21:04 -04:00
Nimisha Asthagiri
47e556c7f5 Use explicit 'graded' value so grades are immune to subsection's value
TNL-5560
2016-09-16 08:31:30 -04:00
Eric Fischer
6d2468d0dc Merge pull request #13487 from edx/release
Hotfix 2016-09-15 release to master
2016-09-15 18:49:53 -04:00
Pan Luo
89750172b4 Fix grade push back for non-components through LTI
There is a bug introduced in this commit:
22046d4067 (diff-32687833c38e231b51a8f27a76c72a56R119)
The return value of the locations_to_weighted_scores[location] is
changed from `Score` object to a tuple (Score, weight). However, the
left side of assignment didn't get updated. So an error is raised and
the Celery task failed to continue. Thus, no grade is being passed back.
2016-09-15 12:14:14 -04:00
Eric Fischer
fd71afe94f Make Robust Grades Robust Again
As part of the Robust Grades rollout, we expect to see some DatabaseErrors in
various methods that write to the database. Since the success of this write
operation is not needed for the end-user, we just log and swallow the error.

In the future, we'll also enqueue an async task to finish the write operation
that failed.
2016-09-14 12:05:59 -04:00
Nimisha Asthagiri
232d99d06d Persisted grades optimization - update query counts in tests 2016-09-14 11:44:54 -04:00
J. Cliff Dyer
29034df3bb VisibleBlocks migration: add course_id for bulk retrieval 2016-09-14 11:44:53 -04:00
Nimisha Asthagiri
4dbbe513be Reduce sql queries with persisted grades
TNL-5458
TNL-5493
2016-09-14 11:44:53 -04:00
sanfordstudent
c920269b6c Merge pull request #13407 from edx/sstudent/TNL-5398
logging
2016-09-12 13:55:43 -04:00
Sanford Student
c48996c0fc logging for persistent grades rollout 2016-09-12 12:02:44 -04:00
Nimisha Asthagiri
c1d4d730e0 Fix submissions API test - now that calculated grades are saved 2016-09-11 00:45:50 -04:00
Nimisha Asthagiri
d244715e87 Don't sort blocks to retain order. 2016-09-10 13:29:58 -04:00
Nimisha Asthagiri
660bc8f447 Enable Persistent Grades in unit tests 2016-09-09 19:05:04 -04:00
Nimisha Asthagiri
2251097c56 Merge pull request #13437 from edx/cdyer/keep-course-run
Ensure usage keys have course run in locators.
2016-09-09 19:02:31 -04:00
J. Cliff Dyer
ddd58dafd8 Ensure usage keys have course run in locators.
TNL-5475
2016-09-09 17:42:51 -04:00
Nimisha Asthagiri
f0f7a5389b Optimize Subsection computation 2016-09-09 13:57:51 -04:00
Eric Fischer
31953c5e0c Update correct persistent score
* First take at forcing a subsection's grade to update when a signal is
  sent that a problem's score has changed
* Refactor signal handler connection.
* Expand bokchoy tests to cover progress page
* Add some grading unit tests

TNL-5394
TNL-5364
2016-09-08 15:09:05 -04:00
sanfordstudent
b7ac081e49 Merge pull request #13329 from edx/sstudent/TNL-5382-part-1
creating django admin settings for subsection grades
2016-09-02 10:52:51 -04:00
Sanford Student
d54a784a43 creating django admin settings for subsection grades 2016-09-02 09:32:33 -04:00
Adam
e1cd58dcd4 Merge pull request #13385 from edx/release
Release
2016-09-02 08:41:17 -04:00
J. Cliff Dyer
6bda334b99 Handle scoreable blocks without defined weight
Default weight to 1.0.

TNL-5410
2016-09-01 15:56:17 +00:00
Giovanni Di Milia
cc65094b03 Added Current Grade Rest API 2016-08-30 13:51:41 -04:00
Eric Fischer
401a81eda3 Instantiate BlockUsageLocator when making BlockRecord
We already have logic to serialize BUL objects to string on save,
but the corresponding deserialization logic was missing.
2016-08-29 14:13:33 -04:00
Eric Fischer
13687e4753 Grades cleanup
Small changes to the grades djangoapp
    -sets up mock_get_score context handler
    -fixes an issue with not invalidating lazy scores property
    -code quality fixes
    -query count optimization in PersistentSubscetionGrade.create
    -adds atomic blocks to avoid IntegrityErrors corrupting an entire request
2016-08-25 11:43:49 -04:00
Sanford Student
b9dade5512 handler for SCORE_CHANGED signal 2016-08-23 13:12:36 -04:00
Eric Fischer
22046d4067 Use PersistentSubsectionGrade in grades application
Hooks the pre-existing grades code into our new PersistentSubsectionGrade data
model. Includes test updates, and some minor changes to the data model that
were discovered in testing.
2016-08-22 09:47:37 -04:00