Brian Wilson
bb7bc88847
merge out from master
2013-03-27 18:04:58 -04:00
Brian Wilson
99778b1b5b
add fixes for 500 bugs (lighthouse 287 and 293) by requiring login for accessing licenses and inline discussions. Add unit tests for licenses, and rearrange tests based off of (the former) PageLoad. Also cleanups for pylint and pep8.
2013-03-27 17:59:56 -04:00
Will Daly
9c671163fd
Added exc_info=True to log.warning
...
Changed log.exception to log.warning
2013-03-27 17:11:02 -04:00
Will Daly
df1be87739
* Changed 404 errors to 400 errors
...
* Removed duplicate traceback log message
* Now provide string, not Exception, as second tuple item to raise
2013-03-27 15:20:40 -04:00
Will Daly
ac86687fa1
Added exception handling that solves SchematicResponse exceptions
...
causing a 500 error.
When XModule raises a ProcessingError during an AJAX request,
this module_render now returns a 404 to further reduce number of 500
responses.
2013-03-27 14:33:59 -04:00
Will Daly
cddc868656
Login URL resolves differently in LMS and CMS, which breaks login_test
...
when loaded by rake test_cms
I moved the test into lms/courseware/tests so they run correctly.
2013-03-27 13:01:10 -04:00
brianhw
a04881ceda
Merge pull request #1740 from MITx/fix/vik/peer-image-grading
...
Fix/vik/peer image grading
2013-03-27 09:06:54 -07:00
Calen Pennington
2c0e5b82ff
Return a 403 when an anonymous user attempts to hit modx_dispatch. Fixes https://www.pivotaltracker.com/story/show/46916015 and https://www.pivotaltracker.com/story/show/46916029
2013-03-27 07:29:22 -04:00
Will Daly
0500ba4dd5
Disabled pylint warnings for lettuce steps:
...
* Missing docstring
* Redefining name from outer scope
2013-03-26 11:46:31 -04:00
Will Daly
27d5ebf027
pep8 fixes
2013-03-26 11:44:57 -04:00
Will Daly
00d25b684c
Moved modulestore flush code into terrain/course_helpers
2013-03-26 11:44:57 -04:00
Will Daly
4528490fac
Refactored lms/coureware lettuce tests to use terrain helpers
...
for common ui manipulations
2013-03-26 11:44:56 -04:00
Will Daly
6dd86f7a97
Refactored courseware_common and open_ended to use ui helpers
2013-03-26 11:44:56 -04:00
Will Daly
5e69050a16
Elminated unused functions from courseware/features/courses.py
...
and moved the rest to common.py
2013-03-26 11:44:56 -04:00
Will Daly
b0eb73302b
Moved some courseware/features/common.py steps into
...
terrain/steps.py
2013-03-26 11:44:56 -04:00
Vik Paruchuri
97cb4910a7
Add in default bucket, edit image url checks
2013-03-26 11:04:14 -04:00
Vik Paruchuri
df935d422d
Fix issues with open ended image grading and peer grading centralized module finder.
2013-03-26 09:52:26 -04:00
Arthur Barrett
d636f4fab0
Merge branch 'master' into feature/abarrett/lms-notes-app
2013-03-25 19:04:58 -04:00
Will Daly
37e7d68cef
pep8 and pylint fixes
2013-03-25 16:46:31 -04:00
Will Daly
c660229b25
Added checking for problem answer state after a problem is checked
2013-03-25 16:37:59 -04:00
Victor Shnayder
f0e1b477f7
Merge pull request #1703 from MITx/feature/diana/matlab-input
...
Matlab Input Type
2013-03-25 08:27:56 -07:00
Chris Dodge
fd973442b1
if we have to reload a module and already have the descriptor, we don't need to refect the descriptor (which results in another DB round-trip. We just need the student state.
2013-03-22 13:57:53 -04:00
Arthur Barrett
7120998938
refactoring notes js
2013-03-21 17:18:45 -04:00
Will Daly
6728f16ae4
Merge branch 'feature/zoldak/refactor-factories' into feature/will/speed_up_lettuce_tests
...
Conflicts:
lms/djangoapps/courseware/features/problems.py
2013-03-21 10:49:04 -04:00
Will Daly
2fc96d5fb7
Fixed a merge issue about code response
2013-03-20 17:18:26 -04:00
Will Daly
7a282a9c54
Edited comments, ran pep8
2013-03-20 17:08:19 -04:00
Will Daly
911308cba2
Changed check for unanswered problems so that it now looks for
...
an "unanswered" div or span. This is much faster than
asserting that correct/incorrect is NOT present.
2013-03-20 17:08:19 -04:00
Will Daly
f69778b367
Changed lettuce test log_in step to log in programatically
...
rather than using the login dialog.
2013-03-20 17:08:19 -04:00
Diana Huang
af1af8c6d1
Address code review feedback:
...
- improve docstrings
- only pass in the state for a particular input and
not the whole dictionary
- refactor some common code
- minor syntax cleanup
2013-03-20 14:14:54 -04:00
David Ormsbee
f133d3181b
Merge pull request #1706 from MITx/fix/cale/simple-lazy-object
...
Force instantiation of the user before querying
2013-03-20 11:08:57 -07:00
Jay Zoldak
23364d8b0f
Merge branch 'master' into feature/zoldak/refactor-factories
2013-03-20 13:36:01 -04:00
Calen Pennington
154a441033
Only use .pk for queries, and not on inserts
2013-03-20 13:24:25 -04:00
Calen Pennington
cbed66280a
Fix pep8 and pylint errors
2013-03-20 13:20:28 -04:00
Calen Pennington
36443163f6
Force instantiation of the user before querying
...
Without accessing .pk, it's possible for the user object to still be a
SimpleLazyObject, which breaks Django's query engine
http://stackoverflow.com/questions/11875737/django-filtering-drafts-by-user-causes-error
2013-03-20 12:59:34 -04:00
Jay Zoldak
6048bc2832
Pep8 fixes for factory refactor
2013-03-20 11:31:12 -04:00
Will Daly
5411fc765e
Refactored lettuce test of capa problems to use
...
world.css_click() helper instead of directly
calling splinter.
2013-03-20 11:27:28 -04:00
Will Daly
2867476115
Added __init__.py and test_mock_xqueue_server.py,
...
which should have been included in the last commit
2013-03-20 11:18:41 -04:00
Will Daly
8f055ab037
Moved mock_xqueue_server to its own subpackage within
...
lms/djangoapps/courseware/
Separated tests of the mock server into test_mock_xqueue_server.py
2013-03-20 11:14:42 -04:00
Jay Zoldak
16773aac63
More factory refactoring.
2013-03-20 09:38:53 -04:00
Jay Zoldak
3576a3154b
Repoint factory references in lettuce tests to world.
2013-03-20 09:38:52 -04:00
Diana Huang
eda6169b8b
Pass along a url creator as opposed to just a url through
...
the ModuleSystem.
2013-03-20 09:23:25 -04:00
Will Daly
e7f8c7c676
pep8 fixes
2013-03-19 16:00:43 -04:00
Will Daly
39aa25c2d6
Removed file that was added accidentally.
2013-03-19 15:57:24 -04:00
Will Daly
66434d7d05
Moved XQueue mock from terrain into LMS, so that the
...
server is not created for cms tests.
2013-03-19 15:55:05 -04:00
Will Daly
20ccf5937b
Implemented CodeResponse lettuce tests
2013-03-19 15:55:05 -04:00
Arthur Barrett
0710bbd70c
Merge branch 'master' into feature/abarrett/lms-notes-app
2013-03-19 13:43:45 -04:00
Calen Pennington
0209c883bb
Remove trailing whitespace
2013-03-19 10:41:38 -04:00
Will Daly
568f557dfc
Pep8 fixes
...
Changed constant to uppercase
2013-03-18 13:57:26 -04:00
Will Daly
e41bb8462c
Added lettuce tests for script (customresponse) problems.
...
Increased wait time for login screen to reduce false positives.
2013-03-15 14:04:22 -04:00
Will Daly
8423816076
LMS contentstore lettuce tests now dynamically create courses in mongo
...
using terrain.factories.py and capa.tests.response_xml_factory
2013-03-15 14:04:22 -04:00