Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
58,450 Commits 1 Branch 0 Tags
079f43f40d399cfc0da17039b6dede4e06bda2fb
Commit Graph

9300 Commits

Author SHA1 Message Date
M. Zulqarnain
39b109a9ad Fixed bad escape character (#24316) 
As of Python 3.7, a backslash-character pair that is not a valid escape sequence now generates an error, earlier it was a deprecation warning.
 2020-06-24 18:23:11 +05:00
Awais Qureshi
b7500cd2a0 Merge pull request #24268 from eduNEXT/lmm/safe_exec 
[BD-6] Fix test for python3.8
 2020-06-24 13:39:35 +05:00
Matthew Piatetsky
b3c2d37dcc Merge pull request #24214 from edx/REV-774 
[REV-774] Show content type gating upsell when a limited access learner tries to access a timed exam
 2020-06-23 11:48:31 -04:00
Luis Moreno
1d557616b1 Fix test for python3.8 2020-06-23 10:16:37 -04:00
Matthew Piatetsky
78317ca115 Show content type gating upsell when a limited access learner tries to access a timed exam 
Otherwise, these learners could start the timer and then be unable to take the exam once they have access to the content
REV-774
 2020-06-22 16:18:58 -04:00
leomartinez2019
943bd6f15b Fixing cgi.escape DeprecationWarning 
- Change cgi.escape to html.escape

- Add quote=False to html.escape

- Use function HTML() to address python-wrap-html warning
 2020-06-22 14:41:27 -04:00
Michael Roytman
361a2c92b3 Merge pull request #24266 from edx/mroytman/course-fields-exclude-list 
rename blacklist/whitelist to exclude list/include list in Course Met…
 2020-06-19 16:42:10 -04:00
Michael Roytman
6a21cd3f91 rename blacklist/whitelist to exclude list/include list in Course Metadata class 2020-06-19 14:33:41 -04:00
David Ormsbee
e69a5fce56 Merge pull request #24220 from open-craft/samuel/fix-youtube-metadata-api 
SE-2634 Fix crashes in yt_video_metadata
 2020-06-19 12:24:28 -04:00
David Ormsbee
0b4cf7e06c Merge pull request #23039 from open-craft/samuel/fix-unescaped-selector 
SE-2176 Fix elem not selected if id contains special chars
 2020-06-19 12:13:20 -04:00
Luis Moreno
398a8a2b23 Fix python 3.8 compatibility 2020-06-17 16:08:20 -04:00
Samuel Walladge
43f0cd72af Merge remote-tracking branch 'origin/master' into samuel/fix-unescaped-selector 2020-06-16 09:52:38 +09:30
Samuel Walladge
4da0c64cc3 Fix crashes in yt_video_metadata 
- yt_video_metadata returned a generic non-json-api-friendly 500 error
  when called on a non-youtube video
- load_metadata_from_youtube was crashing when called from the xblock
  yt_video_metadata endpoint. It passes a webob request, which has a
  different api for retrieving the http referer.
 2020-06-15 17:29:57 +09:30
David Ormsbee
4f3a45f444 Revert "[BB-112] Fix the unpredictable order randomization issue with randomized content blocks" 2020-06-08 16:47:35 -04:00
David Ormsbee
d507a5cd99 Merge pull request #23265 from open-craft/guruprasad/BB-112-fix-randomized-content-block-order 
[BB-112] Fix the unpredictable order randomization issue with randomized content blocks
 2020-06-08 10:11:48 -04:00
Feanil Patel
a88da3b5cd Merge pull request #24089 from edx/feanil/improve_import_error_logging 
Log what thing we failed to import.
 2020-05-29 15:52:45 -04:00
Feanil Patel
c15fae3564 Log what thing we failed to import. 
This should help more quickly narrow down where things are failing on an import.
 2020-05-29 13:24:10 -04:00
Dillon Dumesnil
826d5fe3da AA-167: Making the LTI icon class dynamic 
We will now show the problem icon if the LTI problem
is scored and 'other' if it is not.
 2020-05-28 07:18:18 -07:00
Ahtisham Shahid
1e103b2fdd Merge pull request #23996 from edx/ahtisham/PROD-1540 
Fixed Import error due to pre tag
 2020-05-20 21:56:34 +05:00
Ahtisham Shahid
4f5496f02c Fixed Import error due to pre tag 
Fixed regex for nested pre tags

Updated import export test

fixed quality test issue

fixed No exception type(s) specified

updated tests

fixed linter issue

fixed linter issue

fixed linter issue
 2020-05-20 13:17:53 +05:00
Guruprasad Lakshmi Narayanan
5a2b607ea6 Fix the order randomization behaviour of Randomized Content Block 
The Randomized Content Block XBlock only randomizes the selection of
the children blocks and has unpredictable randomization of
the order of the selected child blocks due to the usage of sets, which
are unordered, for storing the selected blocks. This becomes apparent
when all the available child blocks in a library are chosen for a
Randomized Content Block, to randomize just the order of the child
blocks and not just the selection of the blocks. The order of the
selected blocks ends up being similar for multiple learners.

This change modifies the XBlock to store the selected child blocks in
a list, instead of a set, after randomly shuffling them.
 2020-05-20 13:07:57 +05:30
Ben Warzeski
7778347aed remove old_format from team config tests 2020-05-15 14:44:23 -04:00
Awais Jibran
0dc5bacfb4 Adding logs in capa_base 2020-05-13 22:09:51 +05:00
Jeff LaJoie
972c7f3bc1 Merge pull request #23954 from edx/jlajoie/AA-163 
AA-163: Fixes duplicate dates tab issue
 2020-05-12 09:08:54 -04:00
Jeff LaJoie
ee0f4567a8 AA-163: Fixes duplicate dates tab issue 2020-05-12 08:38:14 -04:00
Ned Batchelder
3d179a0666 Merge pull request #22539 from open-craft/pooja/fix-autoadvance-not-working-for-hls-videos 
Enable auto start for HLS if autoadvance is set
 2020-05-11 11:52:52 -04:00
Ned Batchelder
b3b58690e6 Merge pull request #21507 from open-craft/guruprasad/youtube-api-missing-referer-fix 
[BB-1637] Pass the referer from the client to the YouTube API
 2020-05-11 11:46:57 -04:00
mariajgrimaldi
4bf975fdd8 changed count to count_documents (#23945) 
This PR contributes to the elimination of deprecation warnings, specifically the one mentioned above and reported in the Warnings Report: https://build.testeng.edx.org/job/edx-platform-python-pipeline-master/warning_5freport_5fall_2ehtml/ .

Changed collection.find(filter).count() to collection.count_documents(filter) in the following file:

    common/lib/xmodule/xmodule/modulestore/tests/test_split_modulestore.py

And collection.find(filter).limit(1).count() to collection.count_documents(filter, limit=1) in the following file:

    common/lib/xmodule/xmodule/modulestore/mongo/draft.py

The method count_documents is part of the collection, not the cursor (find returns a cursor), according to StackOverflow (https://stackoverflow.com/questions/56303331/warning-message-in-pymongo-count-is-deprecated). Because of that after changing count, I removed the calling to the find method and use the filter parameter in count_documents. Also, I removed limit because count_documents accepts limit parameter.

This warning occurs due to deprecation: https://pymongo.readthedocs.io/en/3.9.0/api/pymongo/collection.html#pymongo.collection.Collection.count_documents
 2020-05-11 08:28:45 -04:00
Adam Butterworth
307cb30208 Swap deprecated box-sizing mixin with the box-sizing property (#23928) 
* Swap deprecated box-sizing mixin with the box-sizing property

* Linting now that box-sizing is no longer a mixin
 2020-05-08 11:27:51 -04:00
Shadi Naif
7142d55b1a Missing translation function call 2020-05-07 14:32:50 +03:00
Simon Chen
262574b815 Move all the upgrade display logic into courseware.utils 2020-05-05 17:54:22 -04:00
Simon Chen
f8cc58618a Create a new plugin manager called DynamicPartitionGenerators to remove the dependency of openedx.features.content_type_gating by xmodule.partition_services 2020-05-04 11:16:26 -04:00
Samuel Walladge
71fcf6e725 Fix issues with xss linters 
Improve accuracy of javascript-escape linter: Previously this would
match on FOOescape() and FOO.escape calls, but neither are the global
escape function we are worried about.

The regex probably isn't 100% accurate; there may be still false
positives (javascript allows a large range of characters in identifiers,
some of which may not be covered by [\w.$]). The main thing is to avoid
false negatives here though - this will definitely catch any use of
`escape()` or `window.escape()`.

Also remove javascript-interpolate lint - this was deemed unecessary.
StringUtils.interpolate is not in fact safe (it does no html escaping),
so the results of this lint are misleading.
 2020-05-04 09:27:18 +09:30
Aarif
98af9ce418 remove useless-supression warnings 2020-05-01 19:42:15 +05:00
Michael Terry
0f81765ac7 Show graded icons in more places 
In the course outline, if a subsection has any graded content,
show a graded icon (the pencil icon).

Also, show the graded icon for LTI xmodule units (xblocks is a
different repo, but will get same treatment).

AA-75
 2020-04-24 14:16:32 -04:00
Saad Yousaf
5263774838 Merge pull request #23660 from edx/saad/PROD-1404-logs-cleanup3 
[PROD-1404] - fix getargspec() DeprecationWarning for inspect to cleanup logs.
 2020-04-15 23:17:53 +05:00
SaadYousaf
d361634067 fix getargspec() DeprecationWarning for inspect. 2020-04-15 15:15:31 +05:00
SaadYousaf
9160d4aa9b address deprecation warning for cgi.escape for logs cleanup. 2020-04-15 15:14:00 +05:00
Waheed Ahmed
ec747e4c27 Fix some submission error message related bugs. 
During another bug investigation I figured there are some
issues related to showing error messages to learners upon
submission.

PROD-1431
 2020-04-10 17:01:56 +05:00
Tehreem Sadat
eef904bfef fix broken tests (#23680) 
Tests were failing due to the "404 Error" Response from an API that fetches specific asset (video transcript data) from YouTube.

I have changed it by using a mocked API response instead of direct API call to the Youtube server.
 2020-04-09 16:05:13 -04:00
Alan Zarembok
5371be1c60 Skip tests that are failing due to missing youtube content. 2020-04-09 11:05:10 -04:00
Aarif
6ee2089077 fixed warnings for wrong-import-order 2020-04-08 23:43:06 +05:00
Zachary Hancock
2cbc248a63 prevent empty string passing proctoring provider validation (#23610) 2020-04-06 09:45:10 -04:00
Jeremy Bowman
5c40a3729a Stop using deprecated assertions (#23579) 
Replace some usage of deprecated assertions with non-deprecated equivalents.
 2020-04-02 11:06:37 -04:00
Ali Akbar
358b181bdf Merge pull request #23481 from edx/aakbar/demandhint-static-link-fix 
add static links re-write for demnadhint tag
 2020-03-31 15:04:33 +05:00
Adam Butterworth
d53ab876e2 Fix public view of video xmodule (#23518) 
TNL-7092 Properly include video javascripts for the video public view
 2020-03-30 11:03:48 -04:00
Ned Batchelder
136003fcff Merge pull request #23015 from Abstract-Tech/fix/non-admin-error-descriptor 
Add xblock.v1 and xmodule.v1 entrypoints for NonStaffErrorDescriptor
 2020-03-27 17:43:16 -04:00
Ahtisham Shahid
42ccc5564c Merge pull request #23498 from edx/ahtisham/PROD-1232 
Fixed \n escape issue in import-export
 2020-03-27 18:39:29 +05:00
Ahtisham Shahid
f264e5dd03 fixed \n escape issue in import 
updated test

updated test
 2020-03-27 12:29:32 +05:00
asadazam93
fc3e63714e Fixed comparison mismatch 2020-03-26 14:11:31 +05:00