Victor Shnayder
987b9c11a9
Use url_name for chapters and sections in lms views
...
* got rid of the hackish conversions between ' ' and '_'
* use url_name and display_name where appropriate
* update templates to match.
2012-08-02 14:28:44 -04:00
Victor Shnayder
26ae88faac
Factor out get_item_error() into a new ModuleStoreBase class
...
* may be temporary if we move errors into the items themselves.
2012-08-02 13:41:54 -04:00
Victor Shnayder
64346d727b
todos and comments
2012-08-02 11:33:53 -04:00
Victor Shnayder
31b8270cfb
remove too-clever lazy dictionary
2012-08-02 10:14:35 -04:00
Victor Shnayder
41eca8a0a5
Move files into xmodule module per comment on #326
...
* move html_checker.py
* move stringify.py
* move tests into module
* remove duplicate progress.py
* fix module imports
2012-08-02 10:13:58 -04:00
Brittany Cheng
8febbf249f
Merge branch 'master' of github.com:MITx/mitx into discussion2
2012-08-02 10:06:43 -04:00
Victor Shnayder
fc0f938eae
Responding to comments on pull #326
...
* cleaned up error module:
- only one template
- save error message in xml and reload
* better display of problem definition and metadata to staff
* save error messages as string, not exception objects.
2012-08-02 09:56:01 -04:00
Victor Shnayder
e2ce54612c
remove debugging assert from test
2012-08-01 19:25:47 -04:00
Victor Shnayder
652e2aa24c
fix for inheriting metadata bug
...
* problem was on import to json--got all the metadata,
but didn't preserve the _inherited_metadata
* added own_metadata property, use it instead
2012-08-01 19:25:47 -04:00
Victor Shnayder
82899323e8
Add metadata inherit test
...
* also make a placeholder roundtrip export test
2012-08-01 19:25:47 -04:00
Brittany Cheng
ae89aac6ce
Merge branch 'master' of github.com:MITx/mitx into discussion2
2012-08-01 18:07:52 -04:00
Kyle Fiedler
cdd37eeb92
Strip down sequence navigaiton and more stripping of the courseware nav
2012-08-01 17:36:10 -04:00
Rocky Duan
0dccfc0a8d
forgot to change template name
2012-08-01 16:47:20 -04:00
Rocky Duan
5d3b187540
Merge branch 'master' of github.com:MITx/mitx
2012-08-01 16:45:21 -04:00
Victor Shnayder
ea26c25cb4
add back-compat code to customtag
...
* apparently 6002x is using the impl-as-child structure already.
2012-08-01 16:33:28 -04:00
Rocky Duan
777c3ee42c
Merge branch 'master' of github.com:MITx/mitx
...
Conflicts:
lms/djangoapps/courseware/views.py
lms/templates/profile.html
2012-08-01 12:49:00 -04:00
Victor Shnayder
7fb831a2e8
Record warning on bad html files
2012-08-01 11:48:19 -04:00
Victor Shnayder
05c22c4901
Prettier error display
...
* Log formatted traceback string instead of exc_info tuple itself
* display as a list
2012-08-01 11:48:19 -04:00
Victor Shnayder
32253510d1
Import error cleanup
...
* call error tracker when needed
* remove duplicate logging--just add info and re-raise
* xml modulestore uses error tracker to capture load errors
* add unstyled list of import errors to courseware homepage!
2012-08-01 11:48:19 -04:00
Victor Shnayder
740c9b7df1
fixed docstring for customtag
2012-08-01 11:48:18 -04:00
Victor Shnayder
0b67d1c401
Turn error_handlers into error_trackers
...
* simplify logic--tracker just tracks errors. Trackers should not raise,
and are not be responsible for logging.
* adapted code to use trackers.
* Started cleanup of error handling code:
- if need to add info and re-raise, just do that. No logging.
- if working around a problem, log and track as needed.
2012-08-01 11:48:18 -04:00
Victor Shnayder
009bd23066
save LazyLoadingDict in case we do want it later
2012-08-01 11:48:18 -04:00
Victor Shnayder
c0cdff7071
Rename MalformedDescriptor to ErrorDescriptor
...
* change references and tests
* add staff/non-staff display
* added is_staff to ModuleSystem
2012-08-01 11:42:39 -04:00
Victor Shnayder
707551b08d
local variable naming tweak
2012-08-01 11:40:12 -04:00
Victor Shnayder
0edc40de34
Address minor comments in #313
2012-08-01 11:40:12 -04:00
Victor Shnayder
0ae434cc09
Move path_to_location out of mongo.py
...
* also bugfix for load_definition in html_module
* a bit of refactoring of Location checking code in mongo.py
2012-08-01 11:40:12 -04:00
Victor Shnayder
ed35cefa29
Fix html file handling.
...
* html files are now stored as follows:
If the html file is valid xml, store as html/stuff.xml
If it's not, store as html/stuff.xml, which contains
<html meta1="..." filename="stuff.html">,
and html/stuff.html, which actually contains the contents.
Warn if the contents are not parseable with lxml's html parser,
but don't error.
* for parseable html, strip out the html tag when storing, so that it isn't
rendered into the middle of a page
* lots of backcompat to deal with paths. Can go away soon.
* fix output ordering in clean_xml
2012-08-01 11:40:12 -04:00
Victor Shnayder
d750d945fd
Remove malformed tags when contents aren't malformed anymore.
2012-08-01 11:40:12 -04:00
Victor Shnayder
0d83d2e645
Add roundtrip test for malformed module
...
* also fix error message in backcompat_module
2012-08-01 11:40:11 -04:00
Victor Shnayder
53608922ba
Make the malformed descriptor import properly
...
* Also get rid of lazy loading of metadata and definition
2012-08-01 11:40:11 -04:00
Victor Shnayder
ef6da22ac3
Add a fallback MalformedDescriptor
...
* when things don't load normally, use this
* separate raw editing functionality into EditingDescriptor
* raw descriptor just enforces that xml is valid
* add a MalformedDescriptor that just saves a string
* Fallback to it on import.
2012-08-01 11:40:11 -04:00
Victor Shnayder
4e6a9b0df7
Add kwargs back to DescriptorSystem init()s
...
* allow future expansion without breaking interface.
2012-08-01 11:40:11 -04:00
Calen Pennington
ef8a211b9e
Merge pull request #329 from MITx/MITx/feature/bridger/fast_course_grading
...
Got profile page working again.
2012-08-01 08:37:16 -07:00
Bridger Maxwell
ae3da772d0
Got profile page working again. The grader for each course is now defined in the data dir as grading_policy.json.
2012-08-01 11:27:04 -04:00
Brittany Cheng
f637ca5120
Merge branch 'master' of github.com:MITx/mitx into discussion2
2012-08-01 09:44:45 -04:00
ichuang
b9773b5d17
Merge pull request #323 from MITx/kimth/lms-coderesponse
...
Kimth/lms coderesponse
2012-07-31 19:45:55 -07:00
Brittany Cheng
f1e07024d4
Merge branch 'master' of github.com:MITx/mitx into discussion2
2012-07-31 18:43:21 -04:00
Kyle Fiedler
d30ae5389e
Added fix for videos start to zero out colors and mit styles
2012-07-31 14:18:42 -04:00
kimth
2e3c5de1a5
Remove hardcoding of LMS callback URL and default queuename
2012-07-31 14:08:02 -04:00
Rocky Duan
c39b2db678
retrieve inline discussion by ajax
2012-07-31 13:22:25 -04:00
Rocky Duan
ada66adff6
Merge branch 'master' of github.com:MITx/mitx
2012-07-31 10:12:06 -04:00
ichuang
94e73936fc
Merge pull request #319 from MITx/kimth/lms-coderesponse
...
Kimth/lms coderesponse
2012-07-30 18:51:16 -07:00
kimth
6d600ecf2c
Merge branch 'master' into kimth/lms-coderesponse
2012-07-30 20:42:10 -04:00
Rocky Duan
8228bebc2a
Merge branch 'master' of github.com:MITx/mitx
...
Conflicts:
lms/djangoapps/courseware/module_render.py
lms/djangoapps/courseware/views.py
lms/envs/common.py
2012-07-30 17:41:19 -04:00
Calen Pennington
ab0055c201
Add update_schematic to window in schematic.js
2012-07-30 14:04:39 -04:00
Calen Pennington
395cf147be
Look up data_dir in the metadata, not in the top of the json object when loading from mongodb
2012-07-30 14:04:39 -04:00
Calen Pennington
2caf1024f1
Force mongodb fs_root to be a path object
2012-07-30 14:04:15 -04:00
Calen Pennington
d0c99151f0
Continue during backcompat imports by replacing contents with error xml
2012-07-30 14:04:15 -04:00
Calen Pennington
66d5c8effd
Add more detail to error messages during loading from xml
2012-07-30 13:50:50 -04:00
Calen Pennington
6997fc579e
Continue on errors when syncing with github
2012-07-30 13:50:00 -04:00