David Ormsbee
43d8c7a712
Merge branch 'release'
...
Conflicts:
lms/djangoapps/shoppingcart/processors/CyberSource2.py
2014-11-13 10:11:12 -05:00
Will Daly
c8751b5b4a
Add CSRF cookie to combined login/registration form
...
Add CSRF check for login/registration views.
2014-11-12 16:15:20 -05:00
Renzo Lucioni
2fc2207bd2
Merge pull request #5905 from edx/renzo/pep8-pylint-cleanup
...
Clean up pep8 and pylint violations
2014-11-12 14:34:03 -05:00
Renzo Lucioni
8d02efb021
Clean up pep8 and pylint violations
...
Also fixes failing Python unit tests
2014-11-12 12:55:56 -05:00
Stephen Sanchez
fc8b2a5f37
Merge pull request #5720 from edx/sanchez/avoid_event_suppression
...
Changing event suppression to signal suppression.
2014-11-12 12:46:26 -05:00
stephensanchez
6e85ec0739
Changing event suppression to signal suppression.
...
Code review changes.
Fix test and pylint.
pylint error.
Updating the test to verify the signal is fired.
Test for all analytics events
Import pylint error.
Pylint error
2014-11-12 16:26:29 +00:00
Will Daly
1537086a9b
Merge pull request #5930 from edx/will/logistration-handle-redirects
...
Logistration: Clean up redirect logic
2014-11-12 11:23:48 -05:00
Will Daly
ce158cf54e
Merge pull request #5929 from edx/will/logistration-fix-cancel-third-party-auth
...
Logistration: Redirect to a valid URL when cancelling third party auth
2014-11-12 10:49:20 -05:00
Will Daly
02485be3e3
Clean up redirect logic
2014-11-12 10:27:25 -05:00
Renzo Lucioni
34dd4e59a1
Merge pull request #5914 from edx/renzo/final-text-review
...
Final text review
2014-11-12 09:55:48 -05:00
Will Daly
d50137bb64
Redirect to a valid URL when cancelling third party auth
2014-11-12 09:33:06 -05:00
stv
1164624fbc
Fix PEP8: W291 trailing whitespace
2014-11-10 19:31:09 -08:00
stv
500499b678
Fix PEP8: E231 missing whitespace after '[:,]'
2014-11-10 19:31:05 -08:00
stv
00ae488960
Fix PEP8: E225 missing whitespace around operator
2014-11-10 19:30:18 -08:00
stv
96ce219d80
Fix PEP8: E211 whitespace before '('
2014-11-10 19:30:17 -08:00
stv
0196048359
Fix PEP8: E202 whitespace before '}'
2014-11-10 17:07:41 -08:00
stv
0fdf8fb222
Fix PEP8: E201 whitespace after '{'
2014-11-10 17:07:40 -08:00
Greg Price
db8dd8de64
Fix OAuth token login endpoint to set session user
2014-11-10 18:06:25 -05:00
AlasdairSwan
790ac3f3ef
Merge pull request #5915 from edx/alasdair/rwd-trackselection
...
ECOM-574 Updated track selection page to be responsive
2014-11-10 16:41:50 -05:00
Renzo Lucioni
6defcaa0af
Final text review
2014-11-10 16:33:37 -05:00
Greg Price
96b5637bef
Merge pull request #5911 from edx/gprice/login-oauth-csrf-exempt
...
Make OAuth token login endpoint CSRF exempt
2014-11-10 16:28:11 -05:00
AlasdairSwan
23081f076b
ECOM-574 Updated track selection page to be responsive
2014-11-10 15:39:17 -05:00
Sarina Canelake
0bf0d11a20
Merge pull request #5906 from stvstnfrd/pep8/newline
...
Fix newline-related PEP8 issues
2014-11-10 15:29:06 -05:00
Greg Price
9270c7c77d
Make OAuth token login endpoint CSRF exempt
2014-11-10 15:20:35 -05:00
Chris Dodge
58b4982d2d
harden down access to the shoppingcart if the ENABLE_PAID_COURSE_REGISTRATION flag is not set (either via the main Django configuration settings) or through microsite overrides
2014-11-10 15:09:48 -05:00
Will Daly
5085b71677
Merge remote-tracking branch 'origin/master' into will/combine-reg-login-form
...
Conflicts:
common/djangoapps/third_party_auth/pipeline.py
lms/djangoapps/verify_student/tests/test_views.py
2014-11-10 15:05:37 -05:00
stv
5677b143db
Fix PEP8: W391 blank line at end of file
2014-11-10 11:00:18 -08:00
stv
fb9f324f2f
Fix PEP8: E303 too many blank lines
2014-11-10 11:00:14 -08:00
stv
cf9308144d
Fix PEP8: E302 expected 2 blank lines, found 1
2014-11-10 11:00:11 -08:00
stv
d5d6e3f0d8
Fix PEP8: W293 blank line contains whitespace
2014-11-10 10:59:53 -08:00
stv
d87cfa90bf
Fix PEP8: W292 no newline at end of file
2014-11-10 10:59:44 -08:00
Will Daly
c150ea76aa
Merge pull request #5890 from edx/will/logistration-auto-enroll-register
...
Logistration: Auto-enroll fails after registering a new account
2014-11-10 12:23:28 -05:00
David Baumgold
18083e9879
Use @require_POST decorator for password reset view
2014-11-10 12:07:22 -05:00
AlasdairSwan
b9998b6d5b
Merge pull request #5899 from edx/alasdair/logistration-select-validation
...
ECOM-626 Added required check for select dropdowns and validation
2014-11-10 11:54:20 -05:00
AlasdairSwan
cb5c03f0d1
ECOM-626 Added required check for select dropdowns and validation
2014-11-10 11:06:52 -05:00
Will Daly
95a435abc5
Include course ID in analytics events for logistration
2014-11-10 10:23:34 -05:00
Will Daly
b8f5be2cdd
Allow inactive users to modify their own enrollments
2014-11-10 08:10:47 -05:00
Waheed Ahmed
3a71901f93
Fixed youtube stub server and removed unused variable.
...
TNL-778
2014-11-10 11:43:58 +05:00
Will Daly
578c04f62f
Put logistration page behind a feature flag
2014-11-07 13:05:17 -05:00
Will Daly
e629ce2ba6
Move redirection/enrollment to AccessView and trigger it using an event.
...
Ensure window.isExternal is loaded
Don't set a default for terms of service
For paid courses, add the course to the cart and redirect to the shopping cart view.
Don't send form method and url as form data.
Stub window.analytics in the access view test.
2014-11-07 12:59:08 -05:00
Renzo Lucioni
bedd6cc2f5
Jasmine tests of validation utility
...
Includes a modification of validation logic which performs min and max length checks on optional fields in addition to required fields.
2014-11-07 10:44:25 -05:00
chrisndodge
01c029aa9f
Merge pull request #5805 from edx/cdodge/make-customizeable-region-in-receipt-page
...
allow for a customized region on the receipt page that is microsite bran...
2014-11-06 21:13:43 -05:00
Renzo Lucioni
f9ecd8849a
Fix logistration Jasmine tests
...
Includes several bug fixes caught during test writing, general clean-up, and adds js-url, a lightweight URL parser
2014-11-06 12:07:49 -05:00
Renzo Lucioni
edba397a20
Return more helpful error messages when a resource conflict occurs
2014-11-05 22:36:27 -05:00
Greg Price
d2183c58c8
Add endpoint to log in with OAuth access token
2014-11-05 14:09:41 -05:00
Muhammad Ammar
e8e7e78e09
Merge pull request #5655 from edx/ammar/unit-improvements
...
Unit Test Improvements
2014-11-05 19:55:39 +05:00
Diana Huang
a971e71792
Merge branch 'will/logistration-third-party-auth-fixes' into will/combine-reg-login-form
...
Conflicts:
common/djangoapps/course_modes/views.py
2014-11-04 10:50:09 -05:00
Sarina Canelake
bc20ccb332
Merge pull request #5828 from edx/sarina/moar-pep8
...
Remove more pep8 violations
2014-11-04 08:58:17 -05:00
Sarina Canelake
725e4908e3
Remove more pep8 violations
2014-11-04 07:37:41 -05:00
Gabe Mulley
821c97fbb4
Implement shim for mobile video events.
...
This PR addresses the following issues:
1) All requests return a 200 OK unless there is an authorization failure. This is deliberate in case the secret key is compromised.
2) Push all of the nasty logic necessary to generate compatible video events into the LMS instead of trying to do that mapping on the mobile devices.
3) Stop using the deprecated "action" field in the segment.io event. According to their support team this field should not be used anymore and is just around for backwards compatibility reasons.
Fixes: AN-3818
2014-11-03 14:12:07 -05:00