This commit removes several waffle toggles that have been enabled
on edx.org for years. It's time to remove the rollout gating for
these features and enable them by default.
This doesn't directly change any behavior. But it does create new
database objects by default now and allows for enabling other
schedule based features more easily.
Specifically, the following toggles were affected.
schedules.create_schedules_for_course
- Waffle flag removed as always-enabled
- We now always create a schedule when an enrollment is created
schedules.send_updates_for_course
- Waffle flag removed as always-enabled
- Course update emails are sent as long as the ScheduleConfig
allows it.
- This is not a change in default behavior, because ScheduleConfig
is off by default.
dynamic_pacing.studio_course_update
- Waffle switch removed as always-enabled
- Course teams can now always edit course updates directly in Studio
ScheduleConfig.create_schedules
ScheduleConfig.hold_back_ratio
- Model fields for rolling out the schedules feature
- Schedules are now always created
- This commit only removes references to these fields, they still
exist in the database. A future commit will remove them entirely
This commit also adds a new has_highlights field to CourseOverview.
This is used to cache whether a course has highlights, used to
decide which course update email behavior they get. Previously every
enrollment had to dig into the modulestore to determine that.
By explicitly importing the legacy namespace classes, we make it clear
that we are using soon-to-be-deprecated classes. We will then be able to
start removing the legacy classes, one module at a time.
* Generate common/djangoapps import shims for LMS
* Generate common/djangoapps import shims for Studio
* Stop appending project root to sys.path
* Stop appending common/djangoapps to sys.path
* Import from common.djangoapps.course_action_state instead of course_action_state
* Import from common.djangoapps.course_modes instead of course_modes
* Import from common.djangoapps.database_fixups instead of database_fixups
* Import from common.djangoapps.edxmako instead of edxmako
* Import from common.djangoapps.entitlements instead of entitlements
* Import from common.djangoapps.pipline_mako instead of pipeline_mako
* Import from common.djangoapps.static_replace instead of static_replace
* Import from common.djangoapps.student instead of student
* Import from common.djangoapps.terrain instead of terrain
* Import from common.djangoapps.third_party_auth instead of third_party_auth
* Import from common.djangoapps.track instead of track
* Import from common.djangoapps.util instead of util
* Import from common.djangoapps.xblock_django instead of xblock_django
* Add empty common/djangoapps/__init__.py to fix pytest collection
* Fix pylint formatting violations
* Exclude import_shims/ directory tree from linting
Instead of going up the stacktrace to find the module names of waffle
flags and switches, we manually pass the module __name__ whenever the
flag is created. This is similar to `logging.getLogger(__name__)`
standard behaviour.
As the waffle classes are used outside of edx-platform, we make the new
module_name argument an optional keyword argument. This will change once
we pull waffle_utils outside of edx-platform.
Note that the module name is normally only required to view the list of
existing waffle flags and switches. The module name should not be
necessary to verify if a flag is enabled. Thus, maybe it would make
sense to create a `add` class methor similar to:
class WaffleFlag:
@classmethod
def add(cls, namespace, flag, module):
instance = cls(namespace, flag)
cls._class_instances.add((instance, module))
* Enforce limit on number of blocks allowed in library (blockstore)
* Enforce limit on number of blocks allowed in library (modulestore)
* Changes from review feedback
* Disable changing special exam type after release date
Do some client-side validation to make sure that exams
that *are* or *ever were* special may not be changed
to a special exam type (other than the current one)
after release date.
MST-258
Co-authored-by: Zach Hancock <zhancock@edx.org>
In a follow-up PR, this entry will be used to validate
on the client-side that a block that *is* or *ever was*
a proctored/practice/onboarding exam cannot be configured
as a different proctored/practice/onboarding exam, as that
has led to problematic exam configuration states between
edX and proctoring providers.
MST-258
Quality / encoding
Remove comments
remove debug
Changed service implementation to make unit testing easier
Corrected service
code style
unit test cleanup
Clean up imports
Improves navigation within Studio for Learning Sequences, speeding up authors who want to see how a learner progresses through content without needing to jump over to the LMS.
This adds a dropdown section navigator to the breadcrumbs on the unit page and copies the sequence navigator from LMS to the studio unit page.
None type comparison with int was not working in python3.
There was an issue with previous condition also. with Nonetype it was not coming into error part.
To toggle proctored exam advanced settings
waffle flag - test_settings.show_review_rules
To toggle proctored exam advanced settings
waffle flag - test_settings.show_review_rules
To toggle proctored exam advanced settings
acceptance testing update.
waffle flag - test_settings.show_review_rules
To toggle proctored exam advanced settings
acceptance testing update.
waffle flag - test_settings.show_review_rules
To toggle proctored exam advanced settings
acceptance testing update.
waffle flag - studio.show_review_rules
To toggle proctored exam advanced settings
acceptance testing update.
Added CR comments - moved UI vis toggle to template instead of js. Moved waffle flag to waffle.py
waffle flag - studio.show_review_rules
To toggle proctored exam advanced settings
acceptance testing update.
Added CR comments - moved UI vis toggle to template instead of js. Moved waffle flag to waffle.py
waffle flag - studio.show_review_rules
To toggle proctored exam advanced settings
acceptance testing update.
Added CR comments - moved UI vis toggle to template instead of js. Moved waffle flag to waffle.py
Updated JS UT and acceptance
Move common/djangoapps/enrollment to openedx/core/djangoapps/enrollments
Fix Pylint for enrollments
README for enrollments app
Move command arguments to common settings
Move command parameter arguments, resend-days and days-range, to
common settings. This will help in creating a consistency when the
default values are changed in the future.
LEARNER-7313
Bumped edx-enterprise version and added cornerstone app
Updating Bokchoy testing database cache (#20713)
complete waiting enrollments. fixed
Remove microsites from user_authn
DEPR-30
Remove microsites from certificates
DEPR-26
Remove microsites from shoppingcart
DEPR-27
Updating Bokchoy testing database cache (#20715)
add arch decision of computation of course-user discount
Mark missing string for internationalization
Remove microsites from static_template_view
DEPR-28
README for commerce and shoppingcart
README for certificates
README for course_experience
geoip2: update maxmind geolite country database
user existence check updated to use email only
Bumped edx-when
Use our fork of this repo instead of the mitocw one.
Make platform bootstrap footer match other footer
Changes:
- Add logo back
- Fix up spacing
- Change font sizes and color
Mark alt text for translation
waffle flag - test_settings.show_review_rules
To toggle proctored exam advanced settings
waffle flag - test_settings.show_review_rules
To toggle proctored exam advanced settings
waffle flag - test_settings.show_review_rules
To toggle proctored exam advanced settings
acceptance testing update.
waffle flag - test_settings.show_review_rules
To toggle proctored exam advanced settings
acceptance testing update.
waffle flag - test_settings.show_review_rules
To toggle proctored exam advanced settings
acceptance testing update.
waffle flag - studio.show_review_rules
To toggle proctored exam advanced settings
acceptance testing update.
Added CR comments - moved UI vis toggle to template instead of js. Moved waffle flag to waffle.py
waffle flag - studio.show_review_rules
To toggle proctored exam advanced settings
acceptance testing update.
Added CR comments - moved UI vis toggle to template instead of js. Moved waffle flag to waffle.py
waffle flag - studio.show_review_rules
To toggle proctored exam advanced settings
acceptance testing update.
Added CR comments - moved UI vis toggle to template instead of js. Moved waffle flag to waffle.py
Updated JS UT and acceptance
Move common/djangoapps/enrollment to openedx/core/djangoapps/enrollments
Fix Pylint for enrollments
README for enrollments app
Move command arguments to common settings
Move command parameter arguments, resend-days and days-range, to
common settings. This will help in creating a consistency when the
default values are changed in the future.
LEARNER-7313
Bumped edx-enterprise version and added cornerstone app
Updating Bokchoy testing database cache (#20713)
complete waiting enrollments. fixed
Remove microsites from user_authn
DEPR-30
Remove microsites from certificates
DEPR-26
Remove microsites from shoppingcart
DEPR-27
Updating Bokchoy testing database cache (#20715)
add arch decision of computation of course-user discount
Mark missing string for internationalization
Remove microsites from static_template_view
DEPR-28
README for commerce and shoppingcart
README for certificates
README for course_experience
geoip2: update maxmind geolite country database
user existence check updated to use email only
Bumped edx-when
Use our fork of this repo instead of the mitocw one.
Make platform bootstrap footer match other footer
Changes:
- Add logo back
- Fix up spacing
- Change font sizes and color
Mark alt text for translation
Initial changes to gate section based on completion percentage
code refactoring and added evaluation of completion milestone
Fixed broken unit tests and added new tests
Fixed broken tests and quality violations
Fixed Pep8 violation
Fixed eslint quality violations
Test changes as suggested by reviewer
changes after feedbacy from reviewer
Update the docstring with suggested changes
excluding chapter from the blocks
Disallow empty values for min score and min completion
Changes afte feedback from UX/Accessibility
removed blank line
