Commit Graph

4288 Commits

Author SHA1 Message Date
Aarif
01ac3c2ed3 replaced unittest assertions pytest assertions (#26308) 2021-02-11 17:41:41 +05:00
Aarif
2ea9ea916a replaced unittest assertions pytest assertions (#26287) 2021-02-11 17:40:23 +05:00
Feanil Patel
14e11cad3d Merge pull request #26460 from edx/feanil/always_squelch
feat: Update the user_authn app to not log PII by default.
2021-02-10 13:58:04 -05:00
stvn
ef77ddc18d Merge PR #26345 bd03/admin/enabled
* Commits:
  fix: Add DiscussionsConfiguration.enabled to admin page
2021-02-10 08:25:16 -08:00
stvn
d8d4b4a0cc Merge PR #26346 bd03/models/str
* Commits:
  style: Cleanup DiscussionsConfiguration.__str__
2021-02-10 08:23:49 -08:00
Feanil Patel
62c0aa4917 feat: Update the user_authn app to not log PII by default.
Instead of optionally not logging usernames and emails, do so by
default.  This mostly removes some complexity from the app and is makes
it so that it's more secure by default.

I considered the question of allowing people to log usernames and
e-mails if they wanted to but opted not to for a couple of reasons:

* It would involve adding a new feature flag that would be the opposite
of the SQUELCH_PII_IN_LOGS which would be a bit confusing.  When do you
use which one? or do you need both? etc.
* There is still a way to correlate the messages to eachother and in
most cases also to a specific user(email being the exception).
2021-02-10 10:14:58 -05:00
Waheed Ahmed
5c9c6176b6 Add skip_authn_mfe query param option.
Added to serve old login/register pages for the e2e tests
until new tests added or old ones are fixed for the Authn MFE.
2021-02-10 19:17:46 +05:00
edX requirements bot
a2635e9821 Python Requirements Update (#26463)
* Updating Python Requirements

* change namespaced_switch_name to name

Co-authored-by: Zulqarnain <muhammad.zulqarnain@arbisoft.com>
2021-02-10 16:25:34 +05:00
Adeel Ehsan
59bc5072cd Merge pull request #26459 from edx/aehsan/van-351/field_added_in_validate_decisions_for_authn
field added in validate decisions for authn
2021-02-10 01:14:21 +05:00
Feanil Patel
a482bc15e3 Merge pull request #26441 from edx/feanil/make_rate_limit_errors_429s
Make rate limit errors 429s instead of 403s
2021-02-09 15:07:22 -05:00
adeelehsan
bcfe2874fc field added in validate decisions for authn
VAN-351
2021-02-10 00:44:10 +05:00
Carla Duarte
7f7edd93c7 Merge pull request #26440 from edx/ciduarte/AA-590
AA-590: pass translated tab titles to MFE
2021-02-09 08:57:10 -05:00
usamasadiq
1e2aa1dec5 Apply manesty to convention warnings 2021-02-09 17:09:19 +05:00
jawad khan
95580b79a7 LEARNER-8218 Added BearerAuthenticationAllowInactiveUsern in celebration api
Added BearerAuthenticationAllowInactiveUsern in celebration api
2021-02-09 12:52:12 +05:00
Carla Duarte
00a025f073 AA-590: pass translated tab titles to MFE 2021-02-08 17:00:33 -05:00
Matt Tuchfarber
cabb5d928f Merge pull request #26292 from edx/tuchfarber/add_consistent_logging_credentials_tasks
Make credentials celery tasks errors consistent
2021-02-08 14:40:35 -05:00
Feanil Patel
cd3e4353b1 feat: Add a 403 and 429 handler.
See context here: https://django-ratelimit.readthedocs.io/en/latest/cookbook/429.html#context

For now we continue to fall back to django's default 403 handler for 403
but provide a new 429 template that we use for ratelimit exceptions.

This commit also updates a logistration test that relied on the old 403
behavior of django-ratelimit instead of the newly added 429 behavior.
2021-02-08 14:03:26 -05:00
Matt Tuchfarber
64032faae7 Make credentials celery tasks errors consistent
In order to better alert off of tasks that failed after maximum retries,
this makes the the error for each task consistent with itself.
2021-02-08 13:55:35 -05:00
Bianca Severino
54505b82c4 Merge pull request #26436 from edx/bseverino/proctoring-check-fix
[MST-645] Account for no enrollment in courseware rules
2021-02-08 13:39:40 -05:00
Bianca Severino
4fb36709a5 Account for no enrollment in courseware rules 2021-02-08 13:12:52 -05:00
Fox Piacenti
c840e6f9bb Update Library v2 Indexes to work with ElasticSearch 7. Repair blockstore integration tests. (#26230) 2021-02-08 11:55:47 -05:00
Usama Sadiq
7eb2c40106 Merge branch 'master' into usamasadiq/bom-2327-pylint-amnesty 2021-02-08 18:24:53 +05:00
Usama Sadiq
90666a6231 Merge pull request #26311 from edx/usamasadiq/bom-2305-pylint-amnesty
Applied pylint-amnesty
2021-02-08 18:23:34 +05:00
Muhammad Soban Javed
108859a550 Merge pull request #25954 from edx/iamsobanjaved/celery-tasks-openedx
Replace @task decorator with @shared_task in openedx
2021-02-08 18:23:22 +05:00
Usama Sadiq
78087152b8 Merge pull request #26387 from edx/usamasadiq/bom-2333-pylint-amnesty
Applied pylint amnesty
2021-02-08 18:20:51 +05:00
M. Zulqarnain
047a5f5f19 BOM-2319 : Pylint amnesty in openedx content apps (#26347)
* pylint amnesty in openedx content apps

Co-authored-by: Jawayria <jawayriahashmi@gmail.com>
2021-02-08 15:51:22 +05:00
usamasadiq
7bbde8f0f5 Applied pylint-amnesty 2021-02-08 13:00:22 +05:00
usamasadiq
e6d43ac69c Applied pylint amnesty 2021-02-08 12:45:57 +05:00
uzairr
d86550e1a3 reset-password-success-email 2021-02-06 15:41:56 +05:00
Aarif
b3b8e81148 replaced unittest assertions pytest assertions (#26267) 2021-02-05 23:54:11 +05:00
Waheed Ahmed
335915a933 Fix failed attempts and lockout messages for MFE.
VAN-342
2021-02-05 19:37:20 +05:00
Matthew Piatetsky
b91f720b7e Merge pull request #26293 from edx/AA-613
[AA-613] Return content type gate for staff users when masquerading as the Learner in Audit or Learner in Limited Access Roles
2021-02-05 09:18:34 -05:00
Matthew Piatetsky
ae7d0a1ed8 Return content type gate for staff users when masquerading as the Learner in Audit or Learner in Limited Access Roles
This is necessary to display the content type gate in the UI
AA-613
2021-02-04 17:34:16 -05:00
Carla Duarte
a08faaaa9c Merge pull request #26360 from edx/ciduarte/AA-635
AA-635: learner dashboard course card image bug
2021-02-04 14:58:53 -05:00
Usama Sadiq
2ea5e50b35 squash: remove duplicate amnesty message 2021-02-05 00:04:10 +05:00
usamasadiq
583f11363f Applied pylint amnesty 2021-02-04 20:16:35 +05:00
Usama Sadiq
047cc151f4 Merge pull request #26385 from edx/usamasadiq/bom-2332-pylint-amnesty
Applied pylint amnesty
2021-02-04 19:46:00 +05:00
usamasadiq
297dfd9718 Applied pylint amnesty 2021-02-04 19:14:40 +05:00
Bianca Severino
e5cc220d96 Merge pull request #26357 from edx/bseverino/proctored-exam-email
[MST-636] Add additional check for proctoring requirements
2021-02-04 09:09:12 -05:00
Waheed Ahmed
38187de0f9 Authn MFE: Toggle for microfrontend redirect.
VAN-308
2021-02-04 18:58:58 +05:00
Robert Raposa
87a3777a79 Merge pull request #26374 from regisb/regisb/no-future
[BD-21] Upgrade usage of edx_toggles.toggles
2021-02-04 08:43:06 -05:00
Jawayria
cf064be41a Merge pull request #26370 from edx/jawayria/bom-2328-pylint-amnesty
Applied pylint-amnesty to openedx apps
2021-02-04 18:40:17 +05:00
Soban Javed
5199bf7acb Replace task decorator with shared_task in openedx 2021-02-04 18:35:38 +05:00
Jawayria
3d19ee8272 Merge pull request #26372 from edx/jawayria/bom-2329-pylint-amnesty
BOM-2329: Applied pylint-amnesty to system_wide_roles, theming, user_…
2021-02-04 18:31:05 +05:00
Jawayria
ff3e9995fc Merge pull request #26375 from edx/jawayria/bom-2330-pylint-amnesty
BOM-2330: Applied pylint-amnesty to util, verified_track_content, vid…
2021-02-04 18:30:55 +05:00
Jawayria
d6061f03db Merge pull request #26381 from edx/jawayria/bom-2331-pylint-amnesty
BOM-2331: Applied pylint-amnesty to waffle_utils, xblock, xmodule_dja…
2021-02-04 18:30:42 +05:00
Jawayria
9ecbe15d91 BOM-2329: Applied pylint-amnesty to system_wide_roles, theming, user_api, user_authn 2021-02-04 18:00:51 +05:00
Jawayria
d37faa8270 BOM-2330: Applied pylint-amnesty to util, verified_track_content, video_config, video_pipeline 2021-02-04 17:52:58 +05:00
Jawayria
250c94dc6a BOM-2331: Applied pylint-amnesty to waffle_utils, xblock, xmodule_django, zendesk_proxy, __init__.py 2021-02-04 17:49:15 +05:00
M. Zulqarnain
e159ab8e4d Pylint amnesty in openedx plugin_api, profile_images and programs apps (#26377) 2021-02-04 17:10:38 +05:00