Commit Graph

23410 Commits

Author SHA1 Message Date
Ahtisham Shahid
00b53287d5 Added anonymous user id and extra params in program lti (#29429)
* fix: added anonymous user id and extra params in program lti

* refactor: updated flag name

* fix: fixed linter issues
2021-12-02 17:05:35 +05:00
Justin Hynes
ca867c105f Merge pull request #29410 from edx/jhynes/microba-1594_honor-certs-idv
fix: (MICROBA-1594) fix certificate generation logic for enrollment modes that don't require IDV but are cert eligible
2021-12-01 14:58:06 -05:00
Justin Hynes
df71aebdcf fix: [MICROBA-1594] fix cert generation logic for eligible modes that don't require IDV
[MICROBA-1594]

* Update course certificate generation logic when ID verification fails to check if the enrollment mode requires IDV.

This change fixes an issue where Honor certificates could not be generated in an Open edX installation unless a manual IDV override was added for the student.
2021-12-01 14:12:56 -05:00
Mubbshar Anwar
fec7849b26 feat: save for later (#29089)
send favorite course through email to user

VAN-741
2021-12-01 16:10:20 +05:00
Syed Muhammad Dawoud Sheraz Ali
2325150cf8 feat: add referrer url when submitting Zendesk support ticket (#29474)
* feat: add referrer url as a custom field when submitting zendesk support ticket
2021-12-01 13:52:57 +05:00
Dillon Dumesnil
2f2a6317a5 feat: AA-1055: Add in User Tours to the platform
User Tours are walkthroughs we are able to give in our frontends.
This sets up the backend support for them by creating the model,
setting up the initial backfill, adds in a signal handler to init
the UserTour model on User creation, and sets up some endpoints
to get user tour information and update it. It is also being
initialized with a waffle flag to control the rollout. The flag is
intended to control all tours and not allow for opting into only some tours.
2021-11-30 18:21:09 +00:00
JayRam Nai
5db9e01563 fix: toggle name for ENABLE_PASSWORD_RESET_FAILURE_EMAIL (#29317) 2021-11-30 10:10:23 -05:00
Jillian Vogel
ad5ad72273 [BD-13] Deprecate ModuleSystem.render_template (fixed) (#29354)
* refactor: deprecates ModuleSystem.render_template

in favor of the added MakoSystem render_template method.

Related changes:
* Adds the MakoService to the StudioEditModuleRuntime,
  PreviewModuleSystem, LmsModuleSystem, and XBlockRuntime
* MakoService constructor takes a `namespace_prefix` string, so that the
  CMS PreviewModuleSystem can render to LMS templates, without needing
  the special render_from_lms helper method.
* ModuleSystem.render_template becomes a read-only property, so the
  constructor calls and test module systems are updated accordingly.
* Adds tests for the MakoService and module system shims.

(cherry picked from commit 457f959356)

* refactor: use MakoService.render_template to remove deprecation warnings

from block code.

(cherry picked from commit 8d62d337f5)

* refactor: use MakoService.render_template to remove deprecation warnings

from test code.

(cherry picked from commit 26b43465a4)

* test: Adds a test to verify the bug introduced by the previous changes

The AuthoringMixin is automatically added to all XBlocks (see
settings.XBLOCK_MIXINS), and AuthoringMixin.visibility_view expects the
"mako" service.

This test verifies the bug by testing the PureXBlock, which does not
require the "mako" service, and so fails when the visibility_view is
rendered.

* fix: AuthoringMixin needs mako service

which fixes the visibility_view for XBlocks which don't explicitly
require the mako service.

Also removes the unneeded class property _services_requested from
AuthoringMixin and StudioEditableBlock. This property is better provided
by the XBlockMixin class.
2021-11-29 14:42:52 -05:00
edX Transifex Bot
0a73ac9089 chore(i18n): update translations 2021-11-29 02:41:27 +05:00
ansabgillani
92442637e8 feat: Add Program Enrollments API View 2021-11-26 21:23:29 +05:00
alangsto
a1b967a2fb feat: remove verification status from profile data report (#29428)
The verification status should be removed from the student profile data report if the integrity signature toggle has been enabled.
2021-11-24 11:41:20 -05:00
Michael Terry
ff453d1ad6 chore: delete ancient unused ADRs for system dashboard
This is long deprecated and these ADRs just document why it doesn't
exist. They've explained that long enough that we can just remove
this.
2021-11-23 15:47:27 -05:00
Chris Deery
0bf9a0e0ce fix: [AA-1106] completed status for unreleased (#29408)
Modify get_course_assignments so it does not mark unreleased content as completed
Add unit test
2021-11-23 14:33:50 -05:00
Olivia Ruiz-Knott
bb10334ebf Merge pull request #29405 from edx/ork/MICROBA_1573-allow_bulk_email_template_delete
feat: allow bulk email templates to be deleted
2021-11-23 13:41:18 -05:00
Chris Deery
bea16dad81 fix: [AA-1079] space separators for related programs (#29350)
fix css for spacing between related programs in course descriptions.
2021-11-23 13:30:17 -05:00
oliviaruizknott
eb1797d210 feat: allow bulk email templates to be deleted
There are some old bulk email templates in the database that we don’t
need anymore. We need to make this change in order to delete them. After
removing the templates we want to remove, we’ll leave in the ability to
delete.

[MICROBA-1573]
2021-11-23 10:59:46 -05:00
Kshitij Sobti
c8bd924e23 feat: Add support for using the discussions MFE UI instead of existing UI [BD-38] [TNL-9228] (#29285)
* feat: Add support for using the discussions MFE UI instead of existing UI

Adds a new course waffle flag that when set along with the discussions MFE URL shows the discussions MFE UI instead of the regular UI.

* test: add tests

* squash!: more consistent url name
2021-11-23 14:56:25 +05:00
Thomas Tracy
d1bde43e02 feat: [MICROBA-1531]Bulk email migration deny list (#29372) 2021-11-22 17:01:48 -05:00
jawad khan
d98c5ea1d3 fix: Enable upgrade banner for ios requests having 3172 as app version in header (#29351)
Replaces 3172(build number) with app number(2.26.3) in header which marks request as ios 2.26.3

LEARNER-8639
2021-11-22 21:02:04 +05:00
Uzair Rasheed
f74c0e51cb Merge pull request #29364 from edx/allow-login-if-email-opt-in-enabled
feat: allow login if email opt-in is enabled
2021-11-22 13:02:11 +05:00
Ahtisham Shahid
987c641d82 feat: created API to get program discussion iframe (#29205)
fix: py lint issues fixed

feat: added test cases for API

fix: py lint issues fixed and added tests

fix: updated tests and refactored

fix: fixed return type in the function

fix: conflicts resolved and linter issue

refactor: updated code to accommodate backward compatibility

refactor: updated classes for code clean up

feat: added test for ProgramDetailFragment

feat: added a new flag for masters discussion

refactor: updated flag names and other refactors
2021-11-22 11:27:45 +05:00
Kshitij Sobti
e8e8f4acbe feat!: Change the way tabs are ordered [BD-38] [TNL-9174] [BB-5076] (#29262)
* feat!: Change the way tabs are ordered
The change imposes a new ordering for tabs based on their new priority. When reordering tabs, this ordering will be maintained.

* fix: Apply suggestions from code review

Co-authored-by: Farhaan Bukhsh <farhaan@opencraft.com>

* fix: review feedback

Co-authored-by: Farhaan Bukhsh <farhaan@opencraft.com>
2021-11-22 11:17:30 +05:00
uzairr
f02fe4c203 feat: allow login if email opt-in is enabled
allow login to in-active users if email opt-in is enabled

Fixes: VAN-768
2021-11-22 10:53:33 +05:00
edX Transifex Bot
2e2701d82a chore(i18n): update translations 2021-11-22 02:41:48 +05:00
M. Zulqarnain
95dbcaa323 feat: Django codemods on LMS (4) (#28854) 2021-11-19 15:10:58 +05:00
Aarif
39fe1a20e4 feat: move unit tests to github actions on self-hosted runners (#28873) 2021-11-18 19:09:31 +05:00
Justin Lapierre
f6f3a79a15 Revert "[BD-13] Deprecate ModuleSystem.render_template" 2021-11-16 15:16:08 -05:00
Matthew Piatetsky
bda0062206 fix: some visual fixes the goal reminder email for outlook (#29337) 2021-11-16 14:49:03 -05:00
Andrew Shultz
bd2223fa48 Merge pull request #29321 from edx/ashultz0/simple_most_recent
fix: simplify most recent verification function
2021-11-16 09:51:10 -05:00
M. Zulqarnain
b84b862cc0 feat: Django codemods on LMS (3) (#28853) 2021-11-16 18:27:21 +05:00
Matthew Piatetsky
943ed55421 fix: Miscellaneous goal email fixes (#29323) 2021-11-15 19:20:45 -05:00
Andy Shultz
f70b3cff77 fix: simplify most recent verification function
current use is much less complicated than old code
2021-11-15 16:39:06 -05:00
alangsto
537ae9fcea fix: latest IDV expiration date should be returned (#29320)
The lack of ordering for a django query that grabbed verification records is blocking learners with multiple SSO records from taking proctored exams. All IDV records should be sorted by a key first, and then the correct expiration date can be determined.
2021-11-15 14:43:04 -05:00
edX Transifex Bot
92cd9108b2 chore(i18n): update translations 2021-11-16 00:30:52 +05:00
Matthew Piatetsky
22cb639919 feat: Update ace email header to match braze email header (#29310) 2021-11-15 10:44:41 -05:00
Matthew Piatetsky
d0d03f26eb fix: Miscellaneous css fixes (#29309) 2021-11-12 13:53:00 -05:00
Matthew Piatetsky
740d18a9f8 fix: remove logo from baner images (#29308) 2021-11-12 10:40:52 -05:00
Gábor Boros
230795fb07 feat: add optional-exposed extra field type to registration form
This defines optional extra fields that are not hidden under the toggle on the 
registration page.
2021-11-12 15:24:59 +01:00
Kshitij Sobti
285e2c4f29 feat: Adds a new discussion topic configuration mechanism [BD-38] [TNL-8623] [BB-4968] (#29082)
* feat: Adds a new discussion topic configuration mechanism

The new discussion configuration system links discussion topics directly to the course structure. This change adds a new task that sends a discussion update signal if there are any changes to the course. This signal includes all the context needed to update the configuration of the course.

The handler for this new event will create a new entry for each unit that needs a topic in the database. In the future this will be used to see the topics in the course.

* fix: add support for marking a provider as supporting LTI

* fix: review feedback
2021-11-12 19:08:43 +05:00
Waheed Ahmed
6ffdeab974 fix: remove hardcoded edx user info cookie name (#29280)
Removed hardcoded edx user info cookie name and used settings variable.
2021-11-12 11:33:00 +05:00
Awais Jibran
deba009e25 refactor: remove unused variables (#29304)
I have come across these unused variables and thought it's good to remove and clean up the code.
2021-11-12 00:28:35 +05:00
M. Zulqarnain
d9a91d4c38 BOM-2781: Django codemods on LMS (2) (#28852)
* feat: Django codemods on LMS (2)
2021-11-11 17:52:57 +05:00
Matthew Piatetsky
5dbfae83fc fix: Miscellaneous styling fixes for mobile (#29294)
* fix: Miscellaneous styling fixes for mobile

* fix: Add px fallback since outlook doesn't support rem
2021-11-10 16:47:55 -05:00
edX Transifex Bot
fe067bab16 chore(i18n): update translations 2021-11-10 21:10:54 +05:00
Ned Batchelder
d9dd10dc97 style: code cleanups from Steven Burch (#29292)
* chore: update deprecated import from collections

* chore: remove outdated imports from markdown library

as it hasn't been supported since 2.0.3 and we're on 3.x.
This was deprecated at least as early as 2012!

* docs: add docstring and remove lint-amnesty to markdown plugin

* chore: remove deprecated etree import

* style: remove unnecessary-comprehension for sets

* style: resolve a number of amnestied pylint complaints

Co-authored-by: stvn <stvn@mit.edu>
2021-11-10 07:11:57 -08:00
Chris Deery
1d2319b42a feat: [AA-1082] fix 500 error on courses dashboard (#29290)
feat: [AA-1082] fix 500 error on courses dashboard

When there are no selected blocks, the dict comprehension to
compare is throwing an exception. Handle the error more gracefully.
The blocks will not be sorted, but they should not be filtered.
2021-11-10 09:47:32 -05:00
Matthew Piatetsky
4822faccc4 [AA-910] Miscellaneous UI fixes and fixed unsubscribe link (#29288)
* fix: use pngs for the goal reminder email banner and remove redundant unsubscribe link

* fix: update

* fix: Miscellaneous UI fixes and fixed unsubscribe link
2021-11-09 13:56:12 -05:00
AsadAzam
49367f4758 feat: added program discussions admin view (#29283)
* feat: added program discussions admin view

* refactor: updated docstring

* refactor: updated constant
2021-11-09 22:35:21 +05:00
David Ormsbee
2d60224125 Merge pull request #28571 from open-craft/jill/bd-13-render_template
feat!: [BD-13] Deprecate ModuleSystem.render_template
2021-11-09 12:20:59 -05:00
Régis Behmo
9ab904fd19 fix: "Uncaught TypeError: n is null" during login to LMS (#29192)
When signing in from the LMS, the authentication request succeeds but
the user was never redirected to the dashboard. This is because of a
js error:

    Uncaught TypeError: userCookie is null
        userFromEdxUserCookie
        http://maple.openedx.overhang.io:8000/static/js/student_account/utils.js:32

The error comes from the fact that the util.js code ignores the
EDXAPP_EDXMKTG_USER_INFO_COOKIE_NAME setting name. Instead the cookie
name is abritrarily prefixed by "stage-" or "prod-" depending on the
hostname. This seems to be primarily motivated by the definition of
edX.org staging/prod environment hostnames :-(

To resolve this issue, we decided that the actual cookie name was not so
important. Instead, the js code needs to not crash even when the cookie
is absent.

This issue was first reported here:
https://github.com/edx/edx-platform/pull/28170#issuecomment-890449885

Close https://github.com/openedx/build-test-release-wg/issues/104
2021-11-09 11:12:24 -05:00