pylint amnesty in cms apps

cms/djangoapps/models/settings/course_grading.py

@@ -235,7 +235,7 @@ class CourseGradingModel(object):
 
         # 'minimum_grade_credit' cannot be set to None
         if minimum_grade_credit is not None:
-            minimum_grade_credit = minimum_grade_credit
+            minimum_grade_credit = minimum_grade_credit  # lint-amnesty, pylint: disable=self-assigning-variable
 
             descriptor.minimum_grade_credit = minimum_grade_credit
             modulestore().update_item(descriptor, user.id)
@@ -276,7 +276,7 @@ class CourseGradingModel(object):
         }
 
     @staticmethod
-    def update_section_grader_type(descriptor, grader_type, user):
+    def update_section_grader_type(descriptor, grader_type, user):  # lint-amnesty, pylint: disable=missing-function-docstring
         if grader_type is not None and grader_type != u'notgraded':
             descriptor.format = grader_type
             descriptor.graded = True
@@ -289,7 +289,7 @@ class CourseGradingModel(object):
         return {'graderType': grader_type}
 
     @staticmethod
-    def convert_set_grace_period(descriptor):
+    def convert_set_grace_period(descriptor):  # lint-amnesty, pylint: disable=missing-function-docstring
         # 5 hours 59 minutes 59 seconds => converted to iso format
         rawgrace = descriptor.graceperiod
         if rawgrace:
@@ -316,7 +316,7 @@ class CourseGradingModel(object):
             return None
 
     @staticmethod
-    def parse_grader(json_grader):
+    def parse_grader(json_grader):  # lint-amnesty, pylint: disable=missing-function-docstring
         # manual to clear out kruft
         result = {"type": json_grader["type"],
                   "min_count": int(json_grader.get('min_count', 0)),
@@ -328,7 +328,7 @@ class CourseGradingModel(object):
         return result
 
     @staticmethod
-    def jsonize_grader(i, grader):
+    def jsonize_grader(i, grader):  # lint-amnesty, pylint: disable=missing-function-docstring
         # Warning: converting weight to integer might give unwanted results due
         # to the reason how floating point arithmetic works
         # e.g, "0.29 * 100 = 28.999999999999996"
@@ -342,7 +342,7 @@ class CourseGradingModel(object):
         }
 
 
-def _grading_event_and_signal(course_key, user_id):
+def _grading_event_and_signal(course_key, user_id):  # lint-amnesty, pylint: disable=missing-function-docstring
     name = GRADING_POLICY_CHANGED_EVENT_TYPE
     course = modulestore().get_course(course_key)
     grading_policy_hash = six.text_type(hash_grading_policy(course.grading_policy))
@@ -362,7 +362,7 @@ def _grading_event_and_signal(course_key, user_id):
     )
 
 
-def hash_grading_policy(grading_policy):
+def hash_grading_policy(grading_policy):  # lint-amnesty, pylint: disable=missing-function-docstring
     ordered_policy = json.dumps(
         grading_policy,
         separators=(',', ':'),  # Remove spaces from separators for more compact representation

cms/djangoapps/models/settings/course_metadata.py

@@ -173,14 +173,14 @@ class CourseMetadata(object):
             if field.scope != Scope.settings:
                 continue
 
-            field_help = _(field.help)
+            field_help = _(field.help)  # lint-amnesty, pylint: disable=translation-of-non-string
             help_args = field.runtime_options.get('help_format_args')
             if help_args is not None:
                 field_help = field_help.format(**help_args)
 
             result[field.name] = {
                 'value': field.read_json(descriptor),
-                'display_name': _(field.display_name),
+                'display_name': _(field.display_name),  # lint-amnesty, pylint: disable=translation-of-non-string
                 'help': field_help,
                 'deprecated': field.runtime_options.get('deprecated', False),
                 'hide_on_enabled_publisher': field.runtime_options.get('hide_on_enabled_publisher', False)
@@ -211,7 +211,7 @@ class CourseMetadata(object):
                 if hasattr(descriptor, key) and getattr(descriptor, key) != val:
                     key_values[key] = descriptor.fields[key].from_json(val)
             except (TypeError, ValueError) as err:
-                raise ValueError(_(u"Incorrect format for field '{name}'. {detailed_message}").format(
+                raise ValueError(_(u"Incorrect format for field '{name}'. {detailed_message}").format(  # lint-amnesty, pylint: disable=raise-missing-from
                     name=model['display_name'], detailed_message=text_type(err)))
 
         return cls.update_from_dict(key_values, descriptor, user)

cms/djangoapps/models/settings/encoder.py

@@ -20,7 +20,7 @@ class CourseSettingsEncoder(json.JSONEncoder):
     Serialize CourseDetails, CourseGradingModel, datetime, and old
     Locations
     """
-    def default(self, obj):  # pylint: disable=method-hidden
+    def default(self, obj):  # lint-amnesty, pylint: disable=arguments-differ, method-hidden
         if isinstance(obj, (CourseDetails, CourseGradingModel)):
             return obj.__dict__
         elif isinstance(obj, Location):