From fe1d244900ffcfc447d97df063b2f699a60441f3 Mon Sep 17 00:00:00 2001 From: David Baumgold Date: Mon, 29 Dec 2014 10:46:57 -0500 Subject: [PATCH] Respond to review comments --- lms/djangoapps/shoppingcart/models.py | 8 ++--- lms/templates/shoppingcart/receipt.html | 47 ++++++++++++------------- 2 files changed, 26 insertions(+), 29 deletions(-) diff --git a/lms/djangoapps/shoppingcart/models.py b/lms/djangoapps/shoppingcart/models.py index d52abbccf6..3eea555d45 100644 --- a/lms/djangoapps/shoppingcart/models.py +++ b/lms/djangoapps/shoppingcart/models.py @@ -1020,11 +1020,11 @@ class PaidCourseRegistration(OrderItem): Basically tells the user to visit the dashboard to see their new classes """ notification = _( - "Please visit your {link_start}dashboard{link_end} " - "to see your new course." + u"Please visit your {link_start}dashboard{link_end} " + u"to see your new course." ).format( - link_start=''.format(url=reverse('dashboard')), - link_end='', + link_start=u''.format(url=reverse('dashboard')), + link_end=u'', ) return self.pk_with_subclass, set([notification]) diff --git a/lms/templates/shoppingcart/receipt.html b/lms/templates/shoppingcart/receipt.html index 48901d9989..84bba161aa 100644 --- a/lms/templates/shoppingcart/receipt.html +++ b/lms/templates/shoppingcart/receipt.html @@ -21,7 +21,7 @@ from courseware.courses import course_image_url, get_course_about_section, get_c
<% courses_url = reverse('courses') %> % if receipt_has_donation_item: - ${_("Thank you for your Purchase!")} + ${_("Thank you for your purchase!")} % for inst in instructions: ${inst} % endfor @@ -31,35 +31,32 @@ from courseware.courses import course_image_url, get_course_about_section, get_c <% dashboard_url = reverse('dashboard') %> ${_("View Dashboard")} - ${_("You have successfully been enrolled for {course_names}. " - "The following receipt has been emailed to {receipient_emails}").format( - course_names="{course_names}".format( + ${_(u"You have successfully been enrolled for {course_names}. " + u"The following receipt has been emailed to {receipient_emails}").format( + course_names=u"{course_names}".format( course_names=appended_course_names ), - receipient_emails="{receipient_emails}".format( + receipient_emails=u"{receipient_emails}".format( receipient_emails=appended_recipient_emails ), )} % elif order_type == 'business': - ${_("You have successfully purchased {items} for {course_names}. " - "The following receipt has been emailed to {receipient_emails}" - ).format( - items="{items}".format( - items=ungettext( - "{number} course registration code", - "{number} course registration codes", - total_registration_codes - ).format(number=total_registration_codes) - ), - course_names="{course_names}".format( - course_names=appended_course_names - ), - receipient_emails="{receipient_emails}".format( - receipient_emails=appended_recipient_emails, - ) + ${ungettext( + "You have successfully purchased {number} course registration code for {course_names}.", + "You have successfully purchased {number} course registration codes for {course_names}.", + total_registration_codes + ).format( + number=total_registration_codes, + course_names=u"{course_names}".format( + course_names=appended_course_names ) - } + )} + ${_("The following receipt has been emailed to {receipient_emails}").format( + receipient_emails=u"{receipient_emails}".format( + receipient_emails=appended_recipient_emails, + ) + )} % endif
@@ -136,7 +133,7 @@ from courseware.courses import course_image_url, get_course_about_section, get_c ${_('Company Contact Name')}: