From fcfacf22c8b36fc23629dfd676b1a036e952b55f Mon Sep 17 00:00:00 2001 From: Jesse Zoldak Date: Tue, 28 Jun 2016 07:19:25 -0400 Subject: [PATCH] Revert "TNL 4141" --- common/lib/capa/capa/responsetypes.py | 5 +---- common/lib/capa/capa/tests/test_responsetypes.py | 8 ++++---- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/common/lib/capa/capa/responsetypes.py b/common/lib/capa/capa/responsetypes.py index 51a18ba886..b55744baef 100644 --- a/common/lib/capa/capa/responsetypes.py +++ b/common/lib/capa/capa/responsetypes.py @@ -189,10 +189,7 @@ class LoncapaResponse(object): raise LoncapaProblemError(msg) for prop in self.required_attributes: - prop_value = xml.get(prop) - if prop_value: # Stripping off the empty strings - prop_value = prop_value.strip() - if not prop_value: + if not xml.get(prop): msg = "Error in problem specification: %s missing required attribute %s" % ( unicode(self), prop) msg += "\nSee XML source line %s" % getattr( diff --git a/common/lib/capa/capa/tests/test_responsetypes.py b/common/lib/capa/capa/tests/test_responsetypes.py index ec4ba13b6e..adbbe88f8c 100644 --- a/common/lib/capa/capa/tests/test_responsetypes.py +++ b/common/lib/capa/capa/tests/test_responsetypes.py @@ -946,12 +946,12 @@ class StringResponseTest(ResponseTest): # pylint: disable=missing-docstring hint = correct_map.get_hint('1_2_1') self.assertEqual(hint, self._get_random_number_result(problem.seed)) - def test_empty_answer_problem_creation_not_allowed(self): + def test_empty_answer_graded_as_incorrect(self): """ - Tests that empty answer string is not allowed to create a problem + Tests that problem should be graded incorrect if blank space is chosen as answer """ - with self.assertRaises(LoncapaProblemError): - self.build_problem(answer=" ", case_sensitive=False, regexp=True) + problem = self.build_problem(answer=" ", case_sensitive=False, regexp=True) + self.assert_grade(problem, u" ", "incorrect") class CodeResponseTest(ResponseTest): # pylint: disable=missing-docstring