Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix validation for checkboxes in forms.

Browse Source 
Remove hard-coded TOS checkbox in registration template.
Disable new dashboard in settings; expose password reset end-point in student account app.
Added empty JS tests for new JavaScript
This commit is contained in:
Will Daly
2014-10-20 16:55:39 -04:00
parent ed0c383ac0
commit fabd8a97ad
10 changed files with 170 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
common/static/js/spec_helpers/edx.utils.validate.js
View File

@@ -18,6 +18,11 @@ var edx = edx || {};
},
charLength: function( $el ) {
var type = $el.attr("type");
if (type !== "text" && type !== "textarea" && type !== "password") {
return true;
}
// Cannot assume there will be both min and max
var min = $el.attr('minlength') || 0,
max = $el.attr('maxlength') || false,
@@ -35,7 +40,12 @@ var edx = edx || {};
},
required: function( $el ) {
return $el.attr('required') ? $el.val() : true;
if ($el.attr("type") === "checkbox") {
return $el.attr('required') ? $el.prop("checked") : true;
}
else {
return $el.attr('required') ? $el.val() : true;
}
},
email: {
@@ -66,6 +76,6 @@ var edx = edx || {};
})();
edx.utils.validate = utils.validate
edx.utils.validate = utils.validate;
})( jQuery, _ );