diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 014b432f58..67a39f30d8 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -5,6 +5,11 @@ These are notable changes in edx-platform. This is a rolling list of changes, in roughly chronological order, most recent first. Add your entries at or near the top. Include a label indicating the component affected. +Blades: Fix for the list metadata editor that gets into a bad state where "Add" + is disabled. BLD-821. + +Blades: Add view for field type Dict in Studio. BLD-658. + Blades: Refactor stub implementation of LTI Provider. BLD-601. LMS: In left accordion and progress page, due dates are now displayed in time diff --git a/cms/static/coffee/spec/views/metadata_edit_spec.coffee b/cms/static/coffee/spec/views/metadata_edit_spec.coffee index 40547323bb..4c3927c492 100644 --- a/cms/static/coffee/spec/views/metadata_edit_spec.coffee +++ b/cms/static/coffee/spec/views/metadata_edit_spec.coffee @@ -14,6 +14,7 @@ define ["js/models/metadata", "js/collections/metadata", "js/views/metadata", "c stringEntryTemplate = readFixtures('metadata-string-entry.underscore') optionEntryTemplate = readFixtures('metadata-option-entry.underscore') listEntryTemplate = readFixtures('metadata-list-entry.underscore') + dictEntryTemplate = readFixtures('metadata-dict-entry.underscore') beforeEach -> setFixtures($(" - - - - - - - +% for template_name in ["metadata-number-entry", "metadata-string-entry", "metadata-option-entry", "metadata-list-entry", "metadata-dict-entry"]: + +% endfor <% showHighLevelSource='source_code' in editable_metadata_fields and editable_metadata_fields['source_code']['explicitly_set'] and enable_latex_compiler %> <% metadata_field_copy = copy.copy(editable_metadata_fields) %> diff --git a/cms/templates/widgets/tabs/metadata-edit-tab.html b/cms/templates/widgets/tabs/metadata-edit-tab.html index 0caf9d2078..862dfd58d0 100644 --- a/cms/templates/widgets/tabs/metadata-edit-tab.html +++ b/cms/templates/widgets/tabs/metadata-edit-tab.html @@ -8,21 +8,11 @@ <%static:include path="js/metadata-editor.underscore" /> - - - - - - - +% for template_name in ["metadata-number-entry", "metadata-string-entry", "metadata-option-entry", "metadata-list-entry", "metadata-dict-entry"]: + +% endfor
diff --git a/common/lib/xmodule/xmodule/x_module.py b/common/lib/xmodule/xmodule/x_module.py index 9acc686208..484f0c9032 100644 --- a/common/lib/xmodule/xmodule/x_module.py +++ b/common/lib/xmodule/xmodule/x_module.py @@ -16,7 +16,7 @@ from webob import Response from webob.multidict import MultiDict from xblock.core import XBlock -from xblock.fields import Scope, Integer, Float, List, XBlockMixin, String +from xblock.fields import Scope, Integer, Float, List, XBlockMixin, String, Dict from xblock.fragment import Fragment from xblock.plugin import default_select from xblock.runtime import Runtime @@ -790,6 +790,8 @@ class XModuleDescriptor(XModuleMixin, HTMLSnippet, ResourceTemplates, XBlock): editor_type = "Float" elif isinstance(field, List): editor_type = "List" + elif isinstance(field, Dict): + editor_type = "Dict" elif isinstance(field, RelativeTime): editor_type = "RelativeTime" metadata_fields[field.name]['type'] = editor_type