From 76f2ef6f7c639f3449cdb6b858544c5324e092b1 Mon Sep 17 00:00:00 2001
From: Don Mitchell <dmitchell@edx.org>
Date: Tue, 8 Jan 2013 10:53:45 -0500
Subject: [PATCH 1/3] Empty template now recognized as allowing markdown
 editing Save saves markdown and updates the xml

---
 cms/static/coffee/src/views/module_edit.coffee        |  2 +-
 cms/templates/widgets/problem-edit.html               |  2 +-
 common/lib/xmodule/xmodule/js/src/problem/edit.coffee | 10 +++++++++-
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/cms/static/coffee/src/views/module_edit.coffee b/cms/static/coffee/src/views/module_edit.coffee
index 0617b01bb4..b1157f713e 100644
--- a/cms/static/coffee/src/views/module_edit.coffee
+++ b/cms/static/coffee/src/views/module_edit.coffee
@@ -55,7 +55,7 @@ class CMS.Views.ModuleEdit extends Backbone.View
   clickSaveButton: (event) =>
     event.preventDefault()
     data = @module.save()
-    data.metadata = @metadata()
+    data.metadata = _.extend(data.metadata, @metadata())
     $modalCover.hide()
     @model.save(data).done( =>
     #   # showToastMessage("Your changes have been saved.", null, 3)
diff --git a/cms/templates/widgets/problem-edit.html b/cms/templates/widgets/problem-edit.html
index f6baae4d2d..239c24def7 100644
--- a/cms/templates/widgets/problem-edit.html
+++ b/cms/templates/widgets/problem-edit.html
@@ -1,7 +1,7 @@
 <%include file="metadata-edit.html" />
 <section class="problem-editor editor">
     <div class="row">
-        %if markdown != '' or data == '':
+        %if markdown != '' or data == '<problem>\n</problem>\n':
         <div class="editor-bar">
             <ul class="format-buttons">
                 <li><a href="#" class="multiple-choice-button" data-tooltip="Multiple Choice"><span
diff --git a/common/lib/xmodule/xmodule/js/src/problem/edit.coffee b/common/lib/xmodule/xmodule/js/src/problem/edit.coffee
index a52ebaebbd..773cafccb1 100644
--- a/common/lib/xmodule/xmodule/js/src/problem/edit.coffee
+++ b/common/lib/xmodule/xmodule/js/src/problem/edit.coffee
@@ -61,7 +61,15 @@ class @MarkdownEditingDescriptor extends XModule.Descriptor
   save: ->
     $body.off('click', '.editor-tabs .tab', @changeEditor)
     $body.off('click', '.editor-bar a', @onToolbarButton);
-    data: @xml_editor.getValue()
+    # TODO when logic is in place to remove the markdown if xml is edited, ensure this doesn't overwrite that
+    if @current_editor == @markdown_editor
+        {
+            data: MarkdownEditingDescriptor.markdownToXml(@markdown_editor.getValue())
+            metadata: 
+            	markdown: @markdown_editor.getValue()
+        }
+    else 
+        data: @xml_editor.getValue()
 
   @insertMultipleChoice: (selectedText) ->
     return MarkdownEditingDescriptor.insertGenericChoice(selectedText, '(', ')', MarkdownEditingDescriptor.multipleChoiceTemplate)

From 6e2b4a07d8323be6c1eed55d8feaa12f44c31326 Mon Sep 17 00:00:00 2001
From: Don Mitchell <dmitchell@edx.org>
Date: Tue, 8 Jan 2013 11:18:57 -0500
Subject: [PATCH 2/3] Added is_empty to model presented to unit.html

---
 cms/djangoapps/contentstore/views.py | 3 ++-
 cms/templates/unit.html              | 5 ++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/cms/djangoapps/contentstore/views.py b/cms/djangoapps/contentstore/views.py
index d828993e34..19d74024c7 100644
--- a/cms/djangoapps/contentstore/views.py
+++ b/cms/djangoapps/contentstore/views.py
@@ -271,7 +271,8 @@ def edit_unit(request, location):
             component_templates[template.location.category].append((
                 template.display_name,
                 template.location.url(),
-                'markdown' in template.metadata
+                'markdown' in template.metadata,
+                template.location.name == 'Empty'
             ))
 
     components = [
diff --git a/cms/templates/unit.html b/cms/templates/unit.html
index 40dfd65381..f261be62fa 100644
--- a/cms/templates/unit.html
+++ b/cms/templates/unit.html
@@ -152,13 +152,16 @@
                 % for type, templates in sorted(component_templates.items()):
                 <div class="new-component-templates new-component-${type}">
                     <ul class="new-component-template">
-                        % for name, location, has_markdown in templates:
+                        % for name, location, has_markdown, is_empty in templates:
                         <li>
                             <a href="#" data-location="${location}">
                                 <span class="name">${name} 
                                 % if has_markdown:
                                      MD
                                 % endif
+                                % if is_empty:
+                                    <i>rasa</i>
+                                % endif
                                 </span>
                             </a>
                         </li>

From ae4e7815a9781ae80531f8ee66a49eff0b8c0cd0 Mon Sep 17 00:00:00 2001
From: Don Mitchell <dmitchell@edx.org>
Date: Tue, 8 Jan 2013 13:16:38 -0500
Subject: [PATCH 3/3] CapaDescriptor new unit tests

---
 .../contentstore/tests/factories.py           |  4 +++
 cms/djangoapps/contentstore/tests/tests.py    | 26 ++++++++++++++-----
 2 files changed, 23 insertions(+), 7 deletions(-)

diff --git a/cms/djangoapps/contentstore/tests/factories.py b/cms/djangoapps/contentstore/tests/factories.py
index 3274477098..cb9f451d38 100644
--- a/cms/djangoapps/contentstore/tests/factories.py
+++ b/cms/djangoapps/contentstore/tests/factories.py
@@ -73,6 +73,10 @@ class XModuleItemFactory(Factory):
 
     @classmethod
     def _create(cls, target_class, *args, **kwargs):
+        """
+        kwargs must include parent_location, template. Can contain display_name
+        target_class is ignored
+        """
 
         DETACHED_CATEGORIES = ['about', 'static_tab', 'course_info']
         
diff --git a/cms/djangoapps/contentstore/tests/tests.py b/cms/djangoapps/contentstore/tests/tests.py
index b3f13de998..a8bf5e82a0 100644
--- a/cms/djangoapps/contentstore/tests/tests.py
+++ b/cms/djangoapps/contentstore/tests/tests.py
@@ -22,6 +22,8 @@ from xmodule.modulestore.django import modulestore
 from xmodule.contentstore.django import contentstore
 from xmodule.course_module import CourseDescriptor
 from xmodule.modulestore.xml_exporter import export_to_xml
+from cms.djangoapps.contentstore.utils import get_modulestore
+from xmodule.capa_module import CapaDescriptor
 
 def parse_json(response):
     """Parse response, which is assumed to be json"""
@@ -438,13 +440,23 @@ class ContentStoreTest(TestCase):
         self.assertContains(resp, '/c4x/edX/full/asset/handouts_schematic_tutorial.pdf') 
 
 
+    def test_capa_module(self):
+        """Test that a problem w/ markdown has markdown and uses the right html etc"""
+        CourseFactory.create(org='MITx', course='999', display_name='Robot Super Course')
 
+        problem_data = {
+            'parent_location' : 'i4x://MITx/999/course/Robot_Super_Course',
+            'template' : 'i4x://edx/templates/problem/Empty'
+            }
 
+        resp = self.client.post(reverse('clone_item'), problem_data)
 
-
-        
-
-
-
-
-
+        self.assertEqual(resp.status_code, 200)
+        payload = parse_json(resp)
+        problem_loc = payload['id']
+        problem = get_modulestore(problem_loc).get_item(problem_loc)
+        # should be a CapaDescriptor
+        self.assertIsInstance(problem, CapaDescriptor, "New problem is not a CapaDescriptor")
+        context = problem.get_context()
+        self.assertIn('markdown', context, "markdown is missing")
+        self.assertNotIn('markdown', problem.editable_metadata_fields, "Markdown slipped into the editable metadata fields")
\ No newline at end of file