Remove useless pylint suppressions

lms/envs/bok_choy.py

@@ -14,11 +14,6 @@ import os
 from path import Path as path
 from tempfile import mkdtemp
 
-# Pylint gets confused by path.py instances, which report themselves as class
-# objects. As a result, pylint applies the wrong regex in validating names,
-# and throws spurious errors. Therefore, we disable invalid-name checking.
-# pylint: disable=invalid-name
-
 CONFIG_ROOT = path(__file__).abspath().dirname()
 TEST_ROOT = CONFIG_ROOT.dirname().dirname() / "test_root"
 

lms/envs/cms/acceptance.py

@@ -6,7 +6,7 @@ Toolbar. I it suitable to run against acceptance tests.
 
 # We intentionally define lots of variables that aren't used, and
 # want to import all variables from base settings files
-# pylint: disable=wildcard-import, unused-wildcard-import, undefined-variable
+# pylint: disable=wildcard-import, unused-wildcard-import
 
 from .dev import *
 
@@ -15,7 +15,7 @@ from .dev import *
 INSTALLED_APPS = tuple(e for e in INSTALLED_APPS if e != 'debug_toolbar')
 INSTALLED_APPS = tuple(e for e in INSTALLED_APPS if e != 'debug_toolbar_mongo')
 
-MIDDLEWARE_CLASSES = tuple(e for e in MIDDLEWARE_CLASSES  # pylint: disable=used-before-assignment
+MIDDLEWARE_CLASSES = tuple(e for e in MIDDLEWARE_CLASSES
                            if e != 'debug_toolbar.middleware.DebugToolbarMiddleware')
 
 

lms/envs/cms/microsite_test.py

@@ -5,11 +5,6 @@ This is a localdev test for the Microsite processing pipeline
 # want to import all variables from base settings files
 # pylint: disable=wildcard-import, unused-wildcard-import
 
-# Pylint gets confused by path.py instances, which report themselves as class
-# objects. As a result, pylint applies the wrong regex in validating names,
-# and throws spurious errors. Therefore, we disable invalid-name checking.
-# pylint: disable=invalid-name
-
 from .dev import *
 from ..dev import ENV_ROOT, FEATURES
 

lms/envs/common.py

@@ -22,7 +22,7 @@ Longer TODO:
 
 # We intentionally define lots of variables that aren't used, and
 # want to import all variables from base settings files
-# pylint: disable=wildcard-import, unused-import, unused-wildcard-import, invalid-name
+# pylint: disable=wildcard-import, unused-import, unused-wildcard-import
 
 # Pylint gets confused by path.py instances, which report themselves as class
 # objects. As a result, pylint applies the wrong regex in validating names,

lms/envs/dev.py

@@ -12,11 +12,6 @@ sessions. Assumes structure:
 # want to import all variables from base settings files
 # pylint: disable=wildcard-import, unused-wildcard-import
 
-# Pylint gets confused by path.py instances, which report themselves as class
-# objects. As a result, pylint applies the wrong regex in validating names,
-# and throws spurious errors. Therefore, we disable invalid-name checking.
-# pylint: disable=invalid-name
-
 from .common import *
 
 DEBUG = True

lms/envs/discussionsettings.py

@@ -1,5 +1,2 @@
 
-# We intentionally define variables that aren't used
-# pylint: disable=unused-wildcard-import
-
 DISCUSSION_ALLOWED_UPLOAD_FILE_TYPES = ('.jpg', '.jpeg', '.gif', '.bmp', '.png', '.tiff')

lms/envs/sauce.py

@@ -3,10 +3,6 @@ This config file extends the test environment configuration
 so that we can run the lettuce acceptance tests on SauceLabs.
 """
 
-# We intentionally define lots of variables that aren't used, and
-# want to import all variables from base settings files
-# pylint: disable=wildcard-import, unused-wildcard-import
-
 from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
 import os
 

lms/envs/test.py

@@ -309,7 +309,7 @@ FEATURES['ENABLE_PAYMENT_FAKE'] = True
 # the same settings, we can generate this randomly and guarantee
 # that they are using the same secret.
 from random import choice
-from string import letters, digits, punctuation  # pylint: disable=deprecated-module
+from string import letters, digits, punctuation
 RANDOM_SHARED_SECRET = ''.join(
     choice(letters + digits + punctuation)
     for x in range(250)