Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove needless 'disable=no-member' pragmas

Browse Source
This commit is contained in:
Ned Batchelder
2015-08-03 16:59:57 -04:00
parent ee0f4b2594
commit f54fe787c6
73 changed files with 144 additions and 186 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lms/djangoapps/mobile_api/course_info/tests.py
View File

@@ -76,7 +76,7 @@ class TestUpdates(MobileAPITestCase, MobileAuthTestMixin, MobileCourseAccessTest
# verify content and sort order of updates (most recent first)
for num in range(1, num_updates + 1):
update_data = response.data[num_updates - num] # pylint: disable=maybe-no-member
update_data = response.data[num_updates - num]
self.assertEquals(num, update_data['id'])
self.assertEquals("Date" + str(num), update_data['date'])
self.assertIn("Update" + str(num), update_data['content'])

10
lms/djangoapps/mobile_api/social_facebook/groups/tests.py
View File

@@ -108,7 +108,7 @@ class TestGroups(SocialFacebookTestCase):
status=status_code
)
response = self.delete_group(response.data['id']) # pylint: disable=E1101
self.assertTrue(response.status_code, status_code) # pylint: disable=E1101
self.assertTrue(response.status_code, status_code)
@httpretty.activate
def test_delete(self):
@@ -153,7 +153,7 @@ class TestGroups(SocialFacebookTestCase):
self.set_facebook_interceptor_for_members({'success': 'True'}, status_code, group_id, member_id)
response = self.invite_to_group(group_id, member_id)
self.assertEqual(response.status_code, status_code)
self.assertTrue('success' in response.data[member_id]) # pylint: disable=E1103
self.assertTrue('success' in response.data[member_id])
@httpretty.activate
def test_invite_multiple_members_successfully(self):
@@ -166,7 +166,7 @@ class TestGroups(SocialFacebookTestCase):
response = self.invite_to_group(group_id, member_ids)
self.assertEqual(response.status_code, status_code)
for member_id in member_ids.split(','):
self.assertTrue('success' in response.data[member_id]) # pylint: disable=E1103
self.assertTrue('success' in response.data[member_id])
@httpretty.activate
def test_invite_single_member_unsuccessfully(self):
@@ -180,7 +180,7 @@ class TestGroups(SocialFacebookTestCase):
)
response = self.invite_to_group(group_id, member_id)
self.assertEqual(response.status_code, 200)
self.assertTrue('error message' in response.data[member_id]) # pylint: disable=E1103
self.assertTrue('error message' in response.data[member_id])
@httpretty.activate
def test_invite_multiple_members_unsuccessfully(self):
@@ -196,4 +196,4 @@ class TestGroups(SocialFacebookTestCase):
response = self.invite_to_group(group_id, member_ids)
self.assertEqual(response.status_code, 200)
for member_id in member_ids.split(','):
self.assertTrue('error message' in response.data[member_id]) # pylint: disable=E1103
self.assertTrue('error message' in response.data[member_id])

1
lms/djangoapps/mobile_api/social_facebook/preferences/tests.py
View File

@@ -1,4 +1,3 @@
# pylint: disable=no-member
"""
Tests for users sharing preferences
"""

40
lms/djangoapps/mobile_api/users/tests.py
View File

@@ -101,7 +101,7 @@ class TestUserEnrollmentApi(MobileAPITestCase, MobileAuthUserTestMixin):
response = self.api_response()
for course_index in range(num_courses):
self.assertEqual(
response.data[course_index]['course']['id'], # pylint: disable=no-member
response.data[course_index]['course']['id'],
unicode(courses[num_courses - course_index - 1].id)
)
@@ -138,7 +138,7 @@ class TestUserEnrollmentApi(MobileAPITestCase, MobileAuthUserTestMixin):
# Verify courses have the correct response through error code. Last enrolled course is first course in response
response = self.api_response()
for course_index in range(len(courses)):
result = response.data[course_index]['course']['courseware_access'] # pylint: disable=no-member
result = response.data[course_index]['course']['courseware_access']
self.assertEqual(result['error_code'], expected_error_codes[::-1][course_index])
if result['error_code'] is not None:
@@ -162,14 +162,14 @@ class TestUserEnrollmentApi(MobileAPITestCase, MobileAuthUserTestMixin):
self.enroll(course.id)
response = self.api_response()
self.assertEqual(response.data[0]['course']['start_type'], expected_type) # pylint: disable=no-member
self.assertEqual(response.data[0]['course']['start_display'], expected_display) # pylint: disable=no-member
self.assertEqual(response.data[0]['course']['start_type'], expected_type)
self.assertEqual(response.data[0]['course']['start_display'], expected_display)
def test_no_certificate(self):
self.login_and_enroll()
response = self.api_response()
certificate_data = response.data[0]['certificate'] # pylint: disable=no-member
certificate_data = response.data[0]['certificate']
self.assertDictEqual(certificate_data, {})
def test_certificate(self):
@@ -185,14 +185,14 @@ class TestUserEnrollmentApi(MobileAPITestCase, MobileAuthUserTestMixin):
)
response = self.api_response()
certificate_data = response.data[0]['certificate'] # pylint: disable=no-member
certificate_data = response.data[0]['certificate']
self.assertEquals(certificate_data['url'], certificate_url)
def test_no_facebook_url(self):
self.login_and_enroll()
response = self.api_response()
course_data = response.data[0]['course'] # pylint: disable=no-member
course_data = response.data[0]['course']
self.assertIsNone(course_data['social_urls']['facebook'])
def test_facebook_url(self):
@@ -202,7 +202,7 @@ class TestUserEnrollmentApi(MobileAPITestCase, MobileAuthUserTestMixin):
self.store.update_item(self.course, self.user.id)
response = self.api_response()
course_data = response.data[0]['course'] # pylint: disable=no-member
course_data = response.data[0]['course']
self.assertEquals(course_data['social_urls']['facebook'], self.course.facebook_url)
@@ -249,11 +249,11 @@ class TestCourseStatusGET(CourseStatusAPITestCase, MobileAuthUserTestMixin, Mobi
response = self.api_response()
self.assertEqual(
response.data["last_visited_module_id"], # pylint: disable=no-member
response.data["last_visited_module_id"],
unicode(self.sub_section.location)
)
self.assertEqual(
response.data["last_visited_module_path"], # pylint: disable=no-member
response.data["last_visited_module_path"],
[unicode(module.location) for module in [self.sub_section, self.section, self.course]]
)
@@ -270,7 +270,7 @@ class TestCourseStatusPATCH(CourseStatusAPITestCase, MobileAuthUserTestMixin, Mo
self.login_and_enroll()
response = self.api_response(data={"last_visited_module_id": unicode(self.other_unit.location)})
self.assertEqual(
response.data["last_visited_module_id"], # pylint: disable=no-member
response.data["last_visited_module_id"],
unicode(self.other_sub_section.location)
)
@@ -278,7 +278,7 @@ class TestCourseStatusPATCH(CourseStatusAPITestCase, MobileAuthUserTestMixin, Mo
self.login_and_enroll()
response = self.api_response(data={"last_visited_module_id": "abc"}, expected_response_code=400)
self.assertEqual(
response.data, # pylint: disable=no-member
response.data,
errors.ERROR_INVALID_MODULE_ID
)
@@ -287,7 +287,7 @@ class TestCourseStatusPATCH(CourseStatusAPITestCase, MobileAuthUserTestMixin, Mo
non_existent_key = self.course.id.make_usage_key('video', 'non-existent')
response = self.api_response(data={"last_visited_module_id": non_existent_key}, expected_response_code=400)
self.assertEqual(
response.data, # pylint: disable=no-member
response.data,
errors.ERROR_INVALID_MODULE_ID
)
@@ -297,12 +297,12 @@ class TestCourseStatusPATCH(CourseStatusAPITestCase, MobileAuthUserTestMixin, Mo
response = self.api_response(
data={
"last_visited_module_id": unicode(self.other_unit.location),
"modification_date": past_date.isoformat() # pylint: disable=maybe-no-member
"modification_date": past_date.isoformat()
},
expected_response_code=400
)
self.assertEqual(
response.data, # pylint: disable=no-member
response.data,
errors.ERROR_INVALID_MODIFICATION_DATE
)
@@ -324,7 +324,7 @@ class TestCourseStatusPATCH(CourseStatusAPITestCase, MobileAuthUserTestMixin, Mo
}
)
self.assertEqual(
response.data["last_visited_module_id"], # pylint: disable=no-member
response.data["last_visited_module_id"],
unicode(expected_subsection.location)
)
@@ -347,7 +347,7 @@ class TestCourseStatusPATCH(CourseStatusAPITestCase, MobileAuthUserTestMixin, Mo
}
)
self.assertEqual(
response.data["last_visited_module_id"], # pylint: disable=no-member
response.data["last_visited_module_id"],
unicode(self.other_sub_section.location)
)
@@ -355,7 +355,7 @@ class TestCourseStatusPATCH(CourseStatusAPITestCase, MobileAuthUserTestMixin, Mo
self.login_and_enroll()
response = self.api_response(data={"modification_date": "abc"}, expected_response_code=400)
self.assertEqual(
response.data, # pylint: disable=no-member
response.data,
errors.ERROR_INVALID_MODIFICATION_DATE
)
@@ -367,7 +367,7 @@ class TestCourseEnrollmentSerializer(MobileAPITestCase):
def test_success(self):
self.login_and_enroll()
serialized = CourseEnrollmentSerializer(CourseEnrollment.enrollments_for_user(self.user)[0]).data # pylint: disable=no-member
serialized = CourseEnrollmentSerializer(CourseEnrollment.enrollments_for_user(self.user)[0]).data
self.assertEqual(serialized['course']['video_outline'], None)
self.assertEqual(serialized['course']['name'], self.course.display_name)
self.assertEqual(serialized['course']['number'], self.course.id.course)
@@ -380,6 +380,6 @@ class TestCourseEnrollmentSerializer(MobileAPITestCase):
self.course.display_organization = "overridden_org"
self.store.update_item(self.course, self.user.id)
serialized = CourseEnrollmentSerializer(CourseEnrollment.enrollments_for_user(self.user)[0]).data # pylint: disable=no-member
serialized = CourseEnrollmentSerializer(CourseEnrollment.enrollments_for_user(self.user)[0]).data
self.assertEqual(serialized['course']['number'], self.course.display_coursenumber)
self.assertEqual(serialized['course']['org'], self.course.display_organization)

1
lms/djangoapps/mobile_api/video_outlines/tests.py
View File

@@ -2,7 +2,6 @@
"""
Tests for video outline API
"""
# pylint: disable=no-member
import ddt
import itertools
from uuid import uuid4