From f495f219cf33089ec569f734e7a12b3b8dfe03d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Andr=C3=A9s=20Rocha?= Date: Mon, 15 Oct 2012 13:28:54 -0300 Subject: [PATCH] Update common/djangoapps/external_auth/views.py Corrected comments on OpenID temporal fix --- common/djangoapps/external_auth/views.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/common/djangoapps/external_auth/views.py b/common/djangoapps/external_auth/views.py index cdb55fdb13..5c895d5609 100644 --- a/common/djangoapps/external_auth/views.py +++ b/common/djangoapps/external_auth/views.py @@ -488,16 +488,16 @@ def provider_login(request): url = endpoint + urlquote(user.username) response = openid_request.answer(True, None, url) - # TODO: for CS50 we are forcibly returning only the - # username. Following the OpenID simple registration + # TODO: for CS50 we are forcibly returning the username + # instead of fullname. In the OpenID simple registration # extension, we don't have to return any fields we don't # want to, even if they were marked as required by the # Consumer. The behavior of what to do when there are # missing fields is up to the Consumer. The proper change - # will only return the username, however this will likely + # should only return the username, however this will likely # break the CS50 client. Temporarily we will be returning - # username filling in for email and fullname in addition - # to username as sreg nickname. + # username filling in for fullname in addition to username + # as sreg nickname. results = { 'nickname': user.username, 'email': user.email,