From ed45fbba37cfd59aa7bc7d434d9aafdd3a8f679b Mon Sep 17 00:00:00 2001 From: Taimoor Ahmed Date: Fri, 5 Sep 2025 10:52:42 +0500 Subject: [PATCH] fix: Invalid read param in forum thread api This PR fixes the invalid read parameter being passed in forum update_thread api. this was somehow introduced in this commit https://github.com/openedx/edx-platform/commit/6f522f3992101707ba7df03dfa49a34af154a6e1#diff-b9d08209a02c673887f6ca72b0018758174e95508539adbcb6885f22c7844eb8L292 --- lms/djangoapps/discussion/rest_api/tests/test_views_v2.py | 1 - .../djangoapps/django_comment_common/comment_client/models.py | 1 - 2 files changed, 2 deletions(-) diff --git a/lms/djangoapps/discussion/rest_api/tests/test_views_v2.py b/lms/djangoapps/discussion/rest_api/tests/test_views_v2.py index 2351d92ee6..4247cbcab0 100644 --- a/lms/djangoapps/discussion/rest_api/tests/test_views_v2.py +++ b/lms/djangoapps/discussion/rest_api/tests/test_views_v2.py @@ -215,7 +215,6 @@ class ThreadViewSetPartialUpdateTest( "anonymous_to_peers": False, "closed": False, "pinned": False, - "read": True, "editing_user_id": str(self.user.id), } self.check_mock_called_with("update_thread", -1, **params) diff --git a/openedx/core/djangoapps/django_comment_common/comment_client/models.py b/openedx/core/djangoapps/django_comment_common/comment_client/models.py index 88606b999b..a243db5c76 100644 --- a/openedx/core/djangoapps/django_comment_common/comment_client/models.py +++ b/openedx/core/djangoapps/django_comment_common/comment_client/models.py @@ -287,7 +287,6 @@ class Model: "close_reason_code": request_params.get("close_reason_code"), "closing_user_id": request_params.get("closing_user_id"), "endorsed": request_params.get("endorsed"), - "read": request_params.get("read"), } request_data = {k: v for k, v in request_data.items() if v is not None} response = forum_api.update_thread(**request_data)