From c575c89853a575adf26fa5603ca9fba21353605d Mon Sep 17 00:00:00 2001 From: Mushtaq Ali Date: Tue, 19 May 2015 15:30:38 +0500 Subject: [PATCH] Bug - Unicode character in tab number shouldn't return 500 #TNL-2055 Adding user to AUTHORS file --- AUTHORS | 1 + lms/djangoapps/courseware/tests/test_views.py | 1 - lms/djangoapps/courseware/views.py | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/AUTHORS b/AUTHORS index 309a8e6ff3..ec963c6a81 100644 --- a/AUTHORS +++ b/AUTHORS @@ -216,3 +216,4 @@ Randy Ostler Thomas Young Andrew Dekker Christopher Lee +Mushtaq Ali diff --git a/lms/djangoapps/courseware/tests/test_views.py b/lms/djangoapps/courseware/tests/test_views.py index 05e2634cfb..4b8ed7fbcf 100644 --- a/lms/djangoapps/courseware/tests/test_views.py +++ b/lms/djangoapps/courseware/tests/test_views.py @@ -262,7 +262,6 @@ class ViewsTestCase(ModuleStoreTestCase): response = self.client.get(request_url) self.assertEqual(response.status_code, 404) - @unittest.skip def test_unicode_handling_in_url(self): url_parts = [ '/courses', diff --git a/lms/djangoapps/courseware/views.py b/lms/djangoapps/courseware/views.py index 4eaf6c413c..d478c3de00 100644 --- a/lms/djangoapps/courseware/views.py +++ b/lms/djangoapps/courseware/views.py @@ -364,7 +364,7 @@ def _index_bulk_op(request, course_key, chapter, section, position): try: int(position) except ValueError: - raise Http404("Position {} is not an integer!".format(position)) + raise Http404(u"Position {} is not an integer!".format(position)) user = request.user course = get_course_with_access(user, 'load', course_key, depth=2)