From 62a6f891c4100a09333ff0ada747b7ac7cdc5cac Mon Sep 17 00:00:00 2001
From: Chris Rodriguez <github@chrisrodriguez.me>
Date: Fri, 24 Jun 2016 14:27:15 -0400
Subject: [PATCH] AC-398 putting edx.org social media links in list, updating
 styles

---
 lms/static/sass/shared/_footer-edx.scss  |  9 ++++++
 themes/edx.org/lms/templates/footer.html | 35 +++++++++++++-----------
 2 files changed, 28 insertions(+), 16 deletions(-)

diff --git a/lms/static/sass/shared/_footer-edx.scss b/lms/static/sass/shared/_footer-edx.scss
index 80f986d9b7..c45476f6fc 100644
--- a/lms/static/sass/shared/_footer-edx.scss
+++ b/lms/static/sass/shared/_footer-edx.scss
@@ -83,6 +83,15 @@ footer#footer-edx-v3 {
       width: 100%;
     }
   }
+  
+  .social-media-links,
+  .mobile-app-links {
+      @extend %ui-no-list;
+      
+      .list-item {
+          display: inline-block;
+      }
+  }
 
   .mobile-app-links {
     @include clearfix();
diff --git a/themes/edx.org/lms/templates/footer.html b/themes/edx.org/lms/templates/footer.html
index 5a449ab561..e6b1a09ec4 100644
--- a/themes/edx.org/lms/templates/footer.html
+++ b/themes/edx.org/lms/templates/footer.html
@@ -52,22 +52,26 @@
       </div>
 
       <div class="external-links">
-        <div class="social-media-links">
-          % for link in footer['social_links']:
-          <a href="${link['url']}" class="sm-link external" title="${link['title']}" rel="noreferrer">
-            <span class="icon fa ${link['icon-class']}" aria-hidden="true"></span>
-            <span class="sr">${link['action']}</span>
-          </a>
-          % endfor
-        </div>
+        <ul class="social-media-links">
+            % for link in footer['social_links']:
+            <li class="list-item">
+                <a href="${link['url']}" class="sm-link external" title="${link['title']}" rel="noreferrer">
+                    <span class="icon fa ${link['icon-class']}" aria-hidden="true"></span>
+                    <span class="sr">${link['action']}</span>
+                </a>
+            </li>
+            % endfor
+        </ul>
 
-        <div class="mobile-app-links">
-          % for link in footer['mobile_links']:
-          <a href="${link['url']}" class="app-link external">
-            <img alt="${link['title']}" src="${link['image']}">
-          </a>
-          % endfor
-        </div>
+        <ul class="mobile-app-links">
+            % for link in footer['mobile_links']:
+            <li class="list-item">
+                <a href="${link['url']}" class="app-link external">
+                    <img alt="${link['title']}" src="${link['image']}">
+                </a>
+            </li>
+            % endfor
+        </ul>
       </div>
     </div>
 </footer>
@@ -91,4 +95,3 @@
 % if footer_js_url:
   <script type="text/javascript" src="${footer_js_url}"></script>
 % endif
-