From 28b0ba5e10309a878a1a30645706e195b149659f Mon Sep 17 00:00:00 2001 From: Vasyl Nakvasiuk Date: Thu, 8 Aug 2013 14:07:55 +0300 Subject: [PATCH 1/9] Migrate video tests to videoalpha tests, remove video tests. --- .../xmodule/tests/test_video_module.py | 104 --------------- .../xmodule/xmodule/tests/test_video_xml.py | 120 ------------------ .../courseware/tests/test_video_mongo.py | 27 ---- .../courseware/tests/test_videoalpha_xml.py | 75 ++++++++++- 4 files changed, 73 insertions(+), 253 deletions(-) delete mode 100644 common/lib/xmodule/xmodule/tests/test_video_module.py delete mode 100644 common/lib/xmodule/xmodule/tests/test_video_xml.py delete mode 100644 lms/djangoapps/courseware/tests/test_video_mongo.py diff --git a/common/lib/xmodule/xmodule/tests/test_video_module.py b/common/lib/xmodule/xmodule/tests/test_video_module.py deleted file mode 100644 index e11686176a..0000000000 --- a/common/lib/xmodule/xmodule/tests/test_video_module.py +++ /dev/null @@ -1,104 +0,0 @@ -# -*- coding: utf-8 -*- -import unittest - -from xmodule.modulestore import Location -from xmodule.video_module import VideoDescriptor -from .test_import import DummySystem - - -class VideoDescriptorImportTestCase(unittest.TestCase): - """ - Make sure that VideoDescriptor can import an old XML-based video correctly. - """ - - def test_constructor(self): - sample_xml = ''' - - ''' - location = Location(["i4x", "edX", "video", "default", - "SampleProblem1"]) - model_data = {'data': sample_xml, - 'location': location} - system = DummySystem(load_error_modules=True) - descriptor = VideoDescriptor(system, model_data) - self.assertEquals(descriptor.youtube_id_0_75, 'izygArpw-Qo') - self.assertEquals(descriptor.youtube_id_1_0, 'p2Q6BrNhdh8') - self.assertEquals(descriptor.youtube_id_1_25, '1EeWXzPdhSA') - self.assertEquals(descriptor.youtube_id_1_5, 'rABDYkeK0x8') - self.assertEquals(descriptor.show_captions, False) - self.assertEquals(descriptor.start_time, 1.0) - self.assertEquals(descriptor.end_time, 60) - self.assertEquals(descriptor.track, 'http://www.example.com/track') - self.assertEquals(descriptor.source, 'http://www.example.com/source.mp4') - - def test_from_xml(self): - module_system = DummySystem(load_error_modules=True) - xml_data = ''' - - ''' - output = VideoDescriptor.from_xml(xml_data, module_system) - self.assertEquals(output.youtube_id_0_75, 'izygArpw-Qo') - self.assertEquals(output.youtube_id_1_0, 'p2Q6BrNhdh8') - self.assertEquals(output.youtube_id_1_25, '1EeWXzPdhSA') - self.assertEquals(output.youtube_id_1_5, 'rABDYkeK0x8') - self.assertEquals(output.show_captions, False) - self.assertEquals(output.start_time, 1.0) - self.assertEquals(output.end_time, 60) - self.assertEquals(output.track, 'http://www.example.com/track') - self.assertEquals(output.source, 'http://www.example.com/source.mp4') - - def test_from_xml_missing_attributes(self): - """ - Ensure that attributes have the right values if they aren't - explicitly set in XML. - """ - module_system = DummySystem(load_error_modules=True) - xml_data = ''' - - ''' - output = VideoDescriptor.from_xml(xml_data, module_system) - self.assertEquals(output.youtube_id_0_75, '') - self.assertEquals(output.youtube_id_1_0, 'p2Q6BrNhdh8') - self.assertEquals(output.youtube_id_1_25, '1EeWXzPdhSA') - self.assertEquals(output.youtube_id_1_5, '') - self.assertEquals(output.show_captions, True) - self.assertEquals(output.start_time, 0.0) - self.assertEquals(output.end_time, 0.0) - self.assertEquals(output.track, 'http://www.example.com/track') - self.assertEquals(output.source, 'http://www.example.com/source.mp4') - - def test_from_xml_no_attributes(self): - """ - Make sure settings are correct if none are explicitly set in XML. - """ - module_system = DummySystem(load_error_modules=True) - xml_data = '' - output = VideoDescriptor.from_xml(xml_data, module_system) - self.assertEquals(output.youtube_id_0_75, '') - self.assertEquals(output.youtube_id_1_0, 'OEoXaMPEzfM') - self.assertEquals(output.youtube_id_1_25, '') - self.assertEquals(output.youtube_id_1_5, '') - self.assertEquals(output.show_captions, True) - self.assertEquals(output.start_time, 0.0) - self.assertEquals(output.end_time, 0.0) - self.assertEquals(output.track, '') - self.assertEquals(output.source, '') diff --git a/common/lib/xmodule/xmodule/tests/test_video_xml.py b/common/lib/xmodule/xmodule/tests/test_video_xml.py deleted file mode 100644 index 1ccc633ee2..0000000000 --- a/common/lib/xmodule/xmodule/tests/test_video_xml.py +++ /dev/null @@ -1,120 +0,0 @@ -# -*- coding: utf-8 -*- -"""Test for Video Xmodule functional logic. -These tests data readed from xml, not from mongo. - -We have a ModuleStoreTestCase class defined in -common/lib/xmodule/xmodule/modulestore/tests/django_utils.py. -You can search for usages of this in the cms and lms tests for examples. -You use this so that it will do things like point the modulestore -setting to mongo, flush the contentstore before and after, load the -templates, etc. -You can then use the CourseFactory and XModuleItemFactory as defined in -common/lib/xmodule/xmodule/modulestore/tests/factories.py to create the -course, section, subsection, unit, etc. -""" - -from mock import Mock - -from xmodule.video_module import VideoDescriptor, VideoModule, _parse_time, _parse_youtube -from xmodule.modulestore import Location -from xmodule.tests import get_test_system -from xmodule.tests import LogicTest - - -class VideoFactory(object): - """A helper class to create video modules with various parameters - for testing. - """ - - # tag that uses youtube videos - sample_problem_xml_youtube = """ - - """ - - @staticmethod - def create(): - """Method return Video Xmodule instance.""" - location = Location(["i4x", "edX", "video", "default", - "SampleProblem1"]) - model_data = {'data': VideoFactory.sample_problem_xml_youtube, 'location': location} - - descriptor = Mock(weight="1", url_name="SampleProblem1") - - system = get_test_system() - system.render_template = lambda template, context: context - module = VideoModule(system, descriptor, model_data) - - return module - - -class VideoModuleLogicTest(LogicTest): - """Tests for logic of Video Xmodule.""" - - descriptor_class = VideoDescriptor - - raw_model_data = { - 'data': '