From f165f52d882bba1aac7a38e482aa481e9565de45 Mon Sep 17 00:00:00 2001 From: stv Date: Tue, 5 Mar 2019 01:21:35 -0800 Subject: [PATCH] Remove course listing from user tab of sysadmin I'm admittedly unclear why we decided to include a listing of _courses_ in the _users_ tab, when this listing is already available via the _courses_ tab, which is where you'd expect to find it. Particularly problematic here is the impact this has on page loads.. For instances with a large number of courses [1], pulling and rendering adds a nontrivial amount of overhead and leads to longer load times. In our case, this often leads to a page timeout. Since this is the main landing page for the sysadmin dashboard, it presents the appearance that the entire dashboard has crashed. In not being able to access the main page, you can't access any of the other tabs via navigation, unless you manually enter the URL :\ [1] ~750 courses, in one example --- lms/djangoapps/dashboard/sysadmin.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/lms/djangoapps/dashboard/sysadmin.py b/lms/djangoapps/dashboard/sysadmin.py index abf1a466fb..b2316fdb49 100644 --- a/lms/djangoapps/dashboard/sysadmin.py +++ b/lms/djangoapps/dashboard/sysadmin.py @@ -183,15 +183,6 @@ class Users(SysadminDashboardView): self.datatable['data'] = [[_('Total number of users'), User.objects.all().count()]] - self.msg += HTML(u'

{0}

').format( - _('Courses loaded in the modulestore') - ) - self.msg += HTML(u'
    ') - for course in self.get_courses(): - self.msg += HTML(u'
  1. {0} ({1})
    2. ').format( - escape(text_type(course.id)), text_type(course.location)) - self.msg += HTML(u'
') - def get(self, request): if not request.user.is_staff: