Andal.LND/edx-platform
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: refactor code based on pep-8 guideline

Browse Source
This commit is contained in:
Devasia Joseph
2025-08-07 15:29:14 +05:30
committed by Muhammad Faraz Maqsood
parent ca45009a31
commit e2ce7debf2
8 changed files with 44 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
cms/djangoapps/contentstore/core/course_optimizer_provider.py
View File

@@ -7,7 +7,7 @@ from opaque_keys.edx.keys import CourseKey
from user_tasks.conf import settings as user_tasks_settings
from user_tasks.models import UserTaskArtifact, UserTaskStatus
from cms.djangoapps.contentstore.tasks import CourseLinkCheckTask, LinkState, _get_urls
from cms.djangoapps.contentstore.tasks import CourseLinkCheckTask, LinkState, extract_content_URLs_from_course
from cms.djangoapps.contentstore.utils import create_course_info_usage_key
from cms.djangoapps.contentstore.xblock_storage_handlers.view_handlers import get_xblock
from cms.djangoapps.contentstore.xblock_storage_handlers.xblock_helpers import usage_key_with_run
@@ -469,7 +469,7 @@ def _generate_course_updates_content(course, updates_links):
for update in update_items:
if update.get("status") != "deleted":
update_content = update.get("content", "")
update_links = _get_urls(update_content) if update_content else []
update_links = extract_content_URLs_from_course(update_content) if update_content else []
# Match links with their states
update_link_data = _create_empty_links_data()
@@ -480,7 +480,8 @@ def _generate_course_updates_content(course, updates_links):
course_updates.append(
{
"name": update.get("date", "Unknown Date"),
"id": str(update.get("id")),
"displayName": update.get("date", "Unknown Date"),
"url": f"/course/{str(course.id)}/course_info",
**update_link_data,
}
@@ -515,7 +516,8 @@ def _generate_handouts_content(course, handouts_links):
course_handouts = [
{
"name": "handouts",
"id": str(usage_key),
"displayName": "handouts",
"url": f"/course/{str(course.id)}/course_info",
**links_data,
}
@@ -544,7 +546,8 @@ def _generate_custom_pages_content(course, custom_pages_links):
if isinstance(tab, StaticTab):
block_id = str(course.id.make_usage_key("static_tab", tab.url_slug))
custom_pages.append({
"name": tab.name,
"id": block_id,
"displayName": tab.name,
"url": f"/course/{str(course.id)}/custom-pages",
**links_by_page.get(block_id, _create_empty_links_data()),
})

8
cms/djangoapps/contentstore/core/tests/test_course_optimizer_provider.py
View File

@@ -13,9 +13,9 @@ from cms.djangoapps.contentstore.core.course_optimizer_provider import (
generate_broken_links_descriptor,
sort_course_sections
)
from cms.djangoapps.contentstore.tasks import LinkState, _get_urls
from cms.djangoapps.contentstore.tasks import LinkState, extract_content_URLs_from_course
from cms.djangoapps.contentstore.tests.utils import CourseTestCase
from cms.djangoapps.contentstore.utils import _contains_previous_course_reference
from cms.djangoapps.contentstore.utils import contains_previous_course_reference
from xmodule.tabs import StaticTab
@@ -325,7 +325,7 @@ class TestLinkCheckProvider(CourseTestCase):
for url, expected_match in test_cases:
with self.subTest(url=url, expected=expected_match):
result = _contains_previous_course_reference(url, previous_course_key)
result = contains_previous_course_reference(url, previous_course_key)
self.assertEqual(
result,
expected_match,
@@ -356,7 +356,7 @@ class TestLinkCheckProvider(CourseTestCase):
for content, expected_urls in test_cases:
with self.subTest(content=content):
urls = _get_urls(content)
urls = extract_content_URLs_from_course(content)
for expected_url in expected_urls:
self.assertIn(
expected_url,