From e2b7d289a88d9e640958218baa699bed1b6078e8 Mon Sep 17 00:00:00 2001 From: Kshitij Sobti Date: Wed, 13 Jun 2018 14:59:06 +0530 Subject: [PATCH] Only pass error to showErrorMessage --- lms/static/js/discovery/discovery_factory.js | 2 +- lms/static/js/discovery/views/search_form.js | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/lms/static/js/discovery/discovery_factory.js b/lms/static/js/discovery/discovery_factory.js index 91ce584766..9756e614f2 100644 --- a/lms/static/js/discovery/discovery_factory.js +++ b/lms/static/js/discovery/discovery_factory.js @@ -72,7 +72,7 @@ }); dispatcher.listenTo(search, 'error', function() { - form.showErrorMessage(search); + form.showErrorMessage(search.errorMessage); form.hideLoadingIndicator(); }); diff --git a/lms/static/js/discovery/views/search_form.js b/lms/static/js/discovery/views/search_form.js index d467125273..256302bd93 100644 --- a/lms/static/js/discovery/views/search_form.js +++ b/lms/static/js/discovery/views/search_form.js @@ -60,12 +60,8 @@ this.clearSearch(); }, - showErrorMessage: function(search) { - if (search && search.errorMessage) { - this.$message.text(gettext(search.errorMessage)); - } else { - this.$message.text(gettext('There was an error, try searching again.')); - } + showErrorMessage: function (error) { + this.$message.text(gettext(error || 'There was an error, try searching again.')); } });