Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #7607 from edx/remove-code-ownership-page

Browse Source 
Removed references to code ownership page
This commit is contained in:
David Baumgold
2015-04-07 10:40:06 -04:00
parent 397da0dbde 2e5353aef7
commit e12c2ec4eb
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
CONTRIBUTING.rst
View File

@@ -13,7 +13,7 @@ Step 0: Join the Conversation
Got an idea for how to improve the codebase? Fantastic, we'd love to hear about Got an idea for how to improve the codebase? Fantastic, we'd love to hear about
it! Before you dive in and spend a lot of time and effort making a pull request, it! Before you dive in and spend a lot of time and effort making a pull request,
it's a good idea to discuss your idea with other interested developers and/or the it's a good idea to discuss your idea with other interested developers and/or the
edX product team. You may get some valuable feedback that changes how you think edX product team. You may get some valuable feedback that changes how you think
about your idea, or you may find other developers who have the same idea and want about your idea, or you may find other developers who have the same idea and want
to work together. to work together.
@@ -66,7 +66,7 @@ For asynchronous conversation, we have several mailing lists on Google Groups:
Byte-sized Tasks & Bugs Byte-sized Tasks & Bugs
----------------------- -----------------------
If you are contributing for the first time and want a gentle introduction, If you are contributing for the first time and want a gentle introduction,
or if you aren't sure what to work on, have a look at the list of or if you aren't sure what to work on, have a look at the list of
`byte-sized bugs and tasks`_ in the tracker. These tasks are selected for their `byte-sized bugs and tasks`_ in the tracker. These tasks are selected for their
small size, and usually don't require a broad knowledge of the edX platform. small size, and usually don't require a broad knowledge of the edX platform.
@@ -140,12 +140,9 @@ Step 5: Code Review by Core Committer(s)
If your pull request meets the requirements listed in the If your pull request meets the requirements listed in the
`contributor documentation`_, and it hasn't been rejected by a product owner, `contributor documentation`_, and it hasn't been rejected by a product owner,
then it will be scheduled for code review by one or more core committers. This then it will be scheduled for code review by one or more core committers. This
process sometimes takes awhile: currently, all core committers on the project process sometimes takes awhile: most of the core committers on the project
are employees of edX, and they have to balance their time between code review are employees of edX, and they have to balance their time between code review
and new development. Please also read our `code ownership page`_, which and new development.
lists areas and concepts in the codebase that are "owned" by certain developers.
If your change touches one of these areas or concepts, that developer should be
one of the reviewers.
Once the code review process has started, please be responsive to comments on Once the code review process has started, please be responsive to comments on
the pull request, so we can keep the review process moving forward. the pull request, so we can keep the review process moving forward.
@@ -153,8 +150,6 @@ If you are unable to respond for a few days, that's fine, but
please add a comment informing us of that -- otherwise, it looks like you're please add a comment informing us of that -- otherwise, it looks like you're
abandoning your work! abandoning your work!
.. _code ownership page: https://github.com/edx/edx-platform/wiki/Code-Ownership
Step 6: Merge! Step 6: Merge!
============== ==============