diff --git a/lms/djangoapps/courseware/grades.py b/lms/djangoapps/courseware/grades.py index e3e66724a5..df079b7703 100644 --- a/lms/djangoapps/courseware/grades.py +++ b/lms/djangoapps/courseware/grades.py @@ -217,7 +217,7 @@ def grade(student, request, course, student_module_cache=None, keep_raw_scores=F def grade_for_percentage(grade_cutoffs, percentage): """ - Returns a letter grade 'A' 'B' 'C' or None. + Returns a letter grade as defined in grading_policy (e.g. 'A' 'B' 'C' for 6.002x) or None. Arguments - grade_cutoffs is a dictionary mapping a grade to the lowest @@ -226,7 +226,10 @@ def grade_for_percentage(grade_cutoffs, percentage): """ letter_grade = None - for possible_grade in ['A', 'B', 'C']: + + # Possible grades, sorted in descending order of score + descending_grades = sorted(grade_cutoffs, key=lambda x: grade_cutoffs[x], reverse=True) + for possible_grade in descending_grades: if percentage >= grade_cutoffs[possible_grade]: letter_grade = possible_grade break diff --git a/lms/static/sass/course/_profile.scss b/lms/static/sass/course/_profile.scss index 5b1d6ee068..0683781e44 100644 --- a/lms/static/sass/course/_profile.scss +++ b/lms/static/sass/course/_profile.scss @@ -150,7 +150,7 @@ div.profile-wrapper { } div#grade-detail-graph { - min-height: 300px; + min-height: 400px; width: 100%; } diff --git a/lms/templates/courseware/progress_graph.js b/lms/templates/courseware/progress_graph.js index 9826250331..44ee2efd07 100644 --- a/lms/templates/courseware/progress_graph.js +++ b/lms/templates/courseware/progress_graph.js @@ -18,7 +18,7 @@ $(function () { opacity: 0.90 }).appendTo("body").fadeIn(200); } - + /* -------------------------------- Grade detail bars -------------------------------- */ <% @@ -97,7 +97,8 @@ $(function () { ## ----------------------------- Grade cutoffs ------------------------- ## grade_cutoff_ticks = [ [1, "100%"], [0, "0%"] ] - for grade in ['A', 'B', 'C']: + descending_grades = sorted(grade_cutoffs, key=lambda x: grade_cutoffs[x], reverse=True) + for grade in descending_grades: percent = grade_cutoffs[grade] grade_cutoff_ticks.append( [ percent, "{0} {1:.0%}".format(grade, percent) ] ) %> @@ -109,18 +110,25 @@ $(function () { var droppedScores = ${ json.dumps(droppedScores) }; var grade_cutoff_ticks = ${ json.dumps(grade_cutoff_ticks) } - //Alwasy be sure that one series has the xaxis set to 2, or the second xaxis labels won't show up + //Always be sure that one series has the xaxis set to 2, or the second xaxis labels won't show up series.push( {label: 'Dropped Scores', data: droppedScores, points: {symbol: "cross", show: true, radius: 3}, bars: {show: false}, color: "#333"} ); + // Allow for arbitrary grade markers e.g. ['A', 'B', 'C'], ['Pass'], etc. + var ascending_grades = grade_cutoff_ticks.map(function (el) { return el[0]; }); // Percentage point (in decimal) of each grade cutoff + ascending_grades.sort(); + + var colors = ['#f3f3f3', '#e9e9e9', '#ddd']; + var markings = []; + for(var i=1; i