From e90c6ae5a2a087a9a626a6f70b748fe343271abb Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Wed, 2 Dec 2020 11:33:32 -0500 Subject: [PATCH] Remove all models related to shoppingcart. DEPR-43 - Removal of Shoppingcart. All models have been removed and the change has been deployed to production so this should be safe to do. It's strange that the ORM decided to drop certain fields before dropping the whole models but decided to leave it all as the ORM generated it rather than trying to manually change it. Also turn the check back on to make sure people don't actually check in code without the relevant migration files. --- common/djangoapps/util/tests/test_db.py | 3 - .../migrations/0005_drop_tables.py | 179 ++++++++++++++++++ 2 files changed, 179 insertions(+), 3 deletions(-) create mode 100644 lms/djangoapps/shoppingcart/migrations/0005_drop_tables.py diff --git a/common/djangoapps/util/tests/test_db.py b/common/djangoapps/util/tests/test_db.py index a258920890..c9e951db49 100644 --- a/common/djangoapps/util/tests/test_db.py +++ b/common/djangoapps/util/tests/test_db.py @@ -198,9 +198,6 @@ class MigrationTests(TestCase): """ @override_settings(MIGRATION_MODULES={}) - @unittest.skip( - "Temporary skip for https://openedx.atlassian.net/browse/DEPR-43 where shoppingcart models are to be removed" - ) def test_migrations_are_in_sync(self): """ Tests that the migration files are in sync with the models. diff --git a/lms/djangoapps/shoppingcart/migrations/0005_drop_tables.py b/lms/djangoapps/shoppingcart/migrations/0005_drop_tables.py new file mode 100644 index 0000000000..7826bc5b4c --- /dev/null +++ b/lms/djangoapps/shoppingcart/migrations/0005_drop_tables.py @@ -0,0 +1,179 @@ +# Generated by Django 2.2.17 on 2020-12-02 16:31 + +from django.db import migrations + + +class Migration(migrations.Migration): + + dependencies = [ + ('shoppingcart', '0004_change_meta_options'), + ] + + operations = [ + migrations.RemoveField( + model_name='certificateitem', + name='course_enrollment', + ), + migrations.RemoveField( + model_name='certificateitem', + name='orderitem_ptr', + ), + migrations.RemoveField( + model_name='coupon', + name='created_by', + ), + migrations.RemoveField( + model_name='couponredemption', + name='coupon', + ), + migrations.RemoveField( + model_name='couponredemption', + name='order', + ), + migrations.RemoveField( + model_name='couponredemption', + name='user', + ), + migrations.RemoveField( + model_name='courseregcodeitem', + name='orderitem_ptr', + ), + migrations.DeleteModel( + name='CourseRegCodeItemAnnotation', + ), + migrations.RemoveField( + model_name='courseregistrationcode', + name='created_by', + ), + migrations.RemoveField( + model_name='courseregistrationcode', + name='invoice', + ), + migrations.RemoveField( + model_name='courseregistrationcode', + name='invoice_item', + ), + migrations.RemoveField( + model_name='courseregistrationcode', + name='order', + ), + migrations.RemoveField( + model_name='courseregistrationcodeinvoiceitem', + name='invoiceitem_ptr', + ), + migrations.RemoveField( + model_name='donation', + name='orderitem_ptr', + ), + migrations.RemoveField( + model_name='donationconfiguration', + name='changed_by', + ), + migrations.RemoveField( + model_name='invoicehistory', + name='invoice', + ), + migrations.RemoveField( + model_name='invoiceitem', + name='invoice', + ), + migrations.RemoveField( + model_name='invoicetransaction', + name='created_by', + ), + migrations.RemoveField( + model_name='invoicetransaction', + name='invoice', + ), + migrations.RemoveField( + model_name='invoicetransaction', + name='last_modified_by', + ), + migrations.RemoveField( + model_name='order', + name='user', + ), + migrations.RemoveField( + model_name='orderitem', + name='order', + ), + migrations.RemoveField( + model_name='orderitem', + name='user', + ), + migrations.RemoveField( + model_name='paidcourseregistration', + name='course_enrollment', + ), + migrations.RemoveField( + model_name='paidcourseregistration', + name='orderitem_ptr', + ), + migrations.DeleteModel( + name='PaidCourseRegistrationAnnotation', + ), + migrations.RemoveField( + model_name='registrationcoderedemption', + name='course_enrollment', + ), + migrations.RemoveField( + model_name='registrationcoderedemption', + name='order', + ), + migrations.RemoveField( + model_name='registrationcoderedemption', + name='redeemed_by', + ), + migrations.RemoveField( + model_name='registrationcoderedemption', + name='registration_code', + ), + migrations.DeleteModel( + name='CertificateItem', + ), + migrations.DeleteModel( + name='Coupon', + ), + migrations.DeleteModel( + name='CouponRedemption', + ), + migrations.DeleteModel( + name='CourseRegCodeItem', + ), + migrations.DeleteModel( + name='CourseRegistrationCode', + ), + migrations.DeleteModel( + name='CourseRegistrationCodeInvoiceItem', + ), + migrations.DeleteModel( + name='Donation', + ), + migrations.DeleteModel( + name='DonationConfiguration', + ), + migrations.DeleteModel( + name='Invoice', + ), + migrations.DeleteModel( + name='InvoiceHistory', + ), + migrations.DeleteModel( + name='InvoiceItem', + ), + migrations.DeleteModel( + name='InvoiceTransaction', + ), + migrations.DeleteModel( + name='Order', + ), + migrations.DeleteModel( + name='OrderItem', + ), + migrations.DeleteModel( + name='PaidCourseRegistration', + ), + migrations.DeleteModel( + name='RegistrationCodeRedemption', + ), + ]