Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change subquery to JOIN in list_course_keys API

Browse Source
This commit is contained in:
Troy Sankey
2020-09-25 12:54:37 -04:00
parent 83a0327b92
commit dded86d2ae
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lms/djangoapps/course_api/api.py
View File

@@ -184,15 +184,16 @@ def list_course_keys(request, username, role):
# TNL-7448, DESUPPORT-416, and probably more. # TNL-7448, DESUPPORT-416, and probably more.
# #
# This is a simplified implementation that does not consider org-level access grants (e.g. when course_id is # This is a simplified implementation that does not consider org-level access grants (e.g. when course_id is
# blank). # empty).
filtered_course_keys = ( filtered_course_keys = (
CourseAccessRole.objects.filter( CourseAccessRole.objects.filter(
user=user, user=user,
# Having the instructor role implies staff access. # Having the instructor role implies staff access.
role__in=['staff', 'instructor'], role__in=['staff', 'instructor'],
# We need to check against CourseOverview so that we don't return any Libraries.
course_id__in=CourseOverview.objects.all(),
) )
# We need to check against CourseOverview so that we don't return any Libraries.
.extra(tables=['course_overviews_courseoverview'], where=['course_id = course_overviews_courseoverview.id'])
# For good measure, make sure we don't return empty course IDs.
.exclude(course_id=CourseKeyField.Empty) .exclude(course_id=CourseKeyField.Empty)
.order_by('course_id') .order_by('course_id')
.values_list('course_id', flat=True) .values_list('course_id', flat=True)