From dcfa7ea72ce6bedd1a54624df989f4e0af1d75ea Mon Sep 17 00:00:00 2001 From: Justin Hynes Date: Tue, 17 Nov 2020 14:14:07 -0500 Subject: [PATCH] MB-714 | Fix log message when generating certificates [MB-714] - While investigating a certificate generation issue I happened to notice a log statement whose arguments were backwards --- lms/djangoapps/certificates/api.py | 2 +- lms/djangoapps/instructor/tests/test_api.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lms/djangoapps/certificates/api.py b/lms/djangoapps/certificates/api.py index 42343da884..f0a90f8f19 100644 --- a/lms/djangoapps/certificates/api.py +++ b/lms/djangoapps/certificates/api.py @@ -208,7 +208,7 @@ def generate_user_certificates(student, course_key, course=None, insecure=False, if beta_testers_queryset.filter(username=student.username): message = u'Cancelling course certificate generation for user [{}] against course [{}], user is a Beta Tester.' - log.info(message.format(course_key, student.username)) + log.info(message.format(student.username, course_key)) return xqueue = XQueueCertInterface() diff --git a/lms/djangoapps/instructor/tests/test_api.py b/lms/djangoapps/instructor/tests/test_api.py index 4bb6c61379..ed067c57c3 100644 --- a/lms/djangoapps/instructor/tests/test_api.py +++ b/lms/djangoapps/instructor/tests/test_api.py @@ -1967,7 +1967,8 @@ class TestInstructorAPIBulkBetaEnrollment(SharedModuleStoreTestCase, LoginEnroll with LogCapture() as capture: message = u'Cancelling course certificate generation for user [{}] against course [{}], ' \ u'user is a Beta Tester.' - message = message.format(self.course.id, self.beta_tester.username) + message = message.format(self.beta_tester.username, self.course.id) + generate_user_certificates(self.beta_tester, self.course.id, self.course) capture.check_present(('edx.certificate', 'INFO', message))